summaryrefslogtreecommitdiffstats
blob: 23fb3497c42b875845762b2c5babf22be6740aec (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
/*  Copyright (c) 2016, Isode Limited, London, England.
 *  All rights reserved.
 *
 *  Acquisition and use of this software and related materials for any
 *  purpose requires a written license agreement from Isode Limited,
 *  or a written license from an organisation licensed by Isode Limited
 *  to grant such a license.
 *
 */
package com.isode.stroke.avatars;

import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertNotNull;
import static org.junit.Assert.assertNull;
import static org.junit.Assert.fail;

import java.util.ArrayList;
import java.util.HashMap;
import java.util.List;
import java.util.Map;

import org.junit.Test;

import com.isode.stroke.base.ByteArray;
import com.isode.stroke.client.DummyStanzaChannel;
import com.isode.stroke.crypto.CryptoProvider;
import com.isode.stroke.crypto.JavaCryptoProvider;
import com.isode.stroke.elements.IQ;
import com.isode.stroke.elements.VCard;
import com.isode.stroke.jid.JID;
import com.isode.stroke.muc.MUCRegistry;
import com.isode.stroke.queries.IQRouter;
import com.isode.stroke.signals.Slot1;
import com.isode.stroke.stringcodecs.Hexify;
import com.isode.stroke.vcards.VCardManager;
import com.isode.stroke.vcards.VCardMemoryStorage;

/**
 * Tests for {@link CombinedAvatarProvider}
 */
public class CombinedAvatarProviderTest {

    private final DummyAvatarProvider avatarProvider1 = new DummyAvatarProvider();
    private final DummyAvatarProvider avatarProvider2 = new DummyAvatarProvider();
    private final JID user1 = new JID("user1@bar.com/bla");
    private final JID user2 = new JID("user2@foo.com/baz");
    private final String avatarHash1 = "ABCDEFG";
    private final String avatarHash2 = "XYZU";
    private final String avatarHash3 = "IDGH";
    private final List<JID> changes = new ArrayList<JID>();

    @Test
    public void testGetAvatarWithNoAvatarProviderReturnsEmpty() {
        CombinedAvatarProvider testling = createProvider();
        String hash = testling.getAvatarHash(user1);
        assertNull(hash);
    }
    
    @Test
    public void testGetAvatarWithSingleAvatarProvider() {
        CombinedAvatarProvider testling = createProvider();
        avatarProvider1.avatars.put(user1, avatarHash1);
        testling.addProvider(avatarProvider1);
        String hash = testling.getAvatarHash(user1);
        assertEquals(avatarHash1, hash);
    }
    
    @Test
    public void testGetAvatarWithMultipleAvatarProviderReturnsFirstAvatar() {
        CombinedAvatarProvider testling = createProvider();
        avatarProvider1.avatars.put(user1, avatarHash1);
        avatarProvider2.avatars.put(user1, avatarHash2);
        testling.addProvider(avatarProvider1);
        testling.addProvider(avatarProvider2);
        String hash = testling.getAvatarHash(user1);
        assertEquals(avatarHash1,hash);
    }
    
    @Test
    public void testGetAvatarWithMultipleAvatarProviderAndFailingFirstProviderReturnsSecondAvatar() {
        CombinedAvatarProvider testling = createProvider();
        avatarProvider2.avatars.put(user1, avatarHash2);
        testling.addProvider(avatarProvider1);
        testling.addProvider(avatarProvider2);
        String hash = testling.getAvatarHash(user1);
        assertEquals(avatarHash2,hash);
    }
    
    @Test
    public void testProviderUpdateTriggersChange() {
        CombinedAvatarProvider testling = createProvider();
        testling.addProvider(avatarProvider1);
        avatarProvider1.avatars.put(user1, avatarHash1);
        avatarProvider1.onAvatarChanged.emit(user1);
        assertEquals(1,changes.size());
        assertEquals(user1,changes.get(0));
    }
    
    @Test
    public void testProviderUpdateWithoutChangeDoesNotTriggerChange() {
        CombinedAvatarProvider testling = createProvider();
        testling.addProvider(avatarProvider1);
        testling.addProvider(avatarProvider2);
        avatarProvider1.avatars.put(user1, avatarHash1);
        avatarProvider1.onAvatarChanged.emit(user1);
        changes.clear();
        
        avatarProvider2.avatars.put(user1, avatarHash2);
        avatarProvider2.onAvatarChanged.emit(user1);
        
        assertEquals(0,changes.size());
    }
    
    @Test
    public void testProviderSecondUpdateTriggersChange() {
        CombinedAvatarProvider testling = createProvider();
        testling.addProvider(avatarProvider1);
        avatarProvider1.avatars.put(user1, avatarHash1);
        avatarProvider1.onAvatarChanged.emit(user1);
        changes.clear();
        avatarProvider1.avatars.put(user1, avatarHash2);
        avatarProvider1.onAvatarChanged.emit(user1);
        
        assertEquals(1,changes.size());
        assertEquals(user1,changes.get(0));
    }
    
    @Test
    public void testProviderUpdateWithAvatarDisappearingTriggersChange() {
        CombinedAvatarProvider testling = createProvider();
        testling.addProvider(avatarProvider1);
        avatarProvider1.avatars.put(user1, avatarHash1);
        avatarProvider1.onAvatarChanged.emit(user1);
        changes.clear();
        avatarProvider1.avatars.clear();
        avatarProvider1.onAvatarChanged.emit(user1);
        assertNull(testling.getAvatarHash(user1));
        assertEquals(1, changes.size());
        assertEquals(user1,changes.get(0));
    }
    
    @Test
    public void testProviderUpdateAfterAvatarDisappearedTriggersChange() {
        CombinedAvatarProvider testling = createProvider();
        testling.addProvider(avatarProvider1);
        avatarProvider1.avatars.put(user1, avatarHash1);
        avatarProvider1.onAvatarChanged.emit(user1);
        avatarProvider1.avatars.clear();
        avatarProvider1.onAvatarChanged.emit(user1);
        changes.clear();
        avatarProvider1.avatars.put(user1, avatarHash1);
        avatarProvider1.onAvatarChanged.emit(user1);
        assertEquals(1,changes.size());
        assertEquals(user1,changes.get(0));
    }
    
    @Test
    public void testProviderUpdateAfterGetDoesNotTriggerChange() {
        CombinedAvatarProvider testling = createProvider();
        testling.addProvider(avatarProvider1);
        avatarProvider1.avatars.put(user1, avatarHash1);
        testling.getAvatarHash(user1);
        avatarProvider1.onAvatarChanged.emit(user1);
        assertEquals(0,changes.size());
    }
    
    @Test
    public void testRemoveProviderDisconnectsUpdates() {
        CombinedAvatarProvider testling = createProvider();
        testling.addProvider(avatarProvider1);
        testling.addProvider(avatarProvider2);
        testling.removeProvider(avatarProvider1);
        avatarProvider1.avatars.put(user1, avatarHash1);
        avatarProvider2.avatars.put(user1, avatarHash2);
        avatarProvider1.onAvatarChanged.emit(user1);
        assertEquals(0,changes.size());
    }
    
    @Test
    public void testProviderUpdateBareJIDAfterGetFullJID() {
        CombinedAvatarProvider testling = createProvider();
        avatarProvider1.useBare = true;
        testling.addProvider(avatarProvider1);
        
        avatarProvider1.avatars.put(user1.toBare(),avatarHash1);
        testling.getAvatarHash(user1);
        avatarProvider1.avatars.put(user1.toBare(),avatarHash2);
        avatarProvider1.onAvatarChanged.emit(user1.toBare());
        
        String hash = testling.getAvatarHash(user1);
        assertEquals(avatarHash2,hash);
    }
    
    @Test
    public void testAddRemoveFallthrough() {
        JID ownJID = new JID("user0@own.com/res");
        JID user1 = new JID("user1@bar.com/bla");
        
        CryptoProvider crypto = new JavaCryptoProvider();
        DummyStanzaChannel stanzaChannel = new DummyStanzaChannel();
        stanzaChannel.setAvailable(true);
        IQRouter iqRouter = new IQRouter(stanzaChannel);
        MUCRegistry mucRegistry = new MUCRegistry();
        AvatarMemoryStorage avatarStorage = new AvatarMemoryStorage();
        VCardMemoryStorage vCardStorage = new VCardMemoryStorage(crypto);
        VCardManager vcardManager = new VCardManager(ownJID, iqRouter, vCardStorage);
        
        VCardUpdateAvatarManager updateManager = 
                new VCardUpdateAvatarManager(vcardManager, stanzaChannel, avatarStorage, 
                        crypto, mucRegistry);
        updateManager.onAvatarChanged.connect(new Slot1<JID>() {

            @Override
            public void call(JID jid) {
                handleAvatarChanged(jid);
            }
            
        });
        
        VCardAvatarManager manager = 
                new VCardAvatarManager(vcardManager, avatarStorage, crypto, mucRegistry);
        manager.onAvatarChanged.connect(new Slot1<JID>() {

            @Override
            public void call(JID jid) {
                handleAvatarChanged(jid);
            }
            
        });
        
        OfflineAvatarManager offlineManager = new OfflineAvatarManager(avatarStorage);
        offlineManager.onAvatarChanged.connect(new Slot1<JID>() {

            @Override
            public void call(JID jid) {
                handleAvatarChanged(jid);
            }
            
        });
        
        CombinedAvatarProvider testling = createProvider();
        avatarProvider1.useBare = true;
        testling.addProvider(updateManager);
        testling.addProvider(manager);
        testling.addProvider(offlineManager);
        
        // Place an avatar in the cache, check that it reads back OK
        
        assertEquals(0,changes.size());
        
        ByteArray avatar1 = new ByteArray("abcdefg");
        String avatar1Hash = Hexify.hexify(crypto.getSHA1Hash(avatar1));
        VCard vcard1 = new VCard();
        vcard1.setPhoto(avatar1);
        
        vCardStorage.setVCard(user1.toBare(), vcard1);
        String testHash = testling.getAvatarHash(user1.toBare());
        assertEquals(avatar1Hash,testHash);
        
        VCard storedVCard = vCardStorage.getVCard(user1.toBare());
        assertNotNull(storedVCard);
        testHash = Hexify.hexify(crypto.getSHA1Hash(storedVCard.getPhoto()));
        assertEquals(avatar1Hash, testHash);
        
        // Change the Avatar by sending a VCard IQ
        
        vcardManager.requestVCard(user1.toBare());
        assertEquals(1,stanzaChannel.sentStanzas.size());
        IQ request = (IQ) stanzaChannel.sentStanzas.lastElement();
        VCard payload = request.getPayload(new VCard());
        assertNotNull(payload);
        stanzaChannel.sentStanzas.clear();
        
        ByteArray avatar2 = new ByteArray("1234567");
        String avatar2Hash = Hexify.hexify(crypto.getSHA1Hash(avatar2));
        VCard vcard2 = new VCard();
        vcard2.setPhoto(avatar2);
        
        IQ reply = new IQ();
        reply.setTo(request.getFrom());
        reply.setFrom(request.getTo());
        reply.setID(request.getID());
        reply.addPayload(vcard2);
        reply.setType(IQ.Type.Result);
        
        stanzaChannel.onIQReceived.emit(reply);
        
        // Check that we changed the avatar succesfully and that we were notified of the changes
        
        testHash = testling.getAvatarHash(user1.toBare());
        assertEquals(avatar2Hash,testHash);
        assertEquals(3,changes.size());
        assertEquals(user1.toBare(),changes.get(0));
        assertEquals(user1.toBare(),changes.get(1));
        assertEquals(user1.toBare(),changes.get(2));
        changes.clear();
        storedVCard = vCardStorage.getVCard(user1.toBare());
        assertNotNull(storedVCard);
        testHash = Hexify.hexify(crypto.getSHA1Hash(storedVCard.getPhoto()));
        assertEquals(avatar2Hash,testHash);
        
        // Change the avatar to an empty avatar
        
        vcardManager.requestVCard(user1.toBare());
        assertEquals(1,stanzaChannel.sentStanzas.size());
        request = (IQ) stanzaChannel.sentStanzas.lastElement();
        payload = request.getPayload(new VCard());
        assertNotNull(payload);
        stanzaChannel.sentStanzas.clear();
        
        VCard vcard3 = new VCard();
        reply = new IQ();
        reply.setTo(request.getFrom());
        reply.setFrom(request.getTo());
        reply.setID(request.getID());
        reply.addPayload(vcard3);
        reply.setType(IQ.Type.Result);
        stanzaChannel.onIQReceived.emit(reply);
        
        // Check that we changed the avatar successfully
        
        testHash = testling.getAvatarHash(user1.toBare());
        assertNotNull(testHash);
        assertEquals("",testHash);
        assertEquals(3,changes.size());
        assertEquals(user1.toBare(),changes.get(0));
        assertEquals(user1.toBare(),changes.get(1));
        assertEquals(user1.toBare(),changes.get(2));
        changes.clear();
        storedVCard = vCardStorage.getVCard(user1.toBare());
        assertNotNull(storedVCard);
        assertNull(storedVCard.getPhoto());
    }
    
    private CombinedAvatarProvider createProvider() {
        CombinedAvatarProvider result = new CombinedAvatarProvider();
        result.onAvatarChanged.connect(new Slot1<JID>() {
            
            @Override
            public void call(JID jid) {
                handleAvatarChanged(jid);
            }
            
        });
        return result;
    }
    
    private void handleAvatarChanged(JID jid) {
        changes.add(jid);
    }
    
    private static class DummyAvatarProvider extends AvatarProvider {

        @Override
        public String getAvatarHash(JID jid) {
            JID actualJID = useBare ? jid.toBare() : jid;
            if (avatars.containsKey(actualJID)) {
                return avatars.get(actualJID);
            }
            return null;
        }

        @Override
        public void delete() {
            // Empty Method
        }
        
        private boolean useBare = false;

        private final Map<JID,String> avatars = new HashMap<JID,String>();
        
    }
    
}