From 8803538bc29a3b68d3c69d900f41ddd1b383cec6 Mon Sep 17 00:00:00 2001 From: Tobias Markmann Date: Thu, 23 Feb 2017 18:04:36 +0100 Subject: Fix crash in Swift about dialog if build w/o auto update support Test-Information: Previously Swift crashed on QtAboutWidget.cpp:175 when build without any auto update support. Now it does not anymore. Tested on macOS 10.12.3 with Qt 5.5.1. Change-Id: Ia58ec3679d107cfd6b736e54e90a4167cf1adc47 diff --git a/Swift/QtUI/QtAboutWidget.cpp b/Swift/QtUI/QtAboutWidget.cpp index 3bc124a..a2aa65c 100644 --- a/Swift/QtUI/QtAboutWidget.cpp +++ b/Swift/QtUI/QtAboutWidget.cpp @@ -152,7 +152,7 @@ void QtAboutWidget::updateUpdateInfo() { updateProgressBar_->hide(); // Currently auto updating is only supported on macOS. #ifdef SWIFTEN_PLATFORM_MACOSX - if (settingsProvider_->getSetting(QtUISettingConstants::ENABLE_SOFTWARE_UPDATES)) { + if (autoUpdater_ && settingsProvider_->getSetting(QtUISettingConstants::ENABLE_SOFTWARE_UPDATES)) { if (!settingsProvider_->getSetting(QtUISettingConstants::SOFTWARE_UPDATE_CHANNEL).empty()) { QString updateFeedDescription; auto addUpdateFeedDialogLink = false; -- cgit v0.10.2-6-g49f6