Port many of Isode's local fixes upstream

Includes fixes to: Build with new Visual Studio and Boost Avoid error caused when Avahi is present but Qt is not Make declaration of XMPPRosterImpl::addContact consistent with implementation Includes enhancements to: Allow user-configurable mt.exe Allow splitting openssl paths Allow disabling gconf lookup Make idn support optional Allow disabling various library detections Remove use of non-Python2.4 features in sconscripts Test-Information: Builds Change-Id: Iee91ee80291a8bdf87cc169c915e4dad1cc1055b
author: Kevin Smith <git@kismith.co.uk> 2014-07-15 14:45:28 (GMT)
committer: Swift Review <review@swift.im> 2014-10-01 12:15:02 (GMT)
commit: a2296b00c88df201b0eb58e867aeb17a87e6332c (patch)
tree: 9fdebba1b5e9202ca669786a41dd94f080ba5807 /BuildTools
parent: a24d8c0e93d70312fc90d5fdf6214ade9a475e92 (diff)
download: swift-contrib-a2296b00c88df201b0eb58e867aeb17a87e6332c.zip
swift-contrib-a2296b00c88df201b0eb58e867aeb17a87e6332c.tar.bz2
4 files changed, 145 insertions, 60 deletions
diff --git a/BuildTools/SCons/SConscript.boot b/BuildTools/SCons/SConscript.boot
index 767c326..51be9ab 100644
--- a/BuildTools/SCons/SConscript.boot
+++ b/BuildTools/SCons/SConscript.boot
@@ -14,2 +14,5 @@ vars.Add('link', "Linker")
 vars.Add('linkflags', "Extra linker flags")
+vars.Add('ar', "Archiver (ar or lib)")
+if os.name == "nt":
+	vars.Add('mt', "manifest tool")
 vars.Add(BoolVariable("ccache", "Use CCache", "no"))
@@ -41,3 +44,6 @@ if os.name == "nt" :
 vars.Add(PackageVariable("openssl", "OpenSSL location", "yes"))
+vars.Add("openssl_libnames", "Comma-separated openssl library names to override defaults", None)
 vars.Add(BoolVariable("openssl_force_bundled", "Force use of the bundled OpenSSL", "no"))
+vars.Add("openssl_include", "Location of OpenSSL include files (if not under (openssl)/include)", None)
+vars.Add("openssl_libdir", "Location of OpenSSL library files (if not under (openssl)/lib)", None)
 vars.Add(PackageVariable("hunspell", "Hunspell location", False))
@@ -45,9 +51,19 @@ vars.Add(PathVariable("boost_includedir", "Boost headers location", None, PathVa
 vars.Add(PathVariable("boost_libdir", "Boost library location", None, PathVariable.PathAccept))
+vars.Add(BoolVariable("boost_bundled_enable", "Allow use of bundled Boost as last resort", "true"))
+vars.Add(PathVariable("zlib_includedir", "Zlib headers location", None, PathVariable.PathAccept))
+vars.Add(PathVariable("zlib_libdir", "Zlib library location", None, PathVariable.PathAccept))
+vars.Add(PathVariable("zlib_libfile", "Zlib library file (full path to file)", None, PathVariable.PathAccept))
+vars.Add(BoolVariable("zlib_bundled_enable", "Allow use of bundled Zlib as last resort", "true"))
+vars.Add(BoolVariable("try_gconf", "Try configuring for GConf?", "true"))
+vars.Add(BoolVariable("try_libxml", "Try configuring for libXML?", "true"))
+vars.Add(BoolVariable("try_expat", "Try configuring for expat?", "true"))
 vars.Add(PathVariable("expat_includedir", "Expat headers location", None, PathVariable.PathAccept))
 vars.Add(PathVariable("expat_libdir", "Expat library location", None, PathVariable.PathAccept))
-vars.Add("expat_libname", "Expat library name", "libexpat" if os.name == "nt" else "expat")
+vars.Add("expat_libname", "Expat library name", os.name == "nt" and "libexpat" or "expat")
 vars.Add(PackageVariable("icu", "ICU library location", "no"))
+vars.Add(BoolVariable("libidn_bundled_enable", "Allow use of bunded Expat", "true"))
+vars.Add(BoolVariable("try_libidn", "Try configuring for LibIDN?", "true"))
 vars.Add(PathVariable("libidn_includedir", "LibIDN headers location", None, PathVariable.PathAccept))
 vars.Add(PathVariable("libidn_libdir", "LibIDN library location", None, PathVariable.PathAccept))
-vars.Add("libidn_libname", "LibIDN library name", "libidn" if os.name == "nt" else "idn")
+vars.Add("libidn_libname", "LibIDN library name",  os.name == "nt" and "libidn" or "idn")
 vars.Add(PathVariable("libminiupnpc_includedir", "LibMiniUPNPC headers location", None, PathVariable.PathAccept))
@@ -60,3 +76,3 @@ vars.Add(PathVariable("sqlite_includedir", "SQLite headers location", None, Path
 vars.Add(PathVariable("sqlite_libdir", "SQLite library location", None, PathVariable.PathAccept))
-vars.Add("sqlite_libname", "SQLite library name", "libsqlite3" if os.name == "nt" else "sqlite3")
+vars.Add("sqlite_libname", "SQLite library name", os.name == "nt" and "libsqlite3" or "sqlite3")
 vars.Add("sqlite_force_bundled", "Force use of the bundled SQLite", None)
@@ -71,2 +87,3 @@ vars.Add("editline_libname", "Readline library name", "libedit" if os.name == "n
 
+vars.Add(BoolVariable("try_avahi", "Try configuring for avahi?", "true"))
 vars.Add(PathVariable("avahi_includedir", "Avahi headers location", None, PathVariable.PathAccept))
@@ -84,2 +101,4 @@ vars.Add(BoolVariable("unbound", "Build bundled ldns and unbound. Use them for D
 
+vars.Add(BoolVariable("install_git_hooks", "Install git hooks", "true"))
+
 ################################################################################
@@ -88,5 +107,4 @@ vars.Add(BoolVariable("unbound", "Build bundled ldns and unbound. Use them for D
 
-
 env_ENV = {
-  'PATH' : os.environ['PATH'], 
+  'PATH' : os.environ['PATH'],
   'LD_LIBRARY_PATH' : os.environ.get("LD_LIBRARY_PATH", ""),
@@ -94,6 +112,7 @@ env_ENV = {
 }
+
 if "MSVC_VERSION" in ARGUMENTS :
-  env = Environment(ENV = env_ENV, variables = vars, MSVC_VERSION = ARGUMENTS["MSVC_VERSION"])
+  env = Environment(ENV = env_ENV, variables = vars, MSVC_VERSION = ARGUMENTS["MSVC_VERSION"], platform = ARGUMENTS.get("PLATFORM", None))
 else :
-  env = Environment(ENV = env_ENV, variables = vars)
+  env = Environment(ENV = env_ENV, variables = vars, platform = ARGUMENTS.get("PLATFORM", None))
 
@@ -126,3 +145,3 @@ if env["PLATFORM"] == "win32" :
 	if "TMP" in os.environ.keys() :
-		env['ENV']['TMP'] = os.environ['TMP'] 
+		env['ENV']['TMP'] = os.environ['TMP']
 env.Tool("SLOCCount", toolpath = ["#/BuildTools/SCons/Tools"])
@@ -173,2 +192,5 @@ if "cxx" in env :
 	env["CXX"] = env["cxx"]
+if "ar" in env :
+	env["AR"] = env["ar"]
+
 if "link" in env :
@@ -215,9 +237,9 @@ if env.get("universal", 0) :
 	env.Append(CCFLAGS = [
-			"-isysroot", "/Developer/SDKs/MacOSX10.4u.sdk", 
-			"-arch", "i386", 
+			"-isysroot", "/Developer/SDKs/MacOSX10.4u.sdk",
+			"-arch", "i386",
 			"-arch", "ppc"])
 	env.Append(LINKFLAGS = [
-			"-mmacosx-version-min=10.4", 
-			"-isysroot", "/Developer/SDKs/MacOSX10.4u.sdk", 
-			"-arch", "i386", 
+			"-mmacosx-version-min=10.4",
+			"-isysroot", "/Developer/SDKs/MacOSX10.4u.sdk",
+			"-arch", "i386",
 			"-arch", "ppc"])
@@ -230,7 +252,7 @@ if env.get("mac105", 0) :
 	env.Append(CCFLAGS = [
-			"-isysroot", "/Developer/SDKs/MacOSX10.5.sdk", 
+			"-isysroot", "/Developer/SDKs/MacOSX10.5.sdk",
 			"-arch", "i386"])
 	env.Append(LINKFLAGS = [
-			"-mmacosx-version-min=10.5", 
-			"-isysroot", "/Developer/SDKs/MacOSX10.5.sdk", 
+			"-mmacosx-version-min=10.5",
+			"-isysroot", "/Developer/SDKs/MacOSX10.5.sdk",
 			"-arch", "i386"])
@@ -239,7 +261,7 @@ if env.get("mac106", 0) :
 	env.Append(CCFLAGS = [
-			"-isysroot", "/Developer/SDKs/MacOSX10.6.sdk", 
+			"-isysroot", "/Developer/SDKs/MacOSX10.6.sdk",
 			"-arch", "i386"])
 	env.Append(LINKFLAGS = [
-			"-mmacosx-version-min=10.6", 
-			"-isysroot", "/Developer/SDKs/MacOSX10.6.sdk", 
+			"-mmacosx-version-min=10.6",
+			"-isysroot", "/Developer/SDKs/MacOSX10.6.sdk",
 			"-arch", "i386"])
@@ -263,2 +285,9 @@ if env["PLATFORM"] == "win32" :
 	env.Append(CXXFLAGS = ["/wd4068"])
+elif env["PLATFORM"] == "hpux" :
+	# HP-UX gives a flood of minor warnings if this is enabled
+	#env.Append(CXXFLAGS = ["+w"])
+	pass
+elif env["PLATFORM"] == "sunos" :
+	#env.Append(CXXFLAGS = ["-z verbose"])
+	pass
 else :
@@ -300,4 +329,7 @@ if env["PLATFORM"] == "win32" :
 	if int(env["MSVS_VERSION"].split(".")[0]) < 10 :
-		env["LINKCOM"] = [env["LINKCOM"], 'mt.exe -nologo -manifest ${TARGET}.manifest -outputresource:$TARGET;1']
-		env["SHLINKCOM"] = [env["SHLINKCOM"], 'mt.exe -nologo -manifest ${TARGET}.manifest -outputresource:$TARGET;2']
+		mt = env.get('mt')
+		if not mt:
+			mt = 'mt.exe'
+		env["LINKCOM"] = [env["LINKCOM"], '%s  -nologo -manifest ${TARGET}.manifest -outputresource:$TARGET;1' % mt]
+		env["SHLINKCOM"] = [env["SHLINKCOM"], '%s  -nologo -manifest ${TARGET}.manifest -outputresource:$TARGET;2' % mt]
 
@@ -306,2 +338,9 @@ if env["PLATFORM"] == "darwin" and not env["target"] in ["iphone-device", "iphon
 
+# Required by boost headers on HP-UX
+if env["PLATFORM"] == "hpux" :
+	env.Append(CXXFLAGS = ["+hpxstd98", "-mt", "-AA"])
+	# FIXME: Need -AA for linking C++ but not C
+	#env.Append(LINKFLAGS = ["-AA"])
+
+
 # Testing
@@ -369,3 +408,3 @@ if target in ["iphone-device", "iphone-simulator", "xcode"] :
 	# Bit of a hack, because BOOST doesn't know the endianness for ARM
-	env.Append(CPPDEFINES = ["_LITTLE_ENDIAN"]) 
+	env.Append(CPPDEFINES = ["_LITTLE_ENDIAN"])
 
diff --git a/BuildTools/SCons/SConstruct b/BuildTools/SCons/SConstruct
index 25a1ad3..7bda9c1 100644
--- a/BuildTools/SCons/SConstruct
+++ b/BuildTools/SCons/SConstruct
@@ -13,3 +13,3 @@ def SConscript(*arguments, **keywords) :
 env.SConscript = SConscript
-  
+
 ################################################################################
@@ -113,4 +113,23 @@ if not conf.CheckCXX() or not conf.CheckCC() :
 env["HAVE_ZLIB"] = True
-if conf.CheckLib("z") :
-	env["ZLIB_FLAGS"] = {"LIBS": ["z"]}
+zlib_flags = {}
+zlib_okay = False
+if env.get("zlib_libdir", None) :
+	zlib_flags["LIBPATH"] = [env["zlib_libdir"]]
+	zlib_okay = True
+if env.get("zlib_includedir", None) :
+	zlib_flags["CPPPATH"] = [env["zlib_includedir"]]
+	zlib_okay = True
+if env.get("zlib_libfile", None) :
+	zlib_flags["LIBS"] = [File(env["zlib_libfile"])]
+	zlib_okay = True
+elif zlib_okay :
+	zlib_flags["LIBS"] = ["z"]
+if (not zlib_okay) and conf.CheckLib("z") :
+	zlib_flags["LIBS"] = ["z"]
+	zlib_okay = True
+if zlib_okay :
+	env["ZLIB_FLAGS"] = zlib_flags
+elif not env.get("zlib_bundled_enable", True) :
+	print "Error: Zlib not found and zlib_bundled_enable is false"
+	Exit(1)
 else :
@@ -134,5 +153,6 @@ if conf.CheckLib("c") :
 
-if conf.CheckLib("stdc++") :
-	env["PLATFORM_FLAGS"]["LIBS"] = env["PLATFORM_FLAGS"].get("LIBS", []) + ["stdc++"]
-
+# Even if you find stdc++ on HP-UX, it is the wrong one for aCC
+if env["PLATFORM"] != "hpux" :
+	if conf.CheckLib("stdc++", language='CXX') :
+		env["PLATFORM_FLAGS"]["LIBS"] = env["PLATFORM_FLAGS"].get("LIBS", []) + ["stdc++"]
 conf.Finish()
@@ -145,3 +165,3 @@ if env.get("boost_libdir", None) :
 if env.get("boost_includedir", None) :
-	if env["PLATFORM"] == "win32" :
+	if env["PLATFORM"] == "win32" or env["PLATFORM"] == "hpux" or env["PLATFORM"] == "sunos" :
 		boost_flags["CPPPATH"] = [env["boost_includedir"]]
@@ -153,3 +173,3 @@ boost_conf_env.MergeFlags(boost_flags)
 conf = Configure(boost_conf_env)
-boostLibs = [("signals", None), ("thread", None), ("regex", None), ("program_options", None), ("filesystem", None), ("serialization", "archive/text_oarchive.hpp"), ("system", "system/system_error.hpp"), ("date_time", "date_time/date.hpp")]
+boostLibs = [("signals", None), ("system", "system/system_error.hpp"), ("thread", None), ("regex", None), ("program_options", None), ("filesystem", None), ("serialization", "archive/text_oarchive.hpp"), ("date_time", "date_time/date.hpp")]
 allLibsPresent = True
@@ -166,5 +186,5 @@ for (lib, header) in boostLibs :
 		libName = "boost_" + lib
-		if not conf.CheckLib(libName) :
+		if not conf.CheckLib(libName, language='CXX') :
 			libName += "-mt"
-			if not conf.CheckLib(libName) :
+			if not conf.CheckLib(libName, language='CXX') :
 				allLibsPresent = False
@@ -179,3 +199,6 @@ if allLibsPresent :
 		env["BOOST_BUNDLED_UUID_ONLY"] = True
-	env["BOOST_FLAGS"]["CPPDEFINES"] = ["BOOST_SIGNALS_NO_DEPRECATION_WARNING"]
+		env["BOOST_FLAGS"]["CPPDEFINES"] = ["BOOST_SIGNALS_NO_DEPRECATION_WARNING"]
+elif not env.get("boost_bundled_enable", True) :
+	print "Error: Boost not found and boost_bundled_enable is false"
+	Exit(1)
 else :
@@ -202,3 +225,3 @@ if env["PLATFORM"] != "win32" and env["PLATFORM"] != "darwin" :
 env["HAVE_GCONF"] = 0
-if env["PLATFORM"] != "win32" and env["PLATFORM"] != "darwin" :
+if env.get("try_gconf", True) and env["PLATFORM"] != "win32" and env["PLATFORM"] != "darwin" :
 	gconf_env = conf_env.Clone()
@@ -263,3 +286,3 @@ if env["PLATFORM"] == "win32" :
 conf = Configure(conf_env, custom_tests = {"CheckVersion": CheckVersion})
-if conf.CheckCHeader("libxml/parser.h") and conf.CheckLib("xml2") :
+if env.get("try_libxml", True) and conf.CheckCHeader("libxml/parser.h") and conf.CheckLib("xml2") :
 #and conf.CheckVersion("LibXML", "2.6.23", "LIBXML_VERSION", "libxml/xmlversion.h", 20623) :
@@ -269,3 +292,3 @@ conf.Finish()
 
-if not env.get("HAVE_LIBXML", 0) :
+if env.get("try_libxml", True) and not env.get("HAVE_LIBXML", 0) :
 	libxml_env = conf_env.Clone()
@@ -280,3 +303,3 @@ if not env.get("HAVE_LIBXML", 0) :
 # Expat
-if not env.get("HAVE_LIBXML",0) :
+if env.get("try_expat", True) and not env.get("HAVE_LIBXML",0) :
 	expat_conf_env = conf_env.Clone()
@@ -310,3 +333,5 @@ icu_env = conf_env.Clone()
 use_icu = bool(env["icu"])
-icu_prefix = env["icu"] if isinstance(env["icu"], str) else ""
+icu_prefix = ""
+if isinstance(env["icu"], str) :
+        icu_prefix = env["icu"]
 icu_flags = {}
@@ -333,3 +358,3 @@ libidn_conf_env.MergeFlags(libidn_flags)
 conf = Configure(libidn_conf_env)
-if not env.get("HAVE_ICU") and conf.CheckCHeader("idna.h") and conf.CheckLib(env["libidn_libname"]) :
+if env.get("try_libidn", True) and not env.get("HAVE_ICU") and conf.CheckCHeader("idna.h") and conf.CheckLib(env["libidn_libname"]) :
 	env["HAVE_LIBIDN"] = 1
@@ -341,4 +366,8 @@ conf.Finish()
 if not env.get("HAVE_ICU", False) and not env.get("HAVE_LIBIDN", False) :
-	env["HAVE_LIBIDN"] = 1
-	env["LIBIDN_BUNDLED"] = 1
+	if env.get("libidn_bundled_enable", True)  :
+		env["HAVE_LIBIDN"] = 1
+		env["LIBIDN_BUNDLED"] = 1
+	else :
+		print "Error: ICU and LIBIDN not found, and libidn_bundled_enable is false"
+		Exit(1)
 
@@ -461,3 +490,3 @@ avahi_conf_env.MergeFlags(avahi_flags)
 conf = Configure(avahi_conf_env)
-if conf.CheckCHeader("avahi-client/client.h") and conf.CheckLib("avahi-client") and conf.CheckLib("avahi-common") :
+if env.get("try_avahi", True) and conf.CheckCHeader("avahi-client/client.h") and conf.CheckLib("avahi-client") and conf.CheckLib("avahi-common") :
 	env["HAVE_AVAHI"] = True
@@ -478,7 +507,17 @@ else :
 	use_openssl = bool(env["openssl"])
-	openssl_prefix = env["openssl"] if isinstance(env["openssl"], str) else ""
+	openssl_prefix = ""
+	if isinstance(env["openssl"], str) :
+		openssl_prefix = env["openssl"]
 	openssl_flags = {}
 	if openssl_prefix :
-		openssl_flags = { "CPPPATH": [os.path.join(openssl_prefix, "include")] }
-		if env["PLATFORM"] == "win32" : 
+		openssl_include = env.get("openssl_include", None)
+		openssl_libdir = env.get("openssl_libdir", None)
+		if openssl_include:
+			openssl_flags = {"CPPPATH":[openssl_include]}
+		else:
+			openssl_flags = { "CPPPATH": [os.path.join(openssl_prefix, "include")] }
+		if openssl_libdir:
+			openssl_flags["LIBPATH"] = [openssl_libdir]
+			env["OPENSSL_DIR"] = openssl_prefix
+		elif env["PLATFORM"] == "win32" :
 			openssl_flags["LIBPATH"] = [os.path.join(openssl_prefix, "lib", "VC")]
@@ -493,3 +532,6 @@ else :
 		env["OPENSSL_FLAGS"] = openssl_flags
-		if env["PLATFORM"] == "win32" : 
+		openssl_libnames = env.get("openssl_libnames", None)
+		if openssl_libnames:
+			env["OPENSSL_FLAGS"]["LIBS"] = openssl_libnames.split(',')
+		elif env["PLATFORM"] == "win32" :
 			env["OPENSSL_FLAGS"]["LIBS"] = ["libeay32MD", "ssleay32MD"]
@@ -502,3 +544,3 @@ else :
 		env["OPENSSL_FLAGS"] = {}
-		if env["PLATFORM"] == "win32" : 
+		if env["PLATFORM"] == "win32" :
 			env["HAVE_SCHANNEL"] = True
@@ -532,3 +574,3 @@ elif env.get("bonjour", False) :
 	bonjour_flags = {}
-	if env.get("bonjour") != True :		
+	if env.get("bonjour") != True :
 		bonjour_prefix = env["bonjour"]
@@ -574,3 +616,3 @@ try:
 	if env.Dir("#/.git").exists() :
-		if not env.GetOption("clean") :
+		if not env.GetOption("clean") and env.get("install_git_hooks", True) :
 			env.Install("#/.git/hooks", Glob("#/BuildTools/Git/Hooks/*"))
@@ -668,4 +710,4 @@ print "  XML Parsers: " + ' '.join(parsers)
 
-print "  TLS Support: " + ("OpenSSL" if env.get("HAVE_OPENSSL",0) else ("Schannel" if env.get("HAVE_SCHANNEL", 0) else "Disabled"))
-print "  DNSSD Support: " + ("Bonjour" if env.get("HAVE_BONJOUR") else ("Avahi" if env.get("HAVE_AVAHI") else "Disabled"))
+print "  TLS Support: " + (env.get("HAVE_OPENSSL",0) and "OpenSSL" or env.get("HAVE_SCHANNEL", 0) and "Schannel" or "Disabled")
+print "  DNSSD Support: " + (env.get("HAVE_BONJOUR") and "Bonjour" or (env.get("HAVE_AVAHI") and "Avahi" or "Disabled"))
 print
diff --git a/BuildTools/SCons/Tools/Test.py b/BuildTools/SCons/Tools/Test.py
index 95fcce9..7e4609d 100644
--- a/BuildTools/SCons/Tools/Test.py
+++ b/BuildTools/SCons/Tools/Test.py
@@ -5,3 +5,6 @@ def generate(env) :
 		if env["TEST_TYPE"] == "all" or env["TEST_TYPE"] == type :
-			cmd = target[0].abspath if SCons.Util.is_List(target) else target.abspath
+			if SCons.Util.is_List(target) :
+				cmd = target[0].abspath
+			else :
+				cmd = target.abspath
 			params = ""
@@ -11,3 +14,3 @@ def generate(env) :
 				params = " --xml > " + os.path.join(target[0].dir.path, "checker-report.xml")
-	
+
 			ignore_prefix = ""
@@ -35,6 +38,6 @@ def generate(env) :
 					["adb shell mount -o rw,remount /system",
-					"adb push " + cmd + " /system/bin/" + exec_name, 
+					"adb push " + cmd + " /system/bin/" + exec_name,
 					"adb shell SWIFT_CLIENTTEST_JID=\"" + os.getenv("SWIFT_CLIENTTEST_JID") + "\" SWIFT_CLIENTTEST_PASS=\"" + os.getenv("SWIFT_CLIENTTEST_PASS") + "\" " + env.get("TEST_RUNNER", "") + "/system/bin/" + exec_name], cmdstr = "$TESTCOMSTR"))
 			else :
-				test_env.Command("**dummy**", target, 
+				test_env.Command("**dummy**", target,
 					SCons.Action.Action(ignore_prefix + env.get("TEST_RUNNER", "") + cmd + " " + params, cmdstr = "$TESTCOMSTR"))
diff --git a/BuildTools/SCons/Version.py b/BuildTools/SCons/Version.py
index f98a8b9..2f3b5a5 100644
--- a/BuildTools/SCons/Version.py
+++ b/BuildTools/SCons/Version.py
@@ -12,3 +12,3 @@ def getGitBuildVersion(root, project) :
   return None
-    
+
 def git(cmd, root) :
@@ -21,3 +21,5 @@ def git(cmd, root) :
   p.stdin.close()
-  return gitVersion if p.wait() == 0 else None
+  if p.wait() == 0 :
+    return gitVersion
+  return None
 
@@ -31,3 +33,3 @@ def getBuildVersion(root, project) :
 
-  gitVersion = getGitBuildVersion(root, project) 
+  gitVersion = getGitBuildVersion(root, project)
   if gitVersion :
@@ -61,3 +63,3 @@ def convertToWindowsVersion(version) :
     if len(build_string) > 0 :
-      build_match = re.match("^-dev(\d+)", build_string) 
+      build_match = re.match("^-dev(\d+)", build_string)
       if build_match :
@@ -66,2 +68 @@ def convertToWindowsVersion(version) :
   return (major, minor, patch)
-
author	Kevin Smith <git@kismith.co.uk>	2014-07-15 14:45:28 (GMT)
committer	Swift Review <review@swift.im>	2014-10-01 12:15:02 (GMT)
commit	a2296b00c88df201b0eb58e867aeb17a87e6332c (patch)
tree	9fdebba1b5e9202ca669786a41dd94f080ba5807 /BuildTools
parent	a24d8c0e93d70312fc90d5fdf6214ade9a475e92 (diff)
download	swift-contrib-a2296b00c88df201b0eb58e867aeb17a87e6332c.zip swift-contrib-a2296b00c88df201b0eb58e867aeb17a87e6332c.tar.bz2