Update LuaElementConvertor interface to work with Element instead of Payload.

Change-Id: I4f8b69b1a13fff21c605011f45763e01f03259cf
author: Richard Maudsley <richard.maudsley@isode.com> 2014-04-29 08:57:17 (GMT)
committer: Richard Maudsley <richard.maudsley@isode.com> 2014-04-30 12:35:31 (GMT)
commit: 481f33cdee8a907c98f1b87dd1b65418b096c4f6 (patch)
tree: 7a53d23cc300f2aeecd5e3ea73b86bc09f318bce /Sluift/ElementConvertors
parent: c4b64106e7b9493c7b28cc653797457d5f7fbdda (diff)
download: swift-contrib-481f33cdee8a907c98f1b87dd1b65418b096c4f6.zip
swift-contrib-481f33cdee8a907c98f1b87dd1b65418b096c4f6.tar.bz2
8 files changed, 24 insertions, 15 deletions
diff --git a/Sluift/ElementConvertors/DOMElementConvertor.cpp b/Sluift/ElementConvertors/DOMElementConvertor.cpp
index bb4256d..fb1f658 100644
--- a/Sluift/ElementConvertors/DOMElementConvertor.cpp
+++ b/Sluift/ElementConvertors/DOMElementConvertor.cpp
@@ -128,67 +128,72 @@ namespace {
 
 					if (!attributeName.empty()) {
 						element.setAttribute(attributeName, attributeValue);
 					}
 				}
 				lua_pop(L, 1); // value
 			}
 		}
 		lua_pop(L, 1); // children
 
 		lua_getfield(L, -1, "children");
 		if (lua_istable(L, -1)) {
 			int index = Lua::absoluteOffset(L, -1);
 			for (lua_pushnil(L); lua_next(L, index) != 0; ) {
 				if (lua_isstring(L, -1)) {
 					element.addNode(boost::make_shared<XMLTextNode>(lua_tostring(L, -1)));
 				}
 				else if (lua_istable(L, -1)) {
 					element.addNode(boost::make_shared<XMLRawTextNode>(serializeElement(L)));
 				}
 				lua_pop(L, 1); // value
 			}
 		}
 		lua_pop(L, 1); // children
 
 		return element.serialize();
 	}
 }
 
 DOMElementConvertor::DOMElementConvertor() {
 }
 
 DOMElementConvertor::~DOMElementConvertor() {
 }
 
-boost::shared_ptr<Payload> DOMElementConvertor::convertFromLua(lua_State* L, int index, const std::string& type) {
+boost::shared_ptr<Element> DOMElementConvertor::convertFromLua(lua_State* L, int index, const std::string& type) {
 	if (!lua_istable(L, index) || type != "dom") {
 		return boost::shared_ptr<Payload>();
 	}
 	return boost::make_shared<RawXMLPayload>(serializeElement(L).c_str());
 }
 
 boost::optional<std::string> DOMElementConvertor::convertToLua(
-		lua_State* L, boost::shared_ptr<Payload> payload) {
+		lua_State* L, boost::shared_ptr<Element> element) {
 	// Serialize payload to XML
+	boost::shared_ptr<Payload> payload = boost::dynamic_pointer_cast<Payload>(element);
+	if (!payload) {
+		return boost::optional<std::string>();
+	}
+
 	PayloadSerializer* serializer = serializers.getPayloadSerializer(payload);
 	assert(serializer);
 	std::string serializedPayload = serializer->serialize(payload);
 
 	lua_newtable(L);
 
 	// Parse the payload again
 	ParserClient parserClient(L);
 	boost::shared_ptr<XMLParser> parser(parsers.createXMLParser(&parserClient));
 	bool result = parser->parse(serializedPayload);
 	assert(result);
 
 	// There can only be one element, so stripping the list
 	lua_pushnil(L);
 	lua_next(L, -2);
 	Lua::registerTableToString(L, -1);
 
 	lua_replace(L, -3);
 	lua_settop(L, -2);
 
 	return std::string("dom");
 }
diff --git a/Sluift/ElementConvertors/DOMElementConvertor.h b/Sluift/ElementConvertors/DOMElementConvertor.h
index 94d0669..fdd7304 100644
--- a/Sluift/ElementConvertors/DOMElementConvertor.h
+++ b/Sluift/ElementConvertors/DOMElementConvertor.h
@@ -1,28 +1,28 @@
 /*
  * Copyright (c) 2013 Remko Tronçon
  * Licensed under the GNU General Public License.
  * See the COPYING file for more information.
  */
 
 #pragma once
 
 #include <Swiften/Base/Override.h>
 
 #include <Sluift/LuaElementConvertor.h>
 #include <Swiften/Serializer/PayloadSerializers/FullPayloadSerializerCollection.h>
 #include <Swiften/Parser/PlatformXMLParserFactory.h>
 
 namespace Swift {
 	class DOMElementConvertor : public LuaElementConvertor {
 		public:
 			DOMElementConvertor();
 			virtual ~DOMElementConvertor();
 
-			virtual boost::shared_ptr<Payload> convertFromLua(lua_State*, int index, const std::string& type) SWIFTEN_OVERRIDE;
-			virtual boost::optional<std::string> convertToLua(lua_State*, boost::shared_ptr<Payload>) SWIFTEN_OVERRIDE;
+			virtual boost::shared_ptr<Element> convertFromLua(lua_State*, int index, const std::string& type) SWIFTEN_OVERRIDE;
+			virtual boost::optional<std::string> convertToLua(lua_State*, boost::shared_ptr<Element>) SWIFTEN_OVERRIDE;
 
 		private:
 			PlatformXMLParserFactory parsers;
 			FullPayloadSerializerCollection serializers;
 	};
 }
diff --git a/Sluift/ElementConvertors/DefaultElementConvertor.cpp b/Sluift/ElementConvertors/DefaultElementConvertor.cpp
index 62c799b..cc326df 100644
--- a/Sluift/ElementConvertors/DefaultElementConvertor.cpp
+++ b/Sluift/ElementConvertors/DefaultElementConvertor.cpp
@@ -1,30 +1,30 @@
 /*
  * Copyright (c) 2013 Remko Tronçon
  * Licensed under the GNU General Public License.
  * See the COPYING file for more information.
  */
 
 #include <Sluift/ElementConvertors/DefaultElementConvertor.h>
 
 #include <iostream>
 #include <typeinfo>
 #include <string>
 
 using namespace Swift;
 
 DefaultElementConvertor::DefaultElementConvertor() {
 }
 
 DefaultElementConvertor::~DefaultElementConvertor() {
 }
 
-boost::shared_ptr<Payload> DefaultElementConvertor::convertFromLua(lua_State*, int, const std::string& type) {
+boost::shared_ptr<Element> DefaultElementConvertor::convertFromLua(lua_State*, int, const std::string& type) {
 	std::cerr << "Warning: Unable to convert type '" << type << "'" << std::endl;
-	return boost::shared_ptr<Payload>();
+	return boost::shared_ptr<Element>();
 }
 
-boost::optional<std::string> DefaultElementConvertor::convertToLua(lua_State*, boost::shared_ptr<Payload>) {
+boost::optional<std::string> DefaultElementConvertor::convertToLua(lua_State*, boost::shared_ptr<Element>) {
 	// Should have been handled by the raw XML convertor
 	assert(false);
 	return NO_RESULT;
 }
diff --git a/Sluift/ElementConvertors/DefaultElementConvertor.h b/Sluift/ElementConvertors/DefaultElementConvertor.h
index ad8fe75..5a2975b 100644
--- a/Sluift/ElementConvertors/DefaultElementConvertor.h
+++ b/Sluift/ElementConvertors/DefaultElementConvertor.h
@@ -1,22 +1,22 @@
 /*
  * Copyright (c) 2013 Remko Tronçon
  * Licensed under the GNU General Public License.
  * See the COPYING file for more information.
  */
 
 #pragma once
 
 #include <Swiften/Base/Override.h>
 
 #include <Sluift/LuaElementConvertor.h>
 
 namespace Swift {
 	class DefaultElementConvertor : public LuaElementConvertor {
 		public:
 			DefaultElementConvertor();
 			virtual ~DefaultElementConvertor();
 
-			virtual boost::shared_ptr<Payload> convertFromLua(lua_State*, int index, const std::string& type) SWIFTEN_OVERRIDE;
-			virtual boost::optional<std::string> convertToLua(lua_State*, boost::shared_ptr<Payload>) SWIFTEN_OVERRIDE;
+			virtual boost::shared_ptr<Element> convertFromLua(lua_State*, int index, const std::string& type) SWIFTEN_OVERRIDE;
+			virtual boost::optional<std::string> convertToLua(lua_State*, boost::shared_ptr<Element>) SWIFTEN_OVERRIDE;
 	};
 }
diff --git a/Sluift/ElementConvertors/PubSubEventItemConvertor.cpp b/Sluift/ElementConvertors/PubSubEventItemConvertor.cpp
index 4b150c4..9905df3 100644
--- a/Sluift/ElementConvertors/PubSubEventItemConvertor.cpp
+++ b/Sluift/ElementConvertors/PubSubEventItemConvertor.cpp
@@ -12,71 +12,71 @@
 
 #include <Sluift/LuaElementConvertors.h>
 #include <Swiften/Base/foreach.h>
 
 #pragma clang diagnostic ignored "-Wunused-private-field"
 
 using namespace Swift;
 
 PubSubEventItemConvertor::PubSubEventItemConvertor(LuaElementConvertors* convertors) : 
 		GenericLuaElementConvertor<PubSubEventItem>("pubsub_event_item"),
 		convertors(convertors) {
 }
 
 PubSubEventItemConvertor::~PubSubEventItemConvertor() {
 }
 
 boost::shared_ptr<PubSubEventItem> PubSubEventItemConvertor::doConvertFromLua(lua_State* L) {
 	boost::shared_ptr<PubSubEventItem> result = boost::make_shared<PubSubEventItem>();
 	lua_getfield(L, -1, "node");
 	if (lua_isstring(L, -1)) {
 		result->setNode(std::string(lua_tostring(L, -1)));
 	}
 	lua_pop(L, 1);
 	lua_getfield(L, -1, "publisher");
 	if (lua_isstring(L, -1)) {
 		result->setPublisher(std::string(lua_tostring(L, -1)));
 	}
 	lua_pop(L, 1);
 	lua_getfield(L, -1, "data");
 	if (lua_type(L, -1) == LUA_TTABLE) {
 		std::vector< boost::shared_ptr<Payload> > items;
 		for(size_t i = 0; i < lua_objlen(L, -1); ++i) {
 			lua_pushnumber(L, i + 1);
 			lua_gettable(L, -2);
 			if (!lua_isnil(L, -1)) {
-				if (boost::shared_ptr<Payload> payload = convertors->convertFromLua(L, -1)) {
+				if (boost::shared_ptr<Payload> payload = boost::dynamic_pointer_cast<Payload>(convertors->convertFromLua(L, -1))) {
 					items.push_back(payload);
 				}
 			}
 			lua_pop(L, 1);
 		}
 
 		result->setData(items);
 	}
 	lua_pop(L, 1);
 	lua_getfield(L, -1, "id");
 	if (lua_isstring(L, -1)) {
 		result->setID(std::string(lua_tostring(L, -1)));
 	}
 	lua_pop(L, 1);
 	return result;
 }
 
 void PubSubEventItemConvertor::doConvertToLua(lua_State* L, boost::shared_ptr<PubSubEventItem> payload) {
 	lua_createtable(L, 0, 0);
 	if (payload->getNode()) {
 		lua_pushstring(L, (*payload->getNode()).c_str());
 		lua_setfield(L, -2, "node");
 	}
 	if (payload->getPublisher()) {
 		lua_pushstring(L, (*payload->getPublisher()).c_str());
 		lua_setfield(L, -2, "publisher");
 	}
 	if (!payload->getData().empty()) {
 		lua_createtable(L, boost::numeric_cast<int>(payload->getData().size()), 0);
 		{
 			int i = 0;
 			foreach(boost::shared_ptr<Payload> item, payload->getData()) {
 				if (convertors->convertToLua(L, item) > 0) {
 					lua_rawseti(L, -2, boost::numeric_cast<int>(i+1));
 					++i;
diff --git a/Sluift/ElementConvertors/PubSubItemConvertor.cpp b/Sluift/ElementConvertors/PubSubItemConvertor.cpp
index e9ed753..dcaa600 100644
--- a/Sluift/ElementConvertors/PubSubItemConvertor.cpp
+++ b/Sluift/ElementConvertors/PubSubItemConvertor.cpp
@@ -2,71 +2,71 @@
  * Copyright (c) 2013 Remko Tronçon
  * Licensed under the GNU General Public License v3.
  * See Documentation/Licenses/GPLv3.txt for more information.
  */
 
 #include <Sluift/ElementConvertors/PubSubItemConvertor.h>
 
 #include <lua.hpp>
 #include <boost/smart_ptr/make_shared.hpp>
 #include <boost/numeric/conversion/cast.hpp>
 
 #include <Sluift/LuaElementConvertors.h>
 #include <Swiften/Base/foreach.h>
 
 #pragma clang diagnostic ignored "-Wunused-private-field"
 
 using namespace Swift;
 
 PubSubItemConvertor::PubSubItemConvertor(LuaElementConvertors* convertors) : 
 		GenericLuaElementConvertor<PubSubItem>("pubsub_item"),
 		convertors(convertors) {
 }
 
 PubSubItemConvertor::~PubSubItemConvertor() {
 }
 
 boost::shared_ptr<PubSubItem> PubSubItemConvertor::doConvertFromLua(lua_State* L) {
 	boost::shared_ptr<PubSubItem> result = boost::make_shared<PubSubItem>();
 	lua_getfield(L, -1, "data");
 	if (lua_type(L, -1) == LUA_TTABLE) {
 		std::vector< boost::shared_ptr<Payload> > items;
 		for(size_t i = 0; i < lua_objlen(L, -1); ++i) {
 			lua_pushnumber(L, i + 1);
 			lua_gettable(L, -2);
 			if (!lua_isnil(L, -1)) {
-				if (boost::shared_ptr<Payload> payload = convertors->convertFromLua(L, -1)) {
+				if (boost::shared_ptr<Payload> payload = boost::dynamic_pointer_cast<Payload>(convertors->convertFromLua(L, -1))) {
 					items.push_back(payload);
 				}
 			}
 			lua_pop(L, 1);
 		}
 
 		result->setData(items);
 	}
 	lua_pop(L, 1);
 	lua_getfield(L, -1, "id");
 	if (lua_isstring(L, -1)) {
 		result->setID(std::string(lua_tostring(L, -1)));
 	}
 	lua_pop(L, 1);
 	return result;
 }
 
 void PubSubItemConvertor::doConvertToLua(lua_State* L, boost::shared_ptr<PubSubItem> payload) {
 	lua_createtable(L, 0, 0);
 	if (!payload->getData().empty()) {
 		lua_createtable(L, boost::numeric_cast<int>(payload->getData().size()), 0);
 		{
 			int i = 0;
 			foreach(boost::shared_ptr<Payload> item, payload->getData()) {
 				if (convertors->convertToLua(L, item) > 0) {
 					lua_rawseti(L, -2, boost::numeric_cast<int>(i+1));
 					++i;
 				}
 			}
 		}
 		lua_setfield(L, -2, "data");
 	}
 	lua_pushstring(L, payload->getID().c_str());
 	lua_setfield(L, -2, "id");
 }
diff --git a/Sluift/ElementConvertors/RawXMLElementConvertor.cpp b/Sluift/ElementConvertors/RawXMLElementConvertor.cpp
index 35a53ca..e4cfe05 100644
--- a/Sluift/ElementConvertors/RawXMLElementConvertor.cpp
+++ b/Sluift/ElementConvertors/RawXMLElementConvertor.cpp
@@ -1,37 +1,41 @@
 /*
  * Copyright (c) 2013 Remko Tronçon
  * Licensed under the GNU General Public License.
  * See the COPYING file for more information.
  */
 
 #include <Sluift/ElementConvertors/RawXMLElementConvertor.h>
 
 #include <iostream>
 #include <boost/smart_ptr/make_shared.hpp>
 #include <lua.hpp>
 
 #include <Swiften/Elements/RawXMLPayload.h>
 #include <Swiften/Serializer/PayloadSerializer.h>
 #include <Sluift/Lua/Check.h>
 
 using namespace Swift;
 
 RawXMLElementConvertor::RawXMLElementConvertor() {
 }
 
 RawXMLElementConvertor::~RawXMLElementConvertor() {
 }
 
-boost::shared_ptr<Payload> RawXMLElementConvertor::convertFromLua(lua_State* L, int index, const std::string& type) {
+boost::shared_ptr<Element> RawXMLElementConvertor::convertFromLua(lua_State* L, int index, const std::string& type) {
 	if (type == "xml") {
 		return boost::make_shared<RawXMLPayload>(std::string(Lua::checkString(L, index)));
 	}
 	return boost::shared_ptr<Payload>();
 }
 
-boost::optional<std::string> RawXMLElementConvertor::convertToLua(lua_State* L, boost::shared_ptr<Payload> payload) {
+boost::optional<std::string> RawXMLElementConvertor::convertToLua(lua_State* L, boost::shared_ptr<Element> element) {
+	boost::shared_ptr<Payload> payload = boost::dynamic_pointer_cast<Payload>(element);
+	if (!payload) {
+		return boost::optional<std::string>();
+	}
 	PayloadSerializer* serializer = serializers.getPayloadSerializer(payload);
 	assert(serializer);
 	lua_pushstring(L, serializer->serialize(payload).c_str());
 	return std::string("xml");
 }
diff --git a/Sluift/ElementConvertors/RawXMLElementConvertor.h b/Sluift/ElementConvertors/RawXMLElementConvertor.h
index 6087ba0..2ee76c5 100644
--- a/Sluift/ElementConvertors/RawXMLElementConvertor.h
+++ b/Sluift/ElementConvertors/RawXMLElementConvertor.h
@@ -1,26 +1,26 @@
 /*
  * Copyright (c) 2013 Remko Tronçon
  * Licensed under the GNU General Public License.
  * See the COPYING file for more information.
  */
 
 #pragma once
 
 #include <Swiften/Base/Override.h>
 
 #include <Sluift/LuaElementConvertor.h>
 #include <Swiften/Serializer/PayloadSerializers/FullPayloadSerializerCollection.h>
 
 namespace Swift {
 	class RawXMLElementConvertor : public LuaElementConvertor {
 		public:
 			RawXMLElementConvertor();
 			virtual ~RawXMLElementConvertor();
 
-			virtual boost::shared_ptr<Payload> convertFromLua(lua_State*, int index, const std::string& type) SWIFTEN_OVERRIDE;
-			virtual boost::optional<std::string> convertToLua(lua_State*, boost::shared_ptr<Payload>) SWIFTEN_OVERRIDE;
+			virtual boost::shared_ptr<Element> convertFromLua(lua_State*, int index, const std::string& type) SWIFTEN_OVERRIDE;
+			virtual boost::optional<std::string> convertToLua(lua_State*, boost::shared_ptr<Element>) SWIFTEN_OVERRIDE;
 
 		private:
 			FullPayloadSerializerCollection serializers;
 	};
 }
author	Richard Maudsley <richard.maudsley@isode.com>	2014-04-29 08:57:17 (GMT)
committer	Richard Maudsley <richard.maudsley@isode.com>	2014-04-30 12:35:31 (GMT)
commit	481f33cdee8a907c98f1b87dd1b65418b096c4f6 (patch)
tree	7a53d23cc300f2aeecd5e3ea73b86bc09f318bce /Sluift/ElementConvertors
parent	c4b64106e7b9493c7b28cc653797457d5f7fbdda (diff)
download	swift-contrib-481f33cdee8a907c98f1b87dd1b65418b096c4f6.zip swift-contrib-481f33cdee8a907c98f1b87dd1b65418b096c4f6.tar.bz2