Swiftdiff options
| author | Edwin Mons <edwin.mons@isode.com> | 2018-10-29 16:28:14 (GMT) |
|---|---|---|
| committer | Edwin Mons <edwin.mons@isode.com> | 2018-11-08 11:31:20 (GMT) |
| commit | cf3d517763a3d74a2ec9fd6f7bdee8cbaee3550f (patch) | |
| tree | 69e11e13ff2e5127d2cbfcc164be761cf104a1b2 /Swiften/Network/DummyConnectionServerFactory.h | |
| parent | 5ce9e19ef0744f530a797c30a82e9723eb7ea306 (diff) | |
| download | swift-cf3d517763a3d74a2ec9fd6f7bdee8cbaee3550f.zip swift-cf3d517763a3d74a2ec9fd6f7bdee8cbaee3550f.tar.bz2 | |
Consistently use unsigned short for network ports
Network ports are now consistently stored as unsigned shorts, apart from
the options and user interface, where -1 is still used to denote the use
of default ports.
Test-Information:
Unit tests pass on macOS 10.13 and Debian 9
On macOS: tested the UI with various proxy and manual ports, behaviour
as expected.
Change-Id: I7a65f40083022887aa30ed7b21eadc56d0c52be1
Diffstat (limited to 'Swiften/Network/DummyConnectionServerFactory.h')
| -rw-r--r-- | Swiften/Network/DummyConnectionServerFactory.h | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/Swiften/Network/DummyConnectionServerFactory.h b/Swiften/Network/DummyConnectionServerFactory.h index 822f95f..4b25118 100644 --- a/Swiften/Network/DummyConnectionServerFactory.h +++ b/Swiften/Network/DummyConnectionServerFactory.h | |||
| @@ -1,5 +1,5 @@ | |||
| 1 | /* | 1 | /* |
| 2 | * Copyright (c) 2014-2016 Isode Limited. | 2 | * Copyright (c) 2014-2018 Isode Limited. |
| 3 | * All rights reserved. | 3 | * All rights reserved. |
| 4 | * See the COPYING file for more information. | 4 | * See the COPYING file for more information. |
| 5 | */ | 5 | */ |
| @@ -20,11 +20,11 @@ public: | |||
| 20 | DummyConnectionServerFactory(EventLoop* eventLoop) : eventLoop(eventLoop) {} | 20 | DummyConnectionServerFactory(EventLoop* eventLoop) : eventLoop(eventLoop) {} |
| 21 | virtual ~DummyConnectionServerFactory() {} | 21 | virtual ~DummyConnectionServerFactory() {} |
| 22 | 22 | ||
| 23 | virtual std::shared_ptr<ConnectionServer> createConnectionServer(int port) { | 23 | virtual std::shared_ptr<ConnectionServer> createConnectionServer(unsigned short port) { |
| 24 | return std::make_shared<DummyConnectionServer>(eventLoop, port); | 24 | return std::make_shared<DummyConnectionServer>(eventLoop, port); |
| 25 | } | 25 | } |
| 26 | 26 | ||
| 27 | virtual std::shared_ptr<ConnectionServer> createConnectionServer(const Swift::HostAddress& hostAddress, int port) { | 27 | virtual std::shared_ptr<ConnectionServer> createConnectionServer(const Swift::HostAddress& hostAddress, unsigned short port) { |
| 28 | return std::make_shared<DummyConnectionServer>(eventLoop, hostAddress, port); | 28 | return std::make_shared<DummyConnectionServer>(eventLoop, hostAddress, port); |
| 29 | } | 29 | } |
| 30 | 30 | ||