Swiftdiff options
| author | Edwin Mons <edwin.mons@isode.com> | 2018-10-29 16:28:14 (GMT) |
|---|---|---|
| committer | Edwin Mons <edwin.mons@isode.com> | 2018-11-08 11:31:20 (GMT) |
| commit | cf3d517763a3d74a2ec9fd6f7bdee8cbaee3550f (patch) | |
| tree | 69e11e13ff2e5127d2cbfcc164be761cf104a1b2 /Swiften/Network/MiniUPnPInterface.h | |
| parent | 5ce9e19ef0744f530a797c30a82e9723eb7ea306 (diff) | |
| download | swift-cf3d517763a3d74a2ec9fd6f7bdee8cbaee3550f.zip swift-cf3d517763a3d74a2ec9fd6f7bdee8cbaee3550f.tar.bz2 | |
Consistently use unsigned short for network ports
Network ports are now consistently stored as unsigned shorts, apart from
the options and user interface, where -1 is still used to denote the use
of default ports.
Test-Information:
Unit tests pass on macOS 10.13 and Debian 9
On macOS: tested the UI with various proxy and manual ports, behaviour
as expected.
Change-Id: I7a65f40083022887aa30ed7b21eadc56d0c52be1
Diffstat (limited to 'Swiften/Network/MiniUPnPInterface.h')
| -rw-r--r-- | Swiften/Network/MiniUPnPInterface.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/Swiften/Network/MiniUPnPInterface.h b/Swiften/Network/MiniUPnPInterface.h index 89457b8..8c68268 100644 --- a/Swiften/Network/MiniUPnPInterface.h +++ b/Swiften/Network/MiniUPnPInterface.h | |||
| @@ -1,5 +1,5 @@ | |||
| 1 | /* | 1 | /* |
| 2 | * Copyright (c) 2011-2016 Isode Limited. | 2 | * Copyright (c) 2011-2018 Isode Limited. |
| 3 | * Licensed under the simplified BSD license. | 3 | * Licensed under the simplified BSD license. |
| 4 | * See Documentation/Licenses/BSD-simplified.txt for more information. | 4 | * See Documentation/Licenses/BSD-simplified.txt for more information. |
| 5 | */ | 5 | */ |
| @@ -23,7 +23,7 @@ namespace Swift { | |||
| 23 | virtual bool isAvailable(); | 23 | virtual bool isAvailable(); |
| 24 | 24 | ||
| 25 | boost::optional<HostAddress> getPublicIP(); | 25 | boost::optional<HostAddress> getPublicIP(); |
| 26 | boost::optional<NATPortMapping> addPortForward(int localPort, int publicPort); | 26 | boost::optional<NATPortMapping> addPortForward(unsigned short localPort, unsigned short publicPort); |
| 27 | bool removePortForward(const NATPortMapping&); | 27 | bool removePortForward(const NATPortMapping&); |
| 28 | 28 | ||
| 29 | private: | 29 | private: |