summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorEdwin Mons <edwin.mons@isode.com>2018-10-29 16:28:14 (GMT)
committerEdwin Mons <edwin.mons@isode.com>2018-11-08 11:31:20 (GMT)
commitcf3d517763a3d74a2ec9fd6f7bdee8cbaee3550f (patch)
tree69e11e13ff2e5127d2cbfcc164be761cf104a1b2 /Swiften/Network/SOCKS5ProxiedConnectionFactory.h
parent5ce9e19ef0744f530a797c30a82e9723eb7ea306 (diff)
downloadswift-cf3d517763a3d74a2ec9fd6f7bdee8cbaee3550f.zip
swift-cf3d517763a3d74a2ec9fd6f7bdee8cbaee3550f.tar.bz2
Consistently use unsigned short for network ports
Network ports are now consistently stored as unsigned shorts, apart from the options and user interface, where -1 is still used to denote the use of default ports. Test-Information: Unit tests pass on macOS 10.13 and Debian 9 On macOS: tested the UI with various proxy and manual ports, behaviour as expected. Change-Id: I7a65f40083022887aa30ed7b21eadc56d0c52be1
Diffstat (limited to 'Swiften/Network/SOCKS5ProxiedConnectionFactory.h')
-rw-r--r--Swiften/Network/SOCKS5ProxiedConnectionFactory.h6
1 files changed, 3 insertions, 3 deletions
diff --git a/Swiften/Network/SOCKS5ProxiedConnectionFactory.h b/Swiften/Network/SOCKS5ProxiedConnectionFactory.h
index 8631239..47ae9a3 100644
--- a/Swiften/Network/SOCKS5ProxiedConnectionFactory.h
+++ b/Swiften/Network/SOCKS5ProxiedConnectionFactory.h
@@ -5,7 +5,7 @@
5 */ 5 */
6 6
7/* 7/*
8 * Copyright (c) 2015-2016 Isode Limited. 8 * Copyright (c) 2015-2018 Isode Limited.
9 * All rights reserved. 9 * All rights reserved.
10 * See the COPYING file for more information. 10 * See the COPYING file for more information.
11 */ 11 */
@@ -23,7 +23,7 @@ namespace Swift {
23 23
24 class SWIFTEN_API SOCKS5ProxiedConnectionFactory : public ConnectionFactory { 24 class SWIFTEN_API SOCKS5ProxiedConnectionFactory : public ConnectionFactory {
25 public: 25 public:
26 SOCKS5ProxiedConnectionFactory(DomainNameResolver* resolver, ConnectionFactory* connectionFactory, TimerFactory* timerFactory, const std::string& proxyHost, int proxyPort); 26 SOCKS5ProxiedConnectionFactory(DomainNameResolver* resolver, ConnectionFactory* connectionFactory, TimerFactory* timerFactory, const std::string& proxyHost, unsigned short proxyPort);
27 27
28 virtual std::shared_ptr<Connection> createConnection(); 28 virtual std::shared_ptr<Connection> createConnection();
29 29
@@ -32,6 +32,6 @@ namespace Swift {
32 ConnectionFactory* connectionFactory_; 32 ConnectionFactory* connectionFactory_;
33 TimerFactory* timerFactory_; 33 TimerFactory* timerFactory_;
34 std::string proxyHost_; 34 std::string proxyHost_;
35 int proxyPort_; 35 unsigned short proxyPort_;
36 }; 36 };
37} 37}