Swiftdiff options
| author | Tobias Markmann <tm@ayena.de> | 2016-09-29 09:15:12 (GMT) |
|---|---|---|
| committer | Tobias Markmann <tm@ayena.de> | 2016-09-29 09:31:53 (GMT) |
| commit | c966e43b2852e69da1ed3cac9e11c1b026d4f4a9 (patch) | |
| tree | 006ee4058a289a59a6f7fa1604903fd11c2d6d4a /Swiften/Parser | |
| parent | 871c8955ae39e3eeb76a1bb72bf574764f5c30c3 (diff) | |
| download | swift-c966e43b2852e69da1ed3cac9e11c1b026d4f4a9.zip swift-c966e43b2852e69da1ed3cac9e11c1b026d4f4a9.tar.bz2 | |
Fix potential resource leaks
IDGenerator was missing the virtual keyword on its method
which is reimplemented by SimpleIDGenerator.
Some other classes were missing destructors or virtual
destructors.
Test-Information:
Builds on macOS 10.12 with Qt 5.5.1, all unit tests pass.
Change-Id: I482bc249578d38a922256d1fa5241515ce45d0c0
Diffstat (limited to 'Swiften/Parser')
| -rw-r--r-- | Swiften/Parser/PayloadParserFactoryCollection.cpp | 3 | ||||
| -rw-r--r-- | Swiften/Parser/PayloadParserFactoryCollection.h | 1 |
2 files changed, 4 insertions, 0 deletions
diff --git a/Swiften/Parser/PayloadParserFactoryCollection.cpp b/Swiften/Parser/PayloadParserFactoryCollection.cpp index 4426428..bca1e83 100644 --- a/Swiften/Parser/PayloadParserFactoryCollection.cpp +++ b/Swiften/Parser/PayloadParserFactoryCollection.cpp @@ -17,6 +17,9 @@ namespace Swift { PayloadParserFactoryCollection::PayloadParserFactoryCollection() : defaultFactory_(nullptr) { } +PayloadParserFactoryCollection::~PayloadParserFactoryCollection() { +} + void PayloadParserFactoryCollection::addFactory(PayloadParserFactory* factory) { factories_.push_back(factory); } diff --git a/Swiften/Parser/PayloadParserFactoryCollection.h b/Swiften/Parser/PayloadParserFactoryCollection.h index 06e334e..cc0db5a 100644 --- a/Swiften/Parser/PayloadParserFactoryCollection.h +++ b/Swiften/Parser/PayloadParserFactoryCollection.h @@ -17,6 +17,7 @@ namespace Swift { class SWIFTEN_API PayloadParserFactoryCollection { public: PayloadParserFactoryCollection(); + virtual ~PayloadParserFactoryCollection(); void addFactory(PayloadParserFactory* factory); void removeFactory(PayloadParserFactory* factory); |