summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
-rw-r--r--Swift/ChangeLog.md4
-rw-r--r--Swiften/Network/MacOSXProxyProvider.cpp3
2 files changed, 4 insertions, 3 deletions
diff --git a/Swift/ChangeLog.md b/Swift/ChangeLog.md
index bef90f5..544dcfa 100644
--- a/Swift/ChangeLog.md
+++ b/Swift/ChangeLog.md
@@ -1,3 +1,7 @@
+2.1
+---
+- Fixed potential crash when using proxies on Mac OS X.
+
2.0-beta2
---------
- Enable auto-completion of nicknames that don't start with a letter.
diff --git a/Swiften/Network/MacOSXProxyProvider.cpp b/Swiften/Network/MacOSXProxyProvider.cpp
index eaadd28..00fb478 100644
--- a/Swiften/Network/MacOSXProxyProvider.cpp
+++ b/Swiften/Network/MacOSXProxyProvider.cpp
@@ -27,7 +27,6 @@ static HostAddressPort getFromDictionary(CFDictionaryRef dict, CFStringRef enabl
const int i = 0;
CFNumberRef zero = CFNumberCreate(kCFAllocatorDefault, kCFNumberIntType, &i);
CFComparisonResult result = CFNumberCompare(numberValue, zero, NULL);
- CFRelease(numberValue);
if(result != kCFCompareEqualTo) {
int port = 0;
@@ -37,7 +36,6 @@ static HostAddressPort getFromDictionary(CFDictionaryRef dict, CFStringRef enabl
CFNumberRef numberValue = reinterpret_cast<CFNumberRef> (CFDictionaryGetValue(dict, portKey));
if(numberValue != NULL) {
CFNumberGetValue(numberValue, kCFNumberIntType, &port);
- CFRelease(numberValue);
}
CFStringRef stringValue = reinterpret_cast<CFStringRef> (CFDictionaryGetValue(dict, hostKey));
@@ -52,7 +50,6 @@ static HostAddressPort getFromDictionary(CFDictionaryRef dict, CFStringRef enabl
host += *iter;
}
}
- CFRelease(stringValue);
}
}
catch(...) {