1 files changed, 60 insertions, 59 deletions
diff --git a/Swiften/Network/MacOSXProxyProvider.cpp b/Swiften/Network/MacOSXProxyProvider.cpp
index a489add..232fc60 100644
--- a/Swiften/Network/MacOSXProxyProvider.cpp
+++ b/Swiften/Network/MacOSXProxyProvider.cpp
@@ -5,7 +5,7 @@
  */
 
 /*
- * Copyright (c) 2013 Isode Limited.
+ * Copyright (c) 2013-2016 Isode Limited.
  * All rights reserved.
  * See the COPYING file for more information.
  */
@@ -16,9 +16,10 @@
 #include <stdio.h>
 #include <stdlib.h>
 #include <iostream>
-#include <boost/numeric/conversion/cast.hpp>
 #include <utility>
 
+#include <boost/numeric/conversion/cast.hpp>
+
 #ifndef SWIFTEN_PLATFORM_IPHONE
 #include <SystemConfiguration/SystemConfiguration.h>
 #endif
@@ -29,49 +30,49 @@ using namespace Swift;
 
 #ifndef SWIFTEN_PLATFORM_IPHONE
 static HostAddressPort getFromDictionary(CFDictionaryRef dict, CFStringRef enabledKey, CFStringRef hostKey, CFStringRef portKey) {
-	CFNumberRef numberValue = NULL;
-	HostAddressPort ret = HostAddressPort(HostAddress(), 0);
-
-	if(CFDictionaryGetValueIfPresent(dict, reinterpret_cast<const void*> (enabledKey), reinterpret_cast<const void**> (&numberValue)) == true) {
-		const int i = 0;
-		CFNumberRef zero = CFNumberCreate(kCFAllocatorDefault, kCFNumberIntType, &i);
-		CFComparisonResult result = CFNumberCompare(numberValue, zero, NULL);
-		CFRelease(zero);
-
-		if(result != kCFCompareEqualTo) {
-			int port = 0;
-			std::string host = "";
-
-			try {
-				CFNumberRef numberValue = reinterpret_cast<CFNumberRef> (CFDictionaryGetValue(dict, portKey));
-				if(numberValue != NULL) {
-					CFNumberGetValue(numberValue, kCFNumberIntType, &port);
-				}
-
-				CFStringRef stringValue = reinterpret_cast<CFStringRef> (CFDictionaryGetValue(dict, hostKey));
-				if(stringValue != NULL) {
-					std::vector<char> buffer;
- 					// length must be +1 for the ending zero; and the Docu of CFStringGetCString tells it like
-					// if the string is toby the length must be at least 5.
-					CFIndex length = CFStringGetLength(stringValue) + 1;
-					buffer.resize(boost::numeric_cast<size_t>(length));
-					if(CFStringGetCString(stringValue, &buffer[0], length, kCFStringEncodingMacRoman)) {
-						for(std::vector<char>::iterator iter = buffer.begin(); iter != buffer.end(); ++iter) {
-							host += *iter;
-						}
-					}
-				}
-			}
-			catch(...) {
-				std::cerr << "Exception caught ... " << std::endl;
-			}
-			
-			if(host != "" && port != 0) {
-				ret = HostAddressPort(HostAddress(host), port);
-			}
-		}
-	}
-	return ret;
+    CFNumberRef numberValue = nullptr;
+    HostAddressPort ret = HostAddressPort(HostAddress(), 0);
+
+    if(CFDictionaryGetValueIfPresent(dict, reinterpret_cast<const void*> (enabledKey), reinterpret_cast<const void**> (&numberValue)) == true) {
+        const int i = 0;
+        CFNumberRef zero = CFNumberCreate(kCFAllocatorDefault, kCFNumberIntType, &i);
+        CFComparisonResult result = CFNumberCompare(numberValue, zero, nullptr);
+        CFRelease(zero);
+
+        if(result != kCFCompareEqualTo) {
+            int port = 0;
+            std::string host = "";
+
+            try {
+                CFNumberRef numberValue = reinterpret_cast<CFNumberRef> (CFDictionaryGetValue(dict, portKey));
+                if(numberValue != nullptr) {
+                    CFNumberGetValue(numberValue, kCFNumberIntType, &port);
+                }
+
+                CFStringRef stringValue = reinterpret_cast<CFStringRef> (CFDictionaryGetValue(dict, hostKey));
+                if(stringValue != nullptr) {
+                    std::vector<char> buffer;
+                     // length must be +1 for the ending zero; and the Docu of CFStringGetCString tells it like
+                    // if the string is toby the length must be at least 5.
+                    CFIndex length = CFStringGetLength(stringValue) + 1;
+                    buffer.resize(boost::numeric_cast<size_t>(length));
+                    if(CFStringGetCString(stringValue, &buffer[0], length, kCFStringEncodingMacRoman)) {
+                        for(char& iter : buffer) {
+                            host += iter;
+                        }
+                    }
+                }
+            }
+            catch(...) {
+                std::cerr << "Exception caught ... " << std::endl;
+            }
+
+            if(host != "" && port != 0) {
+                ret = HostAddressPort(HostAddress::fromString(host).get(), port);
+            }
+        }
+    }
+    return ret;
 }
 #endif
 namespace Swift {
@@ -80,27 +81,27 @@ MacOSXProxyProvider::MacOSXProxyProvider() {
 }
 
 HostAddressPort MacOSXProxyProvider::getHTTPConnectProxy() const {
-	HostAddressPort result;
+    HostAddressPort result;
 #ifndef SWIFTEN_PLATFORM_IPHONE
-	CFDictionaryRef proxies = SCDynamicStoreCopyProxies(NULL);
-	if(proxies != NULL) {
-		result = getFromDictionary(proxies, kSCPropNetProxiesHTTPEnable, kSCPropNetProxiesHTTPProxy, kSCPropNetProxiesHTTPPort);
-		CFRelease(proxies);
-	}
+    CFDictionaryRef proxies = SCDynamicStoreCopyProxies(nullptr);
+    if(proxies != nullptr) {
+        result = getFromDictionary(proxies, kSCPropNetProxiesHTTPEnable, kSCPropNetProxiesHTTPProxy, kSCPropNetProxiesHTTPPort);
+        CFRelease(proxies);
+    }
 #endif
-	return result;
+    return result;
 }
 
 HostAddressPort MacOSXProxyProvider::getSOCKS5Proxy() const {
-	HostAddressPort result;
+    HostAddressPort result;
 #ifndef SWIFTEN_PLATFORM_IPHONE
-	CFDictionaryRef proxies = SCDynamicStoreCopyProxies(NULL);
-	if(proxies != NULL) {
-		result = getFromDictionary(proxies, kSCPropNetProxiesSOCKSEnable, kSCPropNetProxiesSOCKSProxy, kSCPropNetProxiesSOCKSPort);
-		CFRelease(proxies);
-	}
+    CFDictionaryRef proxies = SCDynamicStoreCopyProxies(nullptr);
+    if(proxies != nullptr) {
+        result = getFromDictionary(proxies, kSCPropNetProxiesSOCKSEnable, kSCPropNetProxiesSOCKSProxy, kSCPropNetProxiesSOCKSPort);
+        CFRelease(proxies);
+    }
 #endif
-	return result;
+    return result;
 }
 
 }