1 files changed, 132 insertions, 135 deletions
diff --git a/Swiften/Presence/UnitTest/DirectedPresenceSenderTest.cpp b/Swiften/Presence/UnitTest/DirectedPresenceSenderTest.cpp
index e3885ad..38e67fb 100644
--- a/Swiften/Presence/UnitTest/DirectedPresenceSenderTest.cpp
+++ b/Swiften/Presence/UnitTest/DirectedPresenceSenderTest.cpp
@@ -1,9 +1,11 @@
 /*
- * Copyright (c) 2010 Isode Limited.
+ * Copyright (c) 2010-2016 Isode Limited.
  * All rights reserved.
  * See the COPYING file for more information.
  */
 
+#include <memory>
+
 #include <cppunit/extensions/HelperMacros.h>
 #include <cppunit/extensions/TestFactoryRegistry.h>
 
@@ -14,140 +16,135 @@
 using namespace Swift;
 
 class DirectedPresenceSenderTest : public CppUnit::TestFixture {
-		CPPUNIT_TEST_SUITE(DirectedPresenceSenderTest);
-		CPPUNIT_TEST(testSendPresence);
-		CPPUNIT_TEST(testSendPresence_UndirectedPresenceWithDirectedPresenceReceivers);
-		CPPUNIT_TEST(testSendPresence_DirectedPresenceWithDirectedPresenceReceivers);
-		CPPUNIT_TEST(testAddDirectedPresenceReceiver);
-		CPPUNIT_TEST(testAddDirectedPresenceReceiver_WithoutSendingPresence);
-		CPPUNIT_TEST(testAddDirectedPresenceReceiver_AfterSendingDirectedPresence);
-		CPPUNIT_TEST(testRemoveDirectedPresenceReceiver);
-		CPPUNIT_TEST(testRemoveDirectedPresenceReceiver_WithoutSendingPresence);
-		CPPUNIT_TEST_SUITE_END();
-
-	public:
-		void setUp() {
-			channel = new DummyStanzaChannel();
-			testPresence = boost::make_shared<Presence>();
-			testPresence->setStatus("Foo");
-			secondTestPresence = boost::make_shared<Presence>();
-			secondTestPresence->setStatus("Bar");
-			stanzaChannelPresenceSender = new StanzaChannelPresenceSender(channel);
-		}
-
-		void tearDown() {
-			delete stanzaChannelPresenceSender;
-			delete channel;
-		}
-
-		void testSendPresence() {
-			boost::shared_ptr<DirectedPresenceSender> testling(createPresenceSender());
-			testling->sendPresence(testPresence);
-
-			CPPUNIT_ASSERT_EQUAL(1, static_cast<int>(channel->sentStanzas.size()));
-			boost::shared_ptr<Presence> presence = boost::dynamic_pointer_cast<Presence>(channel->sentStanzas[0]);
-			CPPUNIT_ASSERT(testPresence == presence);
-		}
-
-		void testSendPresence_UndirectedPresenceWithDirectedPresenceReceivers() {
-			boost::shared_ptr<DirectedPresenceSender> testling(createPresenceSender());
-			testling->addDirectedPresenceReceiver(JID("alice@wonderland.lit/teaparty"), DirectedPresenceSender::AndSendPresence);
-
-			testling->sendPresence(testPresence);
-
-			CPPUNIT_ASSERT_EQUAL(2, static_cast<int>(channel->sentStanzas.size()));
-			boost::shared_ptr<Presence> presence = boost::dynamic_pointer_cast<Presence>(channel->sentStanzas[0]);
-			CPPUNIT_ASSERT(testPresence == presence);
-			presence = boost::dynamic_pointer_cast<Presence>(channel->sentStanzas[1]);
-			CPPUNIT_ASSERT_EQUAL(testPresence->getStatus(), presence->getStatus());
-			CPPUNIT_ASSERT_EQUAL(JID("alice@wonderland.lit/teaparty"), presence->getTo());
-		}
-
-		void testSendPresence_DirectedPresenceWithDirectedPresenceReceivers() {
-			boost::shared_ptr<DirectedPresenceSender> testling(createPresenceSender());
-			testling->addDirectedPresenceReceiver(JID("alice@wonderland.lit/teaparty"), DirectedPresenceSender::AndSendPresence);
-			channel->sentStanzas.clear();
-
-			testPresence->setTo(JID("foo@bar.com"));
-			testling->sendPresence(testPresence);
-
-			CPPUNIT_ASSERT_EQUAL(1, static_cast<int>(channel->sentStanzas.size()));
-			boost::shared_ptr<Presence> presence = boost::dynamic_pointer_cast<Presence>(channel->sentStanzas[0]);
-			CPPUNIT_ASSERT(testPresence == presence);
-		}
-
-		void testAddDirectedPresenceReceiver() {
-			boost::shared_ptr<DirectedPresenceSender> testling(createPresenceSender());
-			testling->sendPresence(testPresence);
-			channel->sentStanzas.clear();
-
-			testling->addDirectedPresenceReceiver(JID("alice@wonderland.lit/teaparty"), DirectedPresenceSender::AndSendPresence);
-
-			CPPUNIT_ASSERT_EQUAL(1, static_cast<int>(channel->sentStanzas.size()));
-			boost::shared_ptr<Presence> presence = boost::dynamic_pointer_cast<Presence>(channel->sentStanzas[0]);
-			CPPUNIT_ASSERT_EQUAL(testPresence->getStatus(), presence->getStatus());
-			CPPUNIT_ASSERT_EQUAL(JID("alice@wonderland.lit/teaparty"), presence->getTo());
-		}
-
-		void testAddDirectedPresenceReceiver_WithoutSendingPresence() {
-			boost::shared_ptr<DirectedPresenceSender> testling(createPresenceSender());
-			testling->sendPresence(testPresence);
-			channel->sentStanzas.clear();
-
-			testling->addDirectedPresenceReceiver(JID("alice@wonderland.lit/teaparty"), DirectedPresenceSender::DontSendPresence);
-
-			CPPUNIT_ASSERT_EQUAL(0, static_cast<int>(channel->sentStanzas.size()));
-		}
-
-		void testAddDirectedPresenceReceiver_AfterSendingDirectedPresence() {
-			boost::shared_ptr<DirectedPresenceSender> testling(createPresenceSender());
-			testling->sendPresence(testPresence);
-			secondTestPresence->setTo(JID("foo@bar.com"));
-			testling->sendPresence(secondTestPresence);
-			channel->sentStanzas.clear();
-
-			testling->addDirectedPresenceReceiver(JID("alice@wonderland.lit/teaparty"), DirectedPresenceSender::AndSendPresence);
-
-			CPPUNIT_ASSERT_EQUAL(1, static_cast<int>(channel->sentStanzas.size()));
-			boost::shared_ptr<Presence> presence = boost::dynamic_pointer_cast<Presence>(channel->sentStanzas[0]);
-			CPPUNIT_ASSERT_EQUAL(testPresence->getStatus(), presence->getStatus());
-			CPPUNIT_ASSERT_EQUAL(JID("alice@wonderland.lit/teaparty"), presence->getTo());
-		}
-
-		void testRemoveDirectedPresenceReceiver() {
-			boost::shared_ptr<DirectedPresenceSender> testling(createPresenceSender());
-			testling->addDirectedPresenceReceiver(JID("alice@wonderland.lit/teaparty"), DirectedPresenceSender::DontSendPresence);
-
-			testling->removeDirectedPresenceReceiver(JID("alice@wonderland.lit/teaparty"), DirectedPresenceSender::AndSendPresence);
-			testling->sendPresence(testPresence);
-
-			CPPUNIT_ASSERT_EQUAL(2, static_cast<int>(channel->sentStanzas.size()));
-			CPPUNIT_ASSERT_EQUAL(boost::dynamic_pointer_cast<Presence>(channel->sentStanzas[0])->getType(), Presence::Unavailable);
-			CPPUNIT_ASSERT(channel->sentStanzas[1] == testPresence);
-		}
-
-		void testRemoveDirectedPresenceReceiver_WithoutSendingPresence() {
-			boost::shared_ptr<DirectedPresenceSender> testling(createPresenceSender());
-			testling->addDirectedPresenceReceiver(JID("alice@wonderland.lit/teaparty"), DirectedPresenceSender::AndSendPresence);
-			channel->sentStanzas.clear();
-
-			testling->removeDirectedPresenceReceiver(JID("alice@wonderland.lit/teaparty"), DirectedPresenceSender::DontSendPresence);
-			testling->sendPresence(testPresence);
-
-			CPPUNIT_ASSERT_EQUAL(1, static_cast<int>(channel->sentStanzas.size()));
-			CPPUNIT_ASSERT(channel->sentStanzas[0] == testPresence);
-		}
-
-	private:
-		DirectedPresenceSender* createPresenceSender() {
-			return new DirectedPresenceSender(stanzaChannelPresenceSender);
-		}
-	
-	private:
-		DummyStanzaChannel* channel;
-		StanzaChannelPresenceSender* stanzaChannelPresenceSender;
-		boost::shared_ptr<Presence> testPresence;
-		boost::shared_ptr<Presence> secondTestPresence;
+        CPPUNIT_TEST_SUITE(DirectedPresenceSenderTest);
+        CPPUNIT_TEST(testSendPresence);
+        CPPUNIT_TEST(testSendPresence_UndirectedPresenceWithDirectedPresenceReceivers);
+        CPPUNIT_TEST(testSendPresence_DirectedPresenceWithDirectedPresenceReceivers);
+        CPPUNIT_TEST(testAddDirectedPresenceReceiver);
+        CPPUNIT_TEST(testAddDirectedPresenceReceiver_WithoutSendingPresence);
+        CPPUNIT_TEST(testAddDirectedPresenceReceiver_AfterSendingDirectedPresence);
+        CPPUNIT_TEST(testRemoveDirectedPresenceReceiver);
+        CPPUNIT_TEST(testRemoveDirectedPresenceReceiver_WithoutSendingPresence);
+        CPPUNIT_TEST_SUITE_END();
+
+    public:
+        void setUp() {
+            channel = std::unique_ptr<DummyStanzaChannel>(new DummyStanzaChannel());
+            testPresence = std::make_shared<Presence>();
+            testPresence->setStatus("Foo");
+            secondTestPresence = std::make_shared<Presence>();
+            secondTestPresence->setStatus("Bar");
+            stanzaChannelPresenceSender = std::unique_ptr<StanzaChannelPresenceSender>(new StanzaChannelPresenceSender(channel.get()));
+        }
+
+        void testSendPresence() {
+            std::shared_ptr<DirectedPresenceSender> testling(createPresenceSender());
+            testling->sendPresence(testPresence);
+
+            CPPUNIT_ASSERT_EQUAL(1, static_cast<int>(channel->sentStanzas.size()));
+            std::shared_ptr<Presence> presence = std::dynamic_pointer_cast<Presence>(channel->sentStanzas[0]);
+            CPPUNIT_ASSERT(testPresence == presence);
+        }
+
+        void testSendPresence_UndirectedPresenceWithDirectedPresenceReceivers() {
+            std::shared_ptr<DirectedPresenceSender> testling(createPresenceSender());
+            testling->addDirectedPresenceReceiver(JID("alice@wonderland.lit/teaparty"), DirectedPresenceSender::AndSendPresence);
+
+            testling->sendPresence(testPresence);
+
+            CPPUNIT_ASSERT_EQUAL(2, static_cast<int>(channel->sentStanzas.size()));
+            std::shared_ptr<Presence> presence = std::dynamic_pointer_cast<Presence>(channel->sentStanzas[0]);
+            CPPUNIT_ASSERT(testPresence == presence);
+            presence = std::dynamic_pointer_cast<Presence>(channel->sentStanzas[1]);
+            CPPUNIT_ASSERT_EQUAL(testPresence->getStatus(), presence->getStatus());
+            CPPUNIT_ASSERT_EQUAL(JID("alice@wonderland.lit/teaparty"), presence->getTo());
+        }
+
+        void testSendPresence_DirectedPresenceWithDirectedPresenceReceivers() {
+            std::shared_ptr<DirectedPresenceSender> testling(createPresenceSender());
+            testling->addDirectedPresenceReceiver(JID("alice@wonderland.lit/teaparty"), DirectedPresenceSender::AndSendPresence);
+            channel->sentStanzas.clear();
+
+            testPresence->setTo(JID("foo@bar.com"));
+            testling->sendPresence(testPresence);
+
+            CPPUNIT_ASSERT_EQUAL(1, static_cast<int>(channel->sentStanzas.size()));
+            std::shared_ptr<Presence> presence = std::dynamic_pointer_cast<Presence>(channel->sentStanzas[0]);
+            CPPUNIT_ASSERT(testPresence == presence);
+        }
+
+        void testAddDirectedPresenceReceiver() {
+            std::shared_ptr<DirectedPresenceSender> testling(createPresenceSender());
+            testling->sendPresence(testPresence);
+            channel->sentStanzas.clear();
+
+            testling->addDirectedPresenceReceiver(JID("alice@wonderland.lit/teaparty"), DirectedPresenceSender::AndSendPresence);
+
+            CPPUNIT_ASSERT_EQUAL(1, static_cast<int>(channel->sentStanzas.size()));
+            std::shared_ptr<Presence> presence = std::dynamic_pointer_cast<Presence>(channel->sentStanzas[0]);
+            CPPUNIT_ASSERT_EQUAL(testPresence->getStatus(), presence->getStatus());
+            CPPUNIT_ASSERT_EQUAL(JID("alice@wonderland.lit/teaparty"), presence->getTo());
+        }
+
+        void testAddDirectedPresenceReceiver_WithoutSendingPresence() {
+            std::shared_ptr<DirectedPresenceSender> testling(createPresenceSender());
+            testling->sendPresence(testPresence);
+            channel->sentStanzas.clear();
+
+            testling->addDirectedPresenceReceiver(JID("alice@wonderland.lit/teaparty"), DirectedPresenceSender::DontSendPresence);
+
+            CPPUNIT_ASSERT_EQUAL(0, static_cast<int>(channel->sentStanzas.size()));
+        }
+
+        void testAddDirectedPresenceReceiver_AfterSendingDirectedPresence() {
+            std::shared_ptr<DirectedPresenceSender> testling(createPresenceSender());
+            testling->sendPresence(testPresence);
+            secondTestPresence->setTo(JID("foo@bar.com"));
+            testling->sendPresence(secondTestPresence);
+            channel->sentStanzas.clear();
+
+            testling->addDirectedPresenceReceiver(JID("alice@wonderland.lit/teaparty"), DirectedPresenceSender::AndSendPresence);
+
+            CPPUNIT_ASSERT_EQUAL(1, static_cast<int>(channel->sentStanzas.size()));
+            std::shared_ptr<Presence> presence = std::dynamic_pointer_cast<Presence>(channel->sentStanzas[0]);
+            CPPUNIT_ASSERT_EQUAL(testPresence->getStatus(), presence->getStatus());
+            CPPUNIT_ASSERT_EQUAL(JID("alice@wonderland.lit/teaparty"), presence->getTo());
+        }
+
+        void testRemoveDirectedPresenceReceiver() {
+            std::shared_ptr<DirectedPresenceSender> testling(createPresenceSender());
+            testling->addDirectedPresenceReceiver(JID("alice@wonderland.lit/teaparty"), DirectedPresenceSender::DontSendPresence);
+
+            testling->removeDirectedPresenceReceiver(JID("alice@wonderland.lit/teaparty"), DirectedPresenceSender::AndSendPresence);
+            testling->sendPresence(testPresence);
+
+            CPPUNIT_ASSERT_EQUAL(2, static_cast<int>(channel->sentStanzas.size()));
+            CPPUNIT_ASSERT_EQUAL(std::dynamic_pointer_cast<Presence>(channel->sentStanzas[0])->getType(), Presence::Unavailable);
+            CPPUNIT_ASSERT(channel->sentStanzas[1] == testPresence);
+        }
+
+        void testRemoveDirectedPresenceReceiver_WithoutSendingPresence() {
+            std::shared_ptr<DirectedPresenceSender> testling(createPresenceSender());
+            testling->addDirectedPresenceReceiver(JID("alice@wonderland.lit/teaparty"), DirectedPresenceSender::AndSendPresence);
+            channel->sentStanzas.clear();
+
+            testling->removeDirectedPresenceReceiver(JID("alice@wonderland.lit/teaparty"), DirectedPresenceSender::DontSendPresence);
+            testling->sendPresence(testPresence);
+
+            CPPUNIT_ASSERT_EQUAL(1, static_cast<int>(channel->sentStanzas.size()));
+            CPPUNIT_ASSERT(channel->sentStanzas[0] == testPresence);
+        }
+
+    private:
+        DirectedPresenceSender* createPresenceSender() {
+            return new DirectedPresenceSender(stanzaChannelPresenceSender.get());
+        }
+
+    private:
+        std::unique_ptr<DummyStanzaChannel> channel;
+        std::unique_ptr<StanzaChannelPresenceSender> stanzaChannelPresenceSender;
+        std::shared_ptr<Presence> testPresence;
+        std::shared_ptr<Presence> secondTestPresence;
 };
 
 CPPUNIT_TEST_SUITE_REGISTRATION(DirectedPresenceSenderTest);