Age | Commit message (Collapse) | Author |
|
Qt models are not owned by their widgets. They must be deleted manually
or a parent has to be specified for them which will take care of deletion.
The same goes for delegates and their views.
Test-Information:
Tested with Clang's leak sanitizer (part of address sanitizer). The
leak reports for the respective lines are gone with this fix.
Change-Id: Ia7407cb20ae9e4ccc2e1cf48c88877c2f87352e1
|
|
Test-Information:
Unit tests run successful on OS X 10.9.5
Change-Id: I9df0c798723f79df85cfc7301aed0a7ad6309904
|
|
The data race is on the events_ member in DummyEventLoop.
A BoostIOServerThread can post events to the DummyEventLoop and thereby
access its events_ data member while the test's main code processes
events of the loop.
To prevent access to the DummyEventLoop by the BoostIOServiceThread
after the DummyEventLoop is deleted, the BoostIOServiceThread is
deleted before the DummyEventLoop.
Process remaining events in BoostConnectionTest::tearDown like we do in
BoostConnectionServerTest::tearDown.
Test-Information:
Run multiple times on NetworkTest as TSAN enabled build on Linux.
Without the patch it reports a data race for the events_ deque member.
Change-Id: I3c85535338fc0ce0263dbfc3534aceb1dd09c137
|
|
Test-Information:
Run on ClientTest as TSAN enabled build on Linux. Without the patch
it reports a data race for the stopRequested member.
Change-Id: I98373966c45d4c6e247f69fa8850278d885556f7
|
|
Test-Information:
All tests still succeed on OS X and Linux.
Change-Id: I2c02252b646b539b960cad18b6f88807afd84d32
|
|
If windeployqt.exe is available for Qt5, it will be used to detect
which Qt DLLs to put in the Windows distribution and its dependencies
correctly.
Added a note to our Windows building documentation about the VS
redistributable.
Test-Information:
Tested building a MSI package on Windows 8.1 Pro with Qt 5.3.2 32-bit
msvc2013_opengl which successfully installs and runs.
Change-Id: I786da40d6467f1de8e64bfae275f8363ac1d5ba8
|
|
Test-Information:
None required.
Change-Id: If267201ea28e894a9f79335972b71611b0058912
|
|
Mainly useful for developers of the Swift client or users of
Swift/Controllers.
Test-Information:
Verified that Swift documentation is build.
Change-Id: I4bf3e78392cd40d646b33a9fd04c90702c08cfa3
|
|
Thanks Zash
Change-Id: I696ab1e44b24e6b3fe2f829b854af3dbffcc0beb
|
|
The class connects to SettingsProvider::onSettingChanged in its c-tor
but never disconnects from the signal. When an instance is deleted and
the signal is called afterwards it will call the method which will try
to access class members which have already been deleted.
Test-Information:
Tested on OS X 10.9.5. ASAN reported it sometimes on exit. Have not
been able to reproduc it anymore with this fix.
Change-Id: I7f1d815dca87f84a4ae93a5455307e261a1ee329
|
|
Messages received from a MUC bare JID in a MUC have been rendered as
user messages in the past. They are now rendered as system messages.
Test-Information:
Tested with a MUC component that sends a bare message on login.
Change-Id: I9a548ec9b81db8ba329182e08446d72c3518c7cb
|
|
Test-Information:
Tested on OS X 10.9.5.
Change-Id: I2ed72f0147a1dacd6e146e4d3b4c2d05ea1c7a85
|
|
The button is only shown if the current rules are *not* the default
set of rules.
Test-Information:
Tested on Mac OS X 10.9.5.
Change-Id: Ibf1856af04c6bdacf6102d240e6fe5f6071cb46a
|
|
In the past MUCController added a "trying to enter..." message and
later tried to replace this with "entered room as..." message. However,
any message received in between, like a system message about room topic,
came in between since MUCController replaced the *last* message added
to the log.
The new code also adds message IDs to system messages. This way the
correct message can be replaced on successful login, no matter how
many messages came in between.
Test-Information:
Tested against a MUC component that send a system message before
sending the join presence back to a user.
Change-Id: I3bcb5d78de680494965d837b2ad3edb847ff7f99
|
|
Change-Id: Icfa2a22aa3c443d2a400a3466bf523a8c91ba85a
|
|
transport method element, parser and serializer.
Test-Information:
Adjusted parser and serializer tests to cover this feature.
Change-Id: I660ef8d292a0fe09f80c042bc6df417b0e7525b1
|
|
Test-Information:
Verified using Port Map.app tool and router supporting UPnP.
Change-Id: I8d43a812f136979a70ef4dc62ff45448c6603b8b
|
|
Test-Information:
Unit tests run successfully.
Change-Id: I5df196c8bc642eeff4997558c3c56c6fa03bef16
|
|
Update SendFile.cpp to recent Jingle file-transfer changes and clean
up old code.
Test-Information:
Verified that a file-transfer between SendFile and ReceiveFile
examples works.
Change-Id: I342cfa2f4949ffcc1e227e6ebdd10de84e5d6a8a
|
|
libnatpmp has a high (over 2 minutes) timeout for discovery of NAT-PMP
support. This leads to a bad user experience when there is no NAT-PMP
support in the network.
Test-Information:
Tested this in an university network where neither UPnP nor NAT-PMP is
available. File-transfers waited more than 2 minutes for an answer of
a NAT-PMP device before starting the file-transfer.
Change-Id: I3ceaac7f89c982ffa683ee367d5ea3c3d4a2c5ca
|
|
Test-Information:
Unit tests succeed on OS X 10.9.5.
Change-Id: Ie683dd1110640b1b5ce988f44f17cd3588663342
|
|
urn:xmpp:jingle:apps:file-transfer:4.
Test-Information:
Adjusted unit tests and successfully build/run them on OS X 10.9.5.
Change-Id: I63789e3fb351999f719157b54fa9fcf95f40fb07
|
|
Boost query objects are setup with the flag address_configured by
default which only does IPv6 resoltuion if a non-loopback device is
found. This detection mechanism does not seem to work. At least in my
test VM there was a non-loopback device with IPv6 address and it still
reported no IPv6 addresses. Setting the flag to passive will
have it always send queries for AAAA records.
Test-Informatioon:
Tested on Mac OS X 10.9.5 and Elementary OS 0.2.1 (Linux).
Change-Id: I346bcb7982dee465aa7847a7bae8981a16f2d3bc
|
|
class.
In addition this commit also adds brief documentation for the
SimpleIDGenerator.
Test-Information:
Builds and runs fine on OS X 10.9.5.
Change-Id: I87360933d50c7bb56b19859c9890d9000d3c147b
|
|
Test-Information:
Builds on OS X 10.9.5.
Change-Id: I53498fabfabb969c907bf95ff89e19952572115e
|
|
first result and show incoming messages.
Test-Information:
Tested on OS X 10.9.5 with a Prosody MUC service.
Change-Id: If64e80bf4fc70366fabb3fd86d6da67a6f307280
|
|
Change-Id: I08dfd07882b820d897ddb02f2f821141adff4018
|
|
Change-Id: I94ab4bbb68c603fe872abeb8090575de042f5cb4
|
|
Change-Id: I9cc7b3805b7de972adfef4952f4841c21603542f
|
|
Change-Id: Idb6ef5fa191b1465c0bf46c47e63b695de07fa0b
|
|
Change-Id: Ic5a0cd2d65caac21a748a9a6996a596ee80f5337
|
|
Change-Id: I19f8ae342e028a6a7b4b13758f2e8c170a1db80c
|
|
Change-Id: I927ac2ed7be0153bb0e3d9f33c3001734ee9f65c
|
|
Change-Id: I235c4d866897db7e47de3c505ed6adecfa577c91
|
|
Change-Id: I39401805e3ba64c677c65f0a4d563ac177f8c2f4
|
|
Change-Id: Iaca33add452335a96e0b7c3721d0a544292a3132
|
|
Change-Id: I34a1d96bb0a9d0ba3252644d1cbd0137df13c9ca
|
|
Change-Id: I353f4ee3c2df722c2af5c5cd51c4ac4e5d5c67dd
|
|
The index element was missing, added it in Swiften and Sluift.
Change-Id: I709037fafcc5242c7c2e2fddb8469316c106d51a
|
|
This includes dynamic customizable grid layouting of chat tabs including:
- arrengement of tabs via menu, keyboard shortcuts or drag'n'drop
- change of grid size via mouse or keyboard
- save/restore of grid size and positions of chats inside the grid
Test-Information:
Tested on OS X 10.9.8.
Change-Id: I43f94293a1c672971640c3000abfc6530f2ea7a8
|
|
This fixes spell checking not interfering with Qt's undo stack management anymore.
Test-Information:
Tested on OS X 10.9.5 with Qt 5.3.2.
Change-Id: Icc3aa9f7213856388e4da317525c75ac97da72e3
|
|
Test-Information:
Tested building with latest OpenSSL release for Android.
Change-Id: I1cae5ea0ca5800fa719e59753bffafee043ac54b
|
|
Test-Information:
Tested with nm tool from cross-compiling toolchain. Before it would report
'Malformed archive' for libSwiften.a. Now it correctly lists all symbols without
reporting an error.
Change-Id: I3901bb206487a05124986bbdc53f336aed932f5b
|
|
Test-Information:
Tested it now shows the corrected text.
Change-Id: Id4d768428064608ba8e034cefdbbe6530e5ee8ef
|
|
Change-Id: I3767f479609bf64cc6d64932e125c2e66e5f75eb
|
|
MAMFinSerializer should be in teh FullPayloadSerializerCollection.
FogBugz:
Bug:
Release-notes:
Manual:
Test-information:
Ran ./scons check=1 as a sanity test. Code compiled and tests ran ok.
Change-Id: Icde00cbff7ffbf050033d5abd4ce89ce849a2479
Reviewer:
|
|
This tool reads in implementation or header files and groups and sorts include
statements at the top according to our guidelines.
It does not support files using #if statements in head of the file.
Change-Id: I34b02546ecaf1653372f6edd319126b2ebb22ab5
|
|
iOS SDK does not have net/route.h interface as part of its public API. File-transfer
requires UPnP/NAT-PMP for a good user experience which in turn require detection
of the default gateway/router. Disabiling file-transfer support for iOS until we
know a valid way to detect the default gateway/router on iOS.
Test-Information:
Tested against iPhone/iPhoneSimulator8.1 SDKs.
Change-Id: I1303f37c025e8c6309acefcd80b9b30a3ac18fbb
|
|
Test-Information:
Tested against iPhone/iPhoneSimulator8.1 SDKs.
Change-Id: I8837f653799587edf43885c3632b1f647832f429
|
|
Change-Id: Ida1dd60a01e16e71831221b7e2fcfb74fdde54f3
|