| Age | Commit message (Collapse) | Author |
|---|
|
Removed dead debugging code and unnecessary includes as well.
Test-Information:
Tested with Swiften/QA/ClientTest, adjusted to have a manual hostname
set in the ClientOptions.
Tested on OS X 10.9.5, with NDK API level 14 on an emulated Android 4.0
ARM instance.
Without this patch the connector timed out during name lookup trying
to resolve the IP set in the ClientOptions::manualHostname. With this
patch it skips lookup and connects successfully.
Tested and verified unchanged behavior with this patch and without the
manual address override set.
Change-Id: I737327b2e66c9da78a1963e754bcf201b7d40626
|
|
Test-Information:
Compiles without the warning, unit tests pass.
Change-Id: I31bce47e4d6595b4ef405a87b56cf71db004e6a0
|
|
Label the window for adding bookmarks as "Add Bookmark Details".
Allow modification of bookmarks from the cog menu in the chat window
and adjust the context menu item accordingly.
Test-Information:
Tested the bookmarks section of the "Chats" tab in the contact list
and the UX scenario using the cog menu that it works as expected.
Tested it on OS X 10.9.5 with Qt 5.4.1.
Change-Id: I80daf339fc86506db3d863decae4bcd892e3ea88
|
|
When hiding the popup after selection of an item via mouse, the focus
was given to a widget other then the QtSuggestingJIDInput or its parent
dialog. This patch explicitly sets the focus back to the
QtSuggestingJIDInput.
Hide the potentially open popup when the QtSuggestingJIDInput is hidden.
This can happen when the user closes a dialog with a QtSuggestingJIDInput
inside of it.
Test-Information:
Verified described behavior on OS X 10.9.5 and Windows 8.
Change-Id: Ic6629e6e626be18a70de159df62cda79dd82ee09
|
|
In-place modification can be enabled by passing -i as second parameter.
Added detection of other preprocessor directives not supported by this
tool. It will report a warning in this case.
Test-Information:
Ran the tool over all .h/.cpp files in Swiften. Still build on OS X with
clang.
Change-Id: Ic6e15142379ab9fc8a2bc5a6f9c1c2a906dec692
|
|
Test-Information:
Tested vertical alignment of close button on OS X, Windows 7 and
Elementary OS.
Change-Id: Ia07a8476912674c94d851315f80630710e5f4217
|
|
This is should be a union of the two diagonal resize cursors on most
systems and is provided by Qt.
Test-Information:
Tested on Windows 7 and OS X 10.9.5. On OS X the cursor does not look
like the union of the two diagonal resize cursors with Qt 5.4.1.
Change-Id: I442f7e25b9bf0a3e6868cbcc9bd0a48d24da718d
|
|
This patch changes the rightmost widget in the VCard fields from a
QLabel to a QtElidingLabel.
It also improves the spacing in the header in VCard profile dialog.
Test-Information:
Tested on OS X 10.9.5 with Qt 5.4.1.
Change-Id: I771ddb555c5990c67550d9e36f001e57644712da
|
|
Change-Id: Ib9655f3c7f06a6b8ef2d8f4e48e9ebcb04431dc0
|
|
Due ot the way Qt implements widgets and the events, the windowOpening
signal of a QtTabbable is emitted before the QtTabbable is a member of
a QTabWidget when adding a QtTabbable to a QTabWidget.
Disabling the signals when adding the widget will prevent these signals
to be called and will prevent and endlress recursion.
This has originally been reported by Pavol Babincak.
Test-Information:
Without this patch the reporter had Swift crash after a day or two.
With this patch the reporter does not experience the endless recursion
(crash) anymore.
Change-Id: I8b3d791d79e9ab8f42dd1a1cba30d118f620f15d
|
|
IncomingJingleFileTransfer::terminate already sets the finshed state
for the file-transfer.
Test-Information:
Verified in the logs that onFinished signal is only called once.
Change-Id: Ib2084e1487ded2a921f61b237cd036e1ae4cf992
|
|
Test-Information:
The FileTransfer::onFinished was not called when the file transfer finished.
Verified with log output that it is called correctly now.
Change-Id: I05f2a749ca3f0aece08cae9503a212cf0327f98a
|
|
Previously all IQ handlers were final. The IQ handles were processed
in last-added-first order and if the IQ payload matched the handler
payload, the IQ would only be passed to that handler.
This conflicts with our IBBReceiveSession. When running multiple
concurrent file-transfers using multiple IBBReceiveSessions there are
multiple IQ handlers for IBB content; one for every transfer.
This commit allows a Responder to be set as non-final. In this case
unhandled IQs will not be responded with an error but returned to
the IQRouter so it can pass it to the next possible IQ handler.
Test-Information:
Tested with ConcurrentFileTransferTest with runs multiple IBB transfers
in parallel.
Change-Id: I8237e234cbe5c110deaa8c3d6ba303b65fd53d00
|
|
Test-Information:
Builds.
Change-Id: Ica4b1bca4ff71f103ee5ebad707bc0f95595ad37
|
|
Test-Information:
Still builds and behaves as expected.
Change-Id: Ic3553ae2e34acf58a912bc7e2643fcb7d66f824e
|
|
Test-Information:
None.
Change-Id: If02bc8bf250b129522bbeb841f699ccea9721422
|
|
Test-Information:
Unit tests pass.
Change-Id: I793fb65fd2e760daddab0142abc33d4aa5b4fce5
|
|
Test-Information:
Verified in the UI after a build.
Change-Id: I7586fc5c8f3bd4de4ea8e52e70ced3f9b50244f7
|
|
Previously every time WiX heat.exe ran it generated new GUIDs for all
the file components that MSI was going to install. Windows installer
deletes components if there is no software/component left that is
referencing it.
This patch uses the -ag flag instead of the -gg flag for heat.exe so
it will generate deterministic GUIDs based on the filename and other
things instead of completely random new one on each run.
In addition we schedule the upgrade to run after the new version has
been installed. This way old files are first replaced with the new
ones, shortcuts remain and are not deleted, pinned shortcuts remain
usable. Afterwards MSI uninstalls the old version, specifically the
components that are not reference anymore.
Test-Information:
Tested (a) two version upgrade with this patch and (b) an upgrade from
a version without this patch to a version with this patch.
a) The upgrade works as expected. MSI installs the new version and then
uninstalls the old version. The pinned shortcut stays alive and works.
b) In this case during the deinstallation files of the new installation
are deleted, since there are two components with different GUIDs which
however use the same filenames.
Running a repair on this installation, or first deinstalling the old
version and then the new one manually fixes this.
Change-Id: I842a288d837962e77efaa15b17d3877e923c7e49
|
|
This is simple popup menu added to chat window where it is possible to choose an emoticon. To activate click on the smiling face next to input field.
When emoticon is selected its text equivalent is appended to input.
License:
This patch is BSD-licensed, see Documentation/Licenses/BSD-simplified.txt for details.
Test-Information:
Tested on Ubuntu 14.10 with KDE and Qt 4.8.6
Change-Id: I6c5907959970398c9c38591f64ceec20efcbf409
|
|
Change-Id: I9c8692e0c4f36877591385a7580cb8a2107bd68f
|
|
This fix lets HTTPConnectProxiedConnection buffer response data in
pieces until the end of the HTTP header is reached. Only then it will
try to parse the HTTP header.
This is *not* the HTTP chunked transfer encoding.
Test-Information:
Adjusted one test to respond in pieces and added a new test case that
verifies that response data is buffered.
Change-Id: Icfb987bdf2fc5771401a8a9c6979fa9ad1eebdca
|
|
License:
This patch is BSD-licensed, see Documentation/Licenses/BSD-simplified.txt for details.
Test-Information:
Test for ChatStateSerializer passes.
Change-Id: I871490a647ee54631cad025fc71f900cc0fa9770
|
|
This patch adds HTTPTrafficFilter and integrates it into
HTTPConnectProxiedConnection. This allows the HTTP CONNECT proxy
initialization process to be customized.
Test-Information:
Added a unit test that verifies the new functionality.
Change-Id: I0b93c319fb205487b8be65717276cd0dd38851a3
|
|
FullPayloadSerializerCollection
Test-Information:
Builds and unit tests run through.
Change-Id: I0dac62cdef56ec4780388f25d24ca0818b900dad
|
|
Test-Information:
Unit tests still pass. Carbons serializers are tested directly without
FullPayloadSerializerCollection.
Change-Id: Ic0f961094daf09836326660859b41d86141e70b9
|
|
Test-Information:
Builds.
Change-Id: I1d8a942a2063c6bc0f7322161a33c0413a6899a3
|
|
Change-Id: Ia7a9bd1bfeb50b4a5f0ce1ec6f72f095000002c4
|
|
Setup an application wide focus handler which updates the title if a
focus change to a QtTabWidget happened.
Test-Information:
Tested on OS X 10.9.5 with Qt 5.4.0.
Change-Id: Ib2e2f4c4a93deddb286350bdef685eb7aee504c9
|
|
Test-Information:
Tested on OS X 10.9.5 with Qt 5.4.0.
Change-Id: Ia60808f5ae371db6b438b7396fa1f999f4572a96
|
|
In addition this patch adds an element, a parser and a serializer for
the <thread/> element from XMPP IM.
Test-Information:
Implemented unit tests pass as expected.
Change-Id: I0a14c778c2c0bf65f4b405c9878c741449bfe142
|
|
Reported by Scrool.
Test-Information:
Scons would fail during configuration with 'File "/home/pbabinca/
workspace/swift/3rdParty/LibIDN/SConscript", line 30, in <module>'
without this patch.
Change-Id: I785d0535d1a20b8ff22eb78c1ea2b65eb80ac0db
|
|
To prevent an infinite recurison during when a tab is returned (added
again) to the original QTabWidget.
The recursion was caused by a show event that is emmitted during insert
and our QtChatTabs::handleWidgetShown function trying to add the tab
again because it is not in the QTabWidget yet; it would be if the show
event would be emitted after the insert is done and not somewhere
during the insert.
Test-Information:
Dragging a tab in trellis mode and *not* dropping it on a tab bar.
Previously this would cause an infinite recursion. Now it just returns
the tab to its previous place.
Tested on OS X 10.9.5 with Qt 5.4.0.
Change-Id: Icd54b95b6f0542b6a9d3921fa1b0ab4df409950a
|
|
Change-Id: Icc901591f7e2f72251222ba34263824c124672f0
|
|
Change-Id: Ic0e055d2ed5366c2305a38b5eb70ea0561ba7cdc
|
|
Change-Id: I25328f60e211387f5d3fbcd6de155b7b8956c0f9
License: This patch is BSD-licensed, see Documentation/Licenses/BSD-simplified.txt for details.
|
|
Classes to support XEP-0141 data forms layout. This includes <page/>,
<section/>, <reportedref/> and <text/> elements. The form
parser and serializer classes have also been updated to handle these new
elements, with added CPPUnit tests.
Test-information:
Tested using updated CPPUnit tests to check the parsing and serializing of
new elements. All tests complete successfully.
Change-Id: Ibeab22d2834512d06c7f656acd1ef24eea39d650
|
|
This commit fixes CTRL-Tab, CTRL-Backtab and CTRL-W shortcuts on Mac,
Windows and Linux.
These shortcuts work in all mode except --no-tabs mode. This will be fixed
in a future commit. There is still different behavior across platforms:
on Windows and Linux they are handled on key press and repeat, and on
Mac they are handled on key release and do not repeat.
Test-Information:
Tested on OS X 10.9.5, Windows 7 and Elementary OS.
Change-Id: I2179f234cfd76b86cf261f2cf7500fc1cf0439a4
|
|
Test-Information:
None.
Change-Id: I022a65c64e73e1ae70ee21673fa5cce7afbe51a6
|
|
When the user tries to enter a blocked room, we now show a warning
notice and describing how the room can be unblocked. Swift will not
send the joining presence when trying to enter a blocked room.
Test-Information:
Tested on Mac OS X 10.9.5 against a popular open source server and its
MUC and Blocking Command implementation.
Change-Id: I875db056f21f97845c5a9a43167b0f2a16bdaa36
|
|
If Scons is configured to run system unit tests, it will run
FileTransferTest and test for working IBB transfer, direct S5B transfer
and proxied S5B transfer.
Test-Information:
Tested ./scons test=all is working on Linux and OS X.
Change-Id: Id70c9e1e9db9c897d9bfc7dd03b874afe5262207
|
|
SOCKS5BytestreamProxiesManager will try to stop its ProxyFinder if it
exists in its dtor.
Test-Information:
Running the FileTransferTest crashed before. Now it successfully runs
through on Linux.
Change-Id: I1e95694a5d32728123ddb436274901e4d8643974
|
|
createWindowsBundle implementation
Test-Information:
Did a clear rebuild with dist=1 and confirmed that it now starts the
WiX process after all dependencies are copied over.
Change-Id: Icbb9ec127b0d56e10f2620790f0fc6b6a29d5aa5
|
|
The tests have been adjusted so a colour is set in their highlight
actions.
Test-Information:
Tested with a "own nick" highlight rule with a "No highlight" action
and one with highlights colours set. The cases now work as expected.
Added a unit test that checks that no highlighting happens when no
colour is specified.
Change-Id: Ied48d8c2e033531c1b0532348b9380e1bd884b44
|
|
Test-Information:
Tried to connect to BOSH service setting the boshPath to "http-bind"
while "/http-bind" would have been correct.
Change-Id: Ifc9bb574361c9eaa3baeffc2938d06a257275f2a
|
|
Change-Id: If1f0b08ac600e6c84d367132cc512dc5a3add442
|
|
Change-Id: I55e69471a03b507b3c50ac5fa24b486a0826e1c5
|
|
QtRemovableItemDelegate only renders the icon if the data for the
cell is empty. This is to enable persistent entries. With this commit
the model only returns the expected data for the first column.
Test-Information:
Tested on OS X 10.9.5 with Qt 5.4.0.
Change-Id: I5cacebcc47323280b689badf2ba90b3503c17061
|
|
Test-Information:
None.
Change-Id: Iaff0108547658e1b103905c78fac5d1faf3a15e1
|
|
Trellis changes introduced a bug for the --no-tabs mode.
Test-Information:
Tested on Mac OS X 10.9.5.
Change-Id: Ic918a38cda00a64f8eca496ede0190fbef6b6602
|
Swift