Age | Commit message (Collapse) | Author |
|
Checked Growl and Snarl backends which both already do
the check for empty callbacks.
Test-Information:
Tested clicking on an disconnect notification of Swift on
OS X 10.11.3 which previously caused a crash. Now it does not
crash anymore in this case.
Change-Id: I7045ab22a0322cc7a50761640a9b89ba2302acef
|
|
This commit adds explicit code to stop timers which are
connected to objects that are about to be deleted from
memory.
Test-Information:
./scons test=system passes on OS X 10.11.3.
Change-Id: I139314f3a223e3dc63b78b96be17d3ae53cd3de3
|
|
These cases have been uncovered by Clang Analyzer as they
were called during some constructor. However, there is no
reason for them being virtual. They are never overridden in
a derived class.
Test-Information:
Unit tests still pass on OS X 10.10.5.
Change-Id: I90b5396a0dba971d9150c35f9107733f7f4637cd
|
|
These errors were reported by Clang Analyzer.
Test-Information:
Verified that behavior is still as expected and Clang
Analyzer does not report the warnings anymore.
Change-Id: I149d75241f7680a6d2f2b6b710dd38d1ed81a209
|
|
Test-Information:
Verified that there are still suggestions by comparing
misspelled test phrases in Swift without this change and
Swift with this change.
Change-Id: Ice11af65028a96c86b1b5cc57ddad8eeda1ccf76
|
|
Older versions of OS X define the same symbol as Boost does.
The workaround, defining
__ASSERT_MACROS_DEFINE_VERSIONS_WITHOUT_UNDERSCORES as 0
worked around this issue, however __ prefixed defines are
considered private and cause the warning
"macro name is a reserved identifier [-Wreserved-id-macro]".
Test-Information:
Builds and unit tests pass on OS X 10.10.5.
Change-Id: I489ec201dc31fb4e43336da690c7d348a7d0d9ca
|
|
Test-Information:
Verified behavior on OS X 10.10.5 with two accounts,
presence changes and message exchanges.
Change-Id: I79b4b8a92076dfb4c2d65f91bfb2f808cf7821d5
|
|
This implements basic support for OS X Notification Center
notifications with simple banner notifications showing type,
contact and message/presence information. A click on the
notification opens the chat view to the contact.
The Notification Center backend will be used on OS X if the Growl
notification backend is not used.
This code requires OS X version 10.8 or later.
Test-Information:
Tested presence and message notifications between multiple Swift
accounts and instances on OS X 10.9.5.
Change-Id: I7b9e2132cab25e086e0912191562cad8f4cbae38
|
|
Change-Id: Ic5a0cd2d65caac21a748a9a6996a596ee80f5337
|
|
Test-Information:
Not manually tested.
Change-Id: I1bd6d73388a95f6438606ff44011db849c024225
|
|
This updates Boost in our 3rdParty directory to version 1.56.0.
Updated our update.sh script to stop on error.
Changed error reporting in SwiftTools/CrashReporter.cpp to SWIFT_LOG due to
missing include of <iostream> with newer Boost.
Change-Id: I4b35c77de951333979a524097f35f5f83d325edc
|
|
Includes fixes to:
Build with new Visual Studio and Boost
Avoid error caused when Avahi is present but Qt is not
Make declaration of XMPPRosterImpl::addContact consistent with implementation
Includes enhancements to:
Allow user-configurable mt.exe
Allow splitting openssl paths
Allow disabling gconf lookup
Make idn support optional
Allow disabling various library detections
Remove use of non-Python2.4 features in sconscripts
Test-Information:
Builds
Change-Id: Iee91ee80291a8bdf87cc169c915e4dad1cc1055b
|
|
Change-Id: Ied0ac4abb21ef1720411fdbc61e7a687eee3afd1
|
|
Change-Id: I36e82dfe1ec492df719bcc85e5549fb4013a6723
|
|
This one only seems to appear when using CLang.
Change-Id: Ib12fbeb3da0dfb54aef0613c7b9eba577654cd6a
|
|
Change-Id: I8f44bab2f4d32e955e38e6e355824ca513b6a930
|
|
Move instance variables to implementation because they are deprecated to have in the interface. Requires 'Modern' obj-c runtime.
Change-Id: I60d693b7966e08ccc003818ab51ea3633c90ae17
License: This patch is BSD-licensed, see Documentation/Licenses/BSD-simplified.txt for details.
|
|
Change-Id: Ibe2cbb2e9b0f87e073cc821a47135731a4cf7e76
License: This patch is BSD-licensed, see Documentation/Licenses/BSD-simplified.txt for details.
|
|
Change-Id: I07256f23ffbb6520f5063bdfbed9111946c46746
|
|
- Use boost::filesystem::path consistently for referring to files.
- Use boost::filesystem streams for I/O, such that paths are always handled
correctly.
- Use stringToPath and pathToString for conversion between strings and
boost::filesystem::path, to ensure we have consistent unicode handling
across platforms and environments. The default constructor and string
conversion uses platform-dependent encoding, depending on the global
locale set in the application, which causes problems. So, unless you are
in platform dependent code, the default constructor and string() function
should not be used. When constructing paths from other paths (e.g. using
operator/), also use stringToPath (instead of string arguments) if the path
can contain unicode characters.
Change-Id: If286bd9e71c8414afc0b24ba67e26ab7608ef6ea
|
|
Change-Id: I6d86bf7d8dcc750ff69ff08500c9987b3c1de43e
|
|
Change-Id: I86569f168987c1b02bd4a45e569b1acffa3f8007
|
|
Change-Id: I5d728024dc52ec3279528e9f0bf4b0508c459107
|
|
Change-Id: Id29313a06f052ecbaef54be0c185cd7f1df375a2
License: This patch is BSD-licensed, see Documentation/Licenses/BSD-simplified.txt for details.
|
|
Change-Id: Ic7d26086a51e346605cb85201d55bf8cbc4249f1
|
|
Change-Id: Ia15b6532edf6eef7c45bdfb273e77f65ce998f13
License: This patch is BSD-licensed, see Documentation/Licenses/BSD-simplified.txt for details
|
|
Change-Id: I62c7d5ca44c915e36c797c798294b7c34b465514
|
|
Change-Id: I62206d3813e8873f027ff46e525a30bcb2e945c9
|
|
Change-Id: I0fc27a08adb6aecd5c5775a52b7fe48570ed526a
|
|
Change-Id: I70109624b4bd7aab9ba679a3eaabc225dd64a03a
|
|
Change-Id: I7440eedcf6304ff142029324450af35a5b9606f0
|
|
This seems to sometimes happen in our CI builds. This should make
it easier to at least detect that this is the case.
Change-Id: Iab59bbc10a14e350df9ef240c8a862ce8ea68794
|
|
Change-Id: Ic9e817ae15dc2b70bf56127fdfb048d23d20b4fa
|
|
|
|
|
|
|
|
Resolves: #959
|
|
License: This patch is BSD-licensed, see http://www.opensource.org/licenses/bsd-license.php
|
|
|
|
|
|
Fixes segfaults caused by clicking notifications after
the handlers had been freed.
Does not fix GrowlNotifier, which needs fixing later.
|
|
|
|
|
|
This avoids compilation problems with CLang.
|
|
|
|
|
|
We need to ask the user first.
|
|
|
|
Tweaked the sources to satisfy cppcheck.
|
|
|