Swift
summaryrefslogtreecommitdiffstats
path: root/SwifTools
AgeCommit message (Collapse)Author
2016-03-30Apply consistent #include grouping and sorting styleTobias Markmann
Changed "" style includes to <> style. Test-Information: Build with Clang 3.9.0 and ran all tests on OS X 10.11.4. Change-Id: Ic05e53f2e5dba39cc1307b116fc5f17b62ab9eb8
2016-03-15Explicitly convert between nullable and non-nullable on OS XTobias Markmann
Clang was complaining about implicit conversions between nullable and non-nullable NSString pointers. Adjusted our std::string -> NSString* conversion utilities to check for nil and return an empty std::string in that case. Replaced uses of [NSString stringWithUTF8String] with our STD2NSSTRING macro. Turned std::string <-> NSString* conversion macros into functions. Test-Information: Builds without the warning on OS X 10.11.3 and Swift runs without issues. Change-Id: I949f2f3332018391aead58ef362764f4b7955b01
2016-02-12Fix bug in OS X Notification Center backend on empty callbackTobias Markmann
Checked Growl and Snarl backends which both already do the check for empty callbacks. Test-Information: Tested clicking on an disconnect notification of Swift on OS X 10.11.3 which previously caused a crash. Now it does not crash anymore in this case. Change-Id: I7045ab22a0322cc7a50761640a9b89ba2302acef
2016-01-22Add missing Timer related cleanup codeTobias Markmann
This commit adds explicit code to stop timers which are connected to objects that are about to be deleted from memory. Test-Information: ./scons test=system passes on OS X 10.11.3. Change-Id: I139314f3a223e3dc63b78b96be17d3ae53cd3de3
2015-11-06Make methods non-virtual that are not overridden by subclassTobias Markmann
These cases have been uncovered by Clang Analyzer as they were called during some constructor. However, there is no reason for them being virtual. They are never overridden in a derived class. Test-Information: Unit tests still pass on OS X 10.10.5. Change-Id: I90b5396a0dba971d9150c35f9107733f7f4637cd
2015-11-06Fix potential memory leaks in Cocoa API usageTobias Markmann
These errors were reported by Clang Analyzer. Test-Information: Verified that behavior is still as expected and Clang Analyzer does not report the warnings anymore. Change-Id: I149d75241f7680a6d2f2b6b710dd38d1ed81a209
2015-10-30Change OS X spell checker to non-deprecated APITobias Markmann
Test-Information: Verified that there are still suggestions by comparing misspelled test phrases in Swift without this change and Swift with this change. Change-Id: Ice11af65028a96c86b1b5cc57ddad8eeda1ccf76
2015-10-30Remove Boost workaround for OS X headersTobias Markmann
Older versions of OS X define the same symbol as Boost does. The workaround, defining __ASSERT_MACROS_DEFINE_VERSIONS_WITHOUT_UNDERSCORES as 0 worked around this issue, however __ prefixed defines are considered private and cause the warning "macro name is a reserved identifier [-Wreserved-id-macro]". Test-Information: Builds and unit tests pass on OS X 10.10.5. Change-Id: I489ec201dc31fb4e43336da690c7d348a7d0d9ca
2015-10-16Only show default notifications in OS X Notification CenterTobias Markmann
Test-Information: Verified behavior on OS X 10.10.5 with two accounts, presence changes and message exchanges. Change-Id: I79b4b8a92076dfb4c2d65f91bfb2f808cf7821d5
2015-09-03Initial support for OS X Notification CenterTobias Markmann
This implements basic support for OS X Notification Center notifications with simple banner notifications showing type, contact and message/presence information. A click on the notification opens the chat view to the contact. The Notification Center backend will be used on OS X if the Growl notification backend is not used. This code requires OS X version 10.8 or later. Test-Information: Tested presence and message notifications between multiple Swift accounts and instances on OS X 10.9.5. Change-Id: I7b9e2132cab25e086e0912191562cad8f4cbae38
2014-12-15Update Copyright In SwifToolsKevin Smith
Change-Id: Ic5a0cd2d65caac21a748a9a6996a596ee80f5337
2014-10-31Fix possible NULL pointer dereference in spell checker.Tobias Markmann
Test-Information: Not manually tested. Change-Id: I1bd6d73388a95f6438606ff44011db849c024225
2014-10-20Update Boost in 3rdParty to version 1.56.0.Tobias Markmann
This updates Boost in our 3rdParty directory to version 1.56.0. Updated our update.sh script to stop on error. Changed error reporting in SwiftTools/CrashReporter.cpp to SWIFT_LOG due to missing include of <iostream> with newer Boost. Change-Id: I4b35c77de951333979a524097f35f5f83d325edc
2014-10-01Port many of Isode's local fixes upstreamKevin Smith
Includes fixes to: Build with new Visual Studio and Boost Avoid error caused when Avahi is present but Qt is not Make declaration of XMPPRosterImpl::addContact consistent with implementation Includes enhancements to: Allow user-configurable mt.exe Allow splitting openssl paths Allow disabling gconf lookup Make idn support optional Allow disabling various library detections Remove use of non-Python2.4 features in sconscripts Test-Information: Builds Change-Id: Iee91ee80291a8bdf87cc169c915e4dad1cc1055b
2014-05-18Fix spell check leaks and errorsRemko Tronçon
Change-Id: Ied0ac4abb21ef1720411fdbc61e7a687eee3afd1
2013-08-16Merge branch 'swift-2.x'Remko Tronçon
Change-Id: I36e82dfe1ec492df719bcc85e5549fb4013a6723
2013-08-16Fix Cocoa-Boost conflict.Remko Tronçon
This one only seems to appear when using CLang. Change-Id: Ib12fbeb3da0dfb54aef0613c7b9eba577654cd6a
2013-08-15Fixed warnings in SpellParser.Remko Tronçon
Change-Id: I8f44bab2f4d32e955e38e6e355824ca513b6a930
2013-08-15Getting rid of "-Wobjc-interface-ivars" warnings from clang.Tobias Markmann
Move instance variables to implementation because they are deprecated to have in the interface. Requires 'Modern' obj-c runtime. Change-Id: I60d693b7966e08ccc003818ab51ea3633c90ae17 License: This patch is BSD-licensed, see Documentation/Licenses/BSD-simplified.txt for details.
2013-08-14Build OSX spell checker only with native target.Tobias Markmann
Change-Id: Ibe2cbb2e9b0f87e073cc821a47135731a4cf7e76 License: This patch is BSD-licensed, see Documentation/Licenses/BSD-simplified.txt for details.
2013-08-01Refactor chat messages so parsing of links/emoticons happens in controllers.Kevin Smith
Change-Id: I07256f23ffbb6520f5063bdfbed9111946c46746
2013-05-17Fixed unicode path handling.Remko Tronçon
- Use boost::filesystem::path consistently for referring to files. - Use boost::filesystem streams for I/O, such that paths are always handled correctly. - Use stringToPath and pathToString for conversion between strings and boost::filesystem::path, to ensure we have consistent unicode handling across platforms and environments. The default constructor and string conversion uses platform-dependent encoding, depending on the global locale set in the application, which causes problems. So, unless you are in platform dependent code, the default constructor and string() function should not be used. When constructing paths from other paths (e.g. using operator/), also use stringToPath (instead of string arguments) if the path can contain unicode characters. Change-Id: If286bd9e71c8414afc0b24ba67e26ab7608ef6ea
2013-04-21Fix compilation when 3rdParty/ is not there.Remko Tronçon
Change-Id: I6d86bf7d8dcc750ff69ff08500c9987b3c1de43e
2013-04-05Silence a couple of warningsKevin Smith
Change-Id: I86569f168987c1b02bd4a45e569b1acffa3f8007
2013-03-30Fix HUNSPELL flags.Remko Tronçon
Change-Id: I5d728024dc52ec3279528e9f0bf4b0508c459107
2013-03-26Adding basic support for native spell checking on Mac OS X.Tobias Markmann
Change-Id: Id29313a06f052ecbaef54be0c185cd7f1df375a2 License: This patch is BSD-licensed, see Documentation/Licenses/BSD-simplified.txt for details.
2013-03-18Only attempt ten extensions before giving up on joining a roomKevin Smith
Change-Id: Ic7d26086a51e346605cb85201d55bf8cbc4249f1
2013-03-15Spell checker implementation using HunspellVlad Voicu
Change-Id: Ia15b6532edf6eef7c45bdfb273e77f65ce998f13 License: This patch is BSD-licensed, see Documentation/Licenses/BSD-simplified.txt for details
2013-03-04Qt5 support & warning fixes.Remko Tronçon
Change-Id: I62c7d5ca44c915e36c797c798294b7c34b465514
2013-01-01Fix Objective-C memory leaks.Remko Tronçon
Change-Id: I62206d3813e8873f027ff46e525a30bcb2e945c9
2012-12-31Fix more warnings.Remko Tronçon
Change-Id: I0fc27a08adb6aecd5c5775a52b7fe48570ed526a
2012-12-30Enable & fix pedantic CLang warnings.Remko Tronçon
Change-Id: I70109624b4bd7aab9ba679a3eaabc225dd64a03a
2012-12-23Fix compilation of CrashReporter.Remko Tronçon
Change-Id: I7440eedcf6304ff142029324450af35a5b9606f0
2012-12-23Assert when APPDATA or USERPROFILE is null.Remko Tronçon
This seems to sometimes happen in our CI builds. This should make it easier to at least detect that this is the case. Change-Id: Iab59bbc10a14e350df9ef240c8a862ce8ea68794
2012-11-24Enable breakpad on windows.Remko Tronçon
Change-Id: Ic9e817ae15dc2b70bf56127fdfb048d23d20b4fa
2012-09-15Added URL parser.Remko Tronçon
2012-08-17Added Breakpad support for Windows.Remko Tronçon
2012-07-17Make sure flags are consistent across different modules.Remko Tronçon
2012-04-25Don't linkify /me actions.Remko Tronçon
Resolves: #959
2012-04-17Fixing some clang warnings.Tobias Markmann
License: This patch is BSD-licensed, see http://www.opensource.org/licenses/bsd-license.php
2012-03-15Added purge to Growl.Remko Tronçon
2012-03-15Fix compilation errorKevin Smith
2012-03-14Dispose of notification callbacks once the account signs out.Kevin Smith
Fixes segfaults caused by clicking notifications after the handlers had been freed. Does not fix GrowlNotifier, which needs fixing later.
2012-03-09Fixed Growl crash.Remko Tronçon
2012-03-09Handle double growl callbacks.Remko Tronçon
2012-01-14Include intrusive_ptr after intrusive_ptr_ref functions.Remko Tronçon
This avoids compilation problems with CLang.
2011-12-24Enable "Show notifications" toggle when Growl isn't installed.Remko Tronçon
2011-12-23Updated Growl notifier to work against Growl 1.3.Remko Tronçon
2011-10-24Don't register ourself as default URI handler.Remko Tronçon
We need to ask the user first.
2011-07-11Make IdleDetector a parameter of MainController.Remko Tronçon