From 692db2695485697a62729e5a6188e033e076c20d Mon Sep 17 00:00:00 2001 From: Tobias Markmann Date: Mon, 2 Mar 2015 16:19:47 +0100 Subject: Fix a bug in successful file-transfer termination in IncomingJingleFT IncomingJingleFileTransfer::terminate already sets the finshed state for the file-transfer. Test-Information: Verified in the logs that onFinished signal is only called once. Change-Id: Ib2084e1487ded2a921f61b237cd036e1ae4cf992 diff --git a/Swiften/FileTransfer/IncomingJingleFileTransfer.cpp b/Swiften/FileTransfer/IncomingJingleFileTransfer.cpp index 7c91c6a..a0cd47c 100644 --- a/Swiften/FileTransfer/IncomingJingleFileTransfer.cpp +++ b/Swiften/FileTransfer/IncomingJingleFileTransfer.cpp @@ -176,12 +176,10 @@ void IncomingJingleFileTransfer::handleSessionTerminateReceived(boost::optional< void IncomingJingleFileTransfer::checkHashAndTerminate() { if (verifyData()) { terminate(JinglePayload::Reason::Success); - setFinishedState(FileTransfer::State::Finished, FileTransferError()); } else { SWIFT_LOG(warning) << "Hash verification failed" << std::endl; terminate(JinglePayload::Reason::MediaError); - setFinishedState(FileTransfer::State::Failed, FileTransferError()); } } -- cgit v0.10.2-6-g49f6