From 31cf91f23967a031972bb9d79890f0b2df5cbaa6 Mon Sep 17 00:00:00 2001 From: Tobias Markmann Date: Fri, 31 Oct 2014 14:20:16 +0100 Subject: Pass QString arguments by reference and not value. Test-Information: Still builds with clang (3.6.0) on OS X (10.9.5). Change-Id: I3382e2165a5f14e13ecd48277baefaf728edbbe1 diff --git a/Swift/QtUI/QtVCardWidget/QtVCardPhotoAndNameFields.cpp b/Swift/QtUI/QtVCardWidget/QtVCardPhotoAndNameFields.cpp index b29171f..46678f5 100644 --- a/Swift/QtUI/QtVCardWidget/QtVCardPhotoAndNameFields.cpp +++ b/Swift/QtUI/QtVCardWidget/QtVCardPhotoAndNameFields.cpp @@ -85,7 +85,7 @@ std::string QtVCardPhotoAndNameFields::getAvatarType() const { return ui->avatarWidget->getAvatarType(); } -void QtVCardPhotoAndNameFields::setFormattedName(const QString formattedName) { +void QtVCardPhotoAndNameFields::setFormattedName(const QString& formattedName) { ui->lineEditFN->setText(formattedName); } @@ -93,7 +93,7 @@ QString QtVCardPhotoAndNameFields::getFormattedName() const { return ui->lineEditFN->text(); } -void QtVCardPhotoAndNameFields::setNickname(const QString nickname) { +void QtVCardPhotoAndNameFields::setNickname(const QString& nickname) { ui->lineEditNICKNAME->setText(nickname); } @@ -101,7 +101,7 @@ QString QtVCardPhotoAndNameFields::getNickname() const { return ui->lineEditNICKNAME->text(); } -void QtVCardPhotoAndNameFields::setPrefix(const QString prefix) { +void QtVCardPhotoAndNameFields::setPrefix(const QString& prefix) { ui->lineEditPREFIX->setText(prefix); } @@ -109,7 +109,7 @@ QString QtVCardPhotoAndNameFields::getPrefix() const { return ui->lineEditPREFIX->text(); } -void QtVCardPhotoAndNameFields::setGivenName(const QString givenName) { +void QtVCardPhotoAndNameFields::setGivenName(const QString& givenName) { ui->lineEditGIVEN->setText(givenName); } @@ -117,7 +117,7 @@ QString QtVCardPhotoAndNameFields::getGivenName() const { return ui->lineEditGIVEN->text(); } -void QtVCardPhotoAndNameFields::setMiddleName(const QString middleName) { +void QtVCardPhotoAndNameFields::setMiddleName(const QString& middleName) { ui->lineEditMIDDLE->setText(middleName); } @@ -125,7 +125,7 @@ QString QtVCardPhotoAndNameFields::getMiddleName() const { return ui->lineEditMIDDLE->text(); } -void QtVCardPhotoAndNameFields::setFamilyName(const QString familyName) { +void QtVCardPhotoAndNameFields::setFamilyName(const QString& familyName) { ui->lineEditFAMILY->setText(familyName); } @@ -133,7 +133,7 @@ QString QtVCardPhotoAndNameFields::getFamilyName() const { return ui->lineEditFAMILY->text(); } -void QtVCardPhotoAndNameFields::setSuffix(const QString suffix) { +void QtVCardPhotoAndNameFields::setSuffix(const QString& suffix) { ui->lineEditSUFFIX->setText(suffix); } diff --git a/Swift/QtUI/QtVCardWidget/QtVCardPhotoAndNameFields.h b/Swift/QtUI/QtVCardWidget/QtVCardPhotoAndNameFields.h index 6a5ae46..ac35109 100644 --- a/Swift/QtUI/QtVCardWidget/QtVCardPhotoAndNameFields.h +++ b/Swift/QtUI/QtVCardWidget/QtVCardPhotoAndNameFields.h @@ -33,25 +33,25 @@ namespace Swift { ByteArray getAvatarData() const; std::string getAvatarType() const; - void setFormattedName(const QString formattedName); + void setFormattedName(const QString& formattedName); QString getFormattedName() const; - void setNickname(const QString nickname); + void setNickname(const QString& nickname); QString getNickname() const; - void setPrefix(const QString prefix); + void setPrefix(const QString& prefix); QString getPrefix() const; - void setGivenName(const QString givenName); + void setGivenName(const QString& givenName); QString getGivenName() const; - void setMiddleName(const QString middleName); + void setMiddleName(const QString& middleName); QString getMiddleName() const; - void setFamilyName(const QString familyName); + void setFamilyName(const QString& familyName); QString getFamilyName() const; - void setSuffix(const QString suffix); + void setSuffix(const QString& suffix); QString getSuffix() const; private: -- cgit v0.10.2-6-g49f6