From eb982771caed944f441967194df86ddbec21efde Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Remko=20Tron=C3=A7on?= Date: Fri, 7 Oct 2011 20:22:53 +0200 Subject: Initialize LibXML for multithreaded applications. diff --git a/Swiften/Parser/LibXMLParser.cpp b/Swiften/Parser/LibXMLParser.cpp index ae87f38..1590262 100644 --- a/Swiften/Parser/LibXMLParser.cpp +++ b/Swiften/Parser/LibXMLParser.cpp @@ -51,9 +51,15 @@ static void handleError(void*, const char* /*m*/, ... ) { static void handleWarning(void*, const char*, ... ) { } - +bool LibXMLParser::initialized = false; LibXMLParser::LibXMLParser(XMLParserClient* client) : XMLParser(client) { + // Initialize libXML for multithreaded applications + if (!initialized) { + xmlInitParser(); + initialized = true; + } + memset(&handler_, 0, sizeof(handler_) ); handler_.initialized = XML_SAX2_MAGIC; handler_.startElementNs = &handleStartElement; diff --git a/Swiften/Parser/LibXMLParser.h b/Swiften/Parser/LibXMLParser.h index ba61ad9..cd73637 100644 --- a/Swiften/Parser/LibXMLParser.h +++ b/Swiften/Parser/LibXMLParser.h @@ -12,6 +12,10 @@ #include namespace Swift { + /** + * Warning: This constructor is not thread-safe, because it depends on global state to + * check whether it is initialized. + */ class LibXMLParser : public XMLParser, public boost::noncopyable { public: LibXMLParser(XMLParserClient* client); @@ -20,6 +24,7 @@ namespace Swift { bool parse(const std::string& data); private: + static bool initialized; xmlSAXHandler handler_; xmlParserCtxtPtr context_; }; -- cgit v0.10.2-6-g49f6