From f5dbf49d8e5d88e8ea45a029a5436e91f2754293 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Remko=20Tron=C3=A7on?= Date: Fri, 12 Jun 2009 11:18:57 +0200 Subject: Allow IQHandlers to be passed as shared_ptr<> to IQRouter. diff --git a/Swiften/Queries/IQRouter.cpp b/Swiften/Queries/IQRouter.cpp index b474640..671566a 100644 --- a/Swiften/Queries/IQRouter.cpp +++ b/Swiften/Queries/IQRouter.cpp @@ -10,13 +10,22 @@ namespace Swift { +namespace { + void noop(IQHandler*) {} + struct PointerEquals { + PointerEquals(IQHandler* handler) : handler_(handler) {} + bool operator()(boost::shared_ptr o) { return handler_ == o.get(); } + IQHandler* handler_; + }; +} + IQRouter::IQRouter(IQChannel* channel) : channel_(channel) { channel->onIQReceived.connect(boost::bind(&IQRouter::handleIQ, this, _1)); } void IQRouter::handleIQ(boost::shared_ptr iq) { bool handled = false; - foreach(IQHandler* handler, handlers_) { + foreach(boost::shared_ptr handler, handlers_) { handled |= handler->handleIQ(iq); if (handled) { break; @@ -28,11 +37,19 @@ void IQRouter::handleIQ(boost::shared_ptr iq) { } void IQRouter::addHandler(IQHandler* handler) { + handlers_.push_back(boost::shared_ptr(handler, noop)); +} + +void IQRouter::addHandler(boost::shared_ptr handler) { handlers_.push_back(handler); } void IQRouter::removeHandler(IQHandler* handler) { - handlers_.erase(std::remove(handlers_.begin(), handlers_.end(), handler), handlers_.end()); + handlers_.erase(std::remove_if(handlers_.begin(), handlers_.end(), PointerEquals(handler)), handlers_.end()); +} + +void IQRouter::removeHandler(boost::shared_ptr handler) { + handlers_.erase(std::remove(handlers_.begin(), handlers_.end(), handler)); } void IQRouter::sendIQ(boost::shared_ptr iq) { diff --git a/Swiften/Queries/IQRouter.h b/Swiften/Queries/IQRouter.h index 2240dfb..ea80bf5 100644 --- a/Swiften/Queries/IQRouter.h +++ b/Swiften/Queries/IQRouter.h @@ -16,7 +16,9 @@ namespace Swift { IQRouter(IQChannel* channel); void addHandler(IQHandler* handler); + void addHandler(boost::shared_ptr handler); void removeHandler(IQHandler* handler); + void removeHandler(boost::shared_ptr handler); void sendIQ(boost::shared_ptr iq); String getNewIQID(); @@ -26,7 +28,7 @@ namespace Swift { private: IQChannel* channel_; - std::vector handlers_; + std::vector< boost::shared_ptr > handlers_; }; } -- cgit v0.10.2-6-g49f6