diff options
author | Alex Clayton <alex.clayton@isode.com> | 2018-03-16 14:12:08 (GMT) |
---|---|---|
committer | Alex Clayton <alex.clayton@isode.com> | 2018-03-21 09:27:34 (GMT) |
commit | 17a1e7662102eea20ddc104133e2e30a70fefdc1 (patch) | |
tree | b5d75cd518fe6924bfa4b3a5908bc95b7faf4e34 /Makefile | |
parent | bf4830bc9f51a27aba59bc5708caddb835e84789 (diff) | |
download | stroke-17a1e7662102eea20ddc104133e2e30a70fefdc1.zip stroke-17a1e7662102eea20ddc104133e2e30a70fefdc1.tar.bz2 |
Ensure JavaTimer.stop() cleans up any unresolved events
The code for stop() in JavaTimer read:
@Override
public void stop() {
timer_.stop();
//FIXME: This needs to clear any remaining events out of the EventLoop queue.
}
Where as the equivalent swiften code in BoostTimer was:
void BoostTimer::stop() {
{
std::unique_lock<std::mutex> lockTimer(timerMutex);
shuttingDown = true;
timer->cancel();
eventLoop->removeEventsFromOwner(shared_from_this());
}
}
This patch updates the java code to bring it inline with the swiften
code. In short to make sure it removes any remaining events from the
event loop when it is stopped.
Test-information:
Code Inspection.
Unit test still pass.
Ran update stroke against M-Link Console it ran ok.
Change-Id: Idf92e92d002b8404547702d1c34738165e331810
Diffstat (limited to 'Makefile')
0 files changed, 0 insertions, 0 deletions