Swiftdiff options
| author | Alan Young <consult.awy@gmail.com> | 2015-09-10 09:46:05 (GMT) |
|---|---|---|
| committer | Alan Young <consult.awy@gmail.com> | 2015-09-11 13:28:11 (GMT) |
| commit | 552a67729a5f9c85eef697dc99fbb776f92738e0 (patch) | |
| tree | 95ca5553af30b0707d3ba32897ace7518496a7fd /pmd-ruleset.xml | |
| parent | a95753ca942dd6bfe89a9ce6287909a69bf93e96 (diff) | |
| download | stroke-552a67729a5f9c85eef697dc99fbb776f92738e0.zip stroke-552a67729a5f9c85eef697dc99fbb776f92738e0.tar.bz2 | |
Improve efficiency of JavaConnection reads.
Given that doRead() ends up populating a SafeByteArray as part of the
result is is more efficient to pass an empty SafeByteArray to doRead()
and push each chunk of data read directly to the it rather than use an
intermediate ByteArrayOutputStream. SafeByteArray.getData() will do any
concatenation necessary.
It is unnecessarily inefficient to use a class instance to return the
connection status from doRead. Remove JavaConnection.ReadResult.
Change-Id: I6c8dc000d9030d3929c71444eb5b489df93f1987
Diffstat (limited to 'pmd-ruleset.xml')
0 files changed, 0 insertions, 0 deletions