summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorKevin Smith <git@kismith.co.uk>2012-10-18 16:12:14 (GMT)
committerKevin Smith <git@kismith.co.uk>2012-10-18 16:12:14 (GMT)
commitb929d80743dca78406f0fb338175c90590a4ed67 (patch)
treecc72c6175ed8dfe1151d94273ea4993af76ac7de /src/com/isode/stroke/client
parent10d5bd33ce017971a25816606c06f0c73746aed8 (diff)
downloadstroke-b929d80743dca78406f0fb338175c90590a4ed67.zip
stroke-b929d80743dca78406f0fb338175c90590a4ed67.tar.bz2
And more cleanups
Change-Id: I862e11dc293ce84e0311f1ad470293e07735aeaf
Diffstat (limited to 'src/com/isode/stroke/client')
-rw-r--r--src/com/isode/stroke/client/Client.java6
-rw-r--r--src/com/isode/stroke/client/ClientSession.java16
2 files changed, 10 insertions, 12 deletions
diff --git a/src/com/isode/stroke/client/Client.java b/src/com/isode/stroke/client/Client.java
index 106ff70..a4ef619 100644
--- a/src/com/isode/stroke/client/Client.java
+++ b/src/com/isode/stroke/client/Client.java
@@ -27,10 +27,8 @@ public class Client extends CoreClient {
private final MUCManager mucManager;
private final MUCRegistry mucRegistry;
- //NOPMD, this is not better as a local variable
- private final DirectedPresenceSender directedPresenceSender;
- //NOPMD, this is not better as a local variable
- private final StanzaChannelPresenceSender stanzaChannelPresenceSender;
+ private final DirectedPresenceSender directedPresenceSender; //NOPMD, this is not better as a local variable
+ private final StanzaChannelPresenceSender stanzaChannelPresenceSender; //NOPMD, this is not better as a local variable
private final SoftwareVersionResponder softwareVersionResponder;
/**
diff --git a/src/com/isode/stroke/client/ClientSession.java b/src/com/isode/stroke/client/ClientSession.java
index 0327e89..f6082b7 100644
--- a/src/com/isode/stroke/client/ClientSession.java
+++ b/src/com/isode/stroke/client/ClientSession.java
@@ -189,17 +189,17 @@ public class ClientSession {
public void start() {
streamStreamStartReceivedConnection = stream.onStreamStartReceived.connect(new Slot1<ProtocolHeader>(){
- public void call(ProtocolHeader p1) {
+ public void call(final ProtocolHeader p1) {
handleStreamStart(p1);
}
});
streamElementReceivedConnection = stream.onElementReceived.connect(new Slot1<Element>(){
- public void call(Element p1) {
+ public void call(final Element p1) {
handleElement(p1);
}
});
streamClosedConnection = stream.onClosed.connect(new Slot1<SessionStream.Error>(){
- public void call(SessionStream.Error p1) {
+ public void call(final SessionStream.Error p1) {
handleStreamClosed(p1);
}
});
@@ -227,7 +227,7 @@ public class ClientSession {
}
}
- private void handleStreamStart(final ProtocolHeader header) {
+ private void handleStreamStart(final ProtocolHeader header) { //NOPMD, I'm not removing header from the API
if (!checkState(State.WaitingForStreamStart)) {
return;
}
@@ -405,14 +405,14 @@ public class ClientSession {
});
stanzaAckOnAckedConnection_ = stanzaAckRequester_.onStanzaAcked.connect(new Slot1<Stanza>() {
- public void call(Stanza p1) {
+ public void call(final Stanza p1) {
handleStanzaAcked(p1);
}
});
stanzaAckResponder_ = new StanzaAckResponder();
stanzaResponderAckConnection_ = stanzaAckResponder_.onAck.connect(new Slot1<Long>() {
- public void call(Long p1) {
+ public void call(final Long p1) {
ack(p1);
}
});
@@ -471,7 +471,7 @@ public class ClientSession {
private void continueSessionInitialization() {
if (needResourceBind) {
state = State.BindingResource;
- ResourceBind resourceBind = new ResourceBind();
+ final ResourceBind resourceBind = new ResourceBind();
if (localJID.getResource().length() != 0) {
resourceBind.setResource(localJID.getResource());
}
@@ -519,7 +519,7 @@ public class ClientSession {
checkTrustOrFinish(certificate, verificationError);
}
else {
- ServerIdentityVerifier identityVerifier = new ServerIdentityVerifier(localJID);
+ final ServerIdentityVerifier identityVerifier = new ServerIdentityVerifier(localJID);
if (identityVerifier.certificateVerifies(certificate)) {
continueAfterTLSEncrypted();
}