summaryrefslogtreecommitdiffstats
path: root/test
diff options
context:
space:
mode:
authorNick Hudson <nick.hudson@isode.com>2013-05-31 10:55:55 (GMT)
committerNick Hudson <nick.hudson@isode.com>2013-05-31 11:15:23 (GMT)
commit7d7ecdbb01daa051472bf40e269b78c4faf7b34e (patch)
treebf75e02f6118f2882a3c6d0e53a34307921b6e7c /test
parent3335b1dfa9b429d90088184f58daff01e84432f2 (diff)
downloadstroke-7d7ecdbb01daa051472bf40e269b78c4faf7b34e.zip
stroke-7d7ecdbb01daa051472bf40e269b78c4faf7b34e.tar.bz2
Workaround for some misbehaving SSLEngine implementations
Some implementations of SSLEngine (notably Apache harmony used in Android) never return the FINSHED status from calls to wrap or unwrap, causing the TLSLayer to never emit its completed signal. With this change, we treat a return of NOT_HANDSHAKING as equivalent to FINISHED. The NOT_HANDSHAKING will never happen before handshaking has finished, because the status during handshaking should always be NEED_WRAP, NEED_UNWRAP, or NEED_TASK. Test-information: Tested with OracleJDK and OpenJDK using Isode M-Link Console to ensure that the behaviour when negotiating TLS is unchanged (debugging shows that in these cases it always sees the FINISHED status). Tested on Android. Without this patch TLS handshakes don't complete; with the patch, they do. Change-Id: Ied2989cb2a3458dc6b1d2584dcc6c722d18e1355 Signed-off-by: Nick Hudson <nick.hudson@isode.com>
Diffstat (limited to 'test')
0 files changed, 0 insertions, 0 deletions