diff options
| -rw-r--r-- | src/com/isode/stroke/jid/JID.java | 13 | ||||
| -rw-r--r-- | test/com/isode/stroke/jid/JIDTest.java | 10 |
2 files changed, 15 insertions, 8 deletions
diff --git a/src/com/isode/stroke/jid/JID.java b/src/com/isode/stroke/jid/JID.java index 59eef52..8b62ca1 100644 --- a/src/com/isode/stroke/jid/JID.java +++ b/src/com/isode/stroke/jid/JID.java | |||
| @@ -1,5 +1,5 @@ | |||
| 1 | /* | 1 | /* |
| 2 | * Copyright (c) 2010-2012, Isode Limited, London, England. | 2 | * Copyright (c) 2010-2016, Isode Limited, London, England. |
| 3 | * All rights reserved. | 3 | * All rights reserved. |
| 4 | */ | 4 | */ |
| 5 | /* | 5 | /* |
| @@ -14,13 +14,13 @@ | |||
| 14 | 14 | ||
| 15 | package com.isode.stroke.jid; | 15 | package com.isode.stroke.jid; |
| 16 | 16 | ||
| 17 | import com.isode.stroke.idn.ICUConverter; | ||
| 18 | import com.isode.stroke.idn.IDNConverter; | ||
| 19 | import com.ibm.icu.text.StringPrepParseException; | ||
| 20 | import com.isode.stroke.base.NotNull; | ||
| 21 | import java.util.Arrays; | 17 | import java.util.Arrays; |
| 22 | import java.util.List; | 18 | import java.util.List; |
| 23 | 19 | ||
| 20 | import com.isode.stroke.base.NotNull; | ||
| 21 | import com.isode.stroke.idn.ICUConverter; | ||
| 22 | import com.isode.stroke.idn.IDNConverter; | ||
| 23 | |||
| 24 | /** | 24 | /** |
| 25 | * JID helper. | 25 | * JID helper. |
| 26 | * | 26 | * |
| @@ -147,6 +147,9 @@ public class JID implements Comparable<JID> { | |||
| 147 | NotNull.exceptIfNull(domain, "domain"); | 147 | NotNull.exceptIfNull(domain, "domain"); |
| 148 | valid_ = true; | 148 | valid_ = true; |
| 149 | hasResource_ = (resource != null); | 149 | hasResource_ = (resource != null); |
| 150 | if (hasResource_ && resource.isEmpty()) { | ||
| 151 | valid_ = false; | ||
| 152 | } | ||
| 150 | nameprepAndSetComponents(node, domain, resource); | 153 | nameprepAndSetComponents(node, domain, resource); |
| 151 | } | 154 | } |
| 152 | 155 | ||
diff --git a/test/com/isode/stroke/jid/JIDTest.java b/test/com/isode/stroke/jid/JIDTest.java index 96de429..69bee05 100644 --- a/test/com/isode/stroke/jid/JIDTest.java +++ b/test/com/isode/stroke/jid/JIDTest.java | |||
| @@ -12,12 +12,10 @@ | |||
| 12 | package com.isode.stroke.jid; | 12 | package com.isode.stroke.jid; |
| 13 | 13 | ||
| 14 | import static org.junit.Assert.assertEquals; | 14 | import static org.junit.Assert.assertEquals; |
| 15 | import static org.junit.Assert.assertNotNull; | ||
| 16 | import static org.junit.Assert.assertNull; | ||
| 17 | import static org.junit.Assert.assertFalse; | 15 | import static org.junit.Assert.assertFalse; |
| 18 | import static org.junit.Assert.assertTrue; | 16 | import static org.junit.Assert.assertTrue; |
| 17 | |||
| 19 | import org.junit.Test; | 18 | import org.junit.Test; |
| 20 | import com.isode.stroke.jid.JID; | ||
| 21 | 19 | ||
| 22 | public class JIDTest { | 20 | public class JIDTest { |
| 23 | 21 | ||
| @@ -155,6 +153,12 @@ public class JIDTest { | |||
| 155 | 153 | ||
| 156 | assertFalse(testling.isValid()); | 154 | assertFalse(testling.isValid()); |
| 157 | } | 155 | } |
| 156 | |||
| 157 | @Test | ||
| 158 | public void testConstructorWithStrings_EmptyResource() { | ||
| 159 | JID testling = new JID("foo","bar",""); | ||
| 160 | assertFalse(testling.isValid()); | ||
| 161 | } | ||
| 158 | 162 | ||
| 159 | 163 | ||
| 160 | @Test | 164 | @Test |
Swift