summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorRemko Tronçon <git@el-tramo.be>2012-03-09 11:22:00 (GMT)
committerRemko Tronçon <git@el-tramo.be>2012-03-09 11:22:00 (GMT)
commitc83da56f6c93db3dc8040be1137fd40a08bf4132 (patch)
treec4141dc2f333a6517a5dbc70c04c013878bee1bf /SwifTools/Notifier
parent0833f7da453db9cd0fc3a78c793e7532663ab86b (diff)
downloadswift-c83da56f6c93db3dc8040be1137fd40a08bf4132.zip
swift-c83da56f6c93db3dc8040be1137fd40a08bf4132.tar.bz2
Handle double growl callbacks.
Diffstat (limited to 'SwifTools/Notifier')
-rw-r--r--SwifTools/Notifier/GrowlNotifier.h1
-rw-r--r--SwifTools/Notifier/GrowlNotifier.mm28
2 files changed, 24 insertions, 5 deletions
diff --git a/SwifTools/Notifier/GrowlNotifier.h b/SwifTools/Notifier/GrowlNotifier.h
index cb0d089..f4e6803 100644
--- a/SwifTools/Notifier/GrowlNotifier.h
+++ b/SwifTools/Notifier/GrowlNotifier.h
@@ -20,6 +20,7 @@ namespace Swift {
class GrowlNotifier : public Notifier {
public:
GrowlNotifier(const std::string& name);
+ ~GrowlNotifier();
virtual void showMessage(Type type, const std::string& subject, const std::string& description, const boost::filesystem::path& picture, boost::function<void()> callback);
virtual bool isExternallyConfigured() const;
diff --git a/SwifTools/Notifier/GrowlNotifier.mm b/SwifTools/Notifier/GrowlNotifier.mm
index cb4790e..31eabd3 100644
--- a/SwifTools/Notifier/GrowlNotifier.mm
+++ b/SwifTools/Notifier/GrowlNotifier.mm
@@ -7,6 +7,7 @@
#include <SwifTools/Notifier/GrowlNotifier.h>
#include <boost/smart_ptr/make_shared.hpp>
+#include <set>
#include <SwifTools/Notifier/GrowlNotifierDelegate.h>
#include <SwifTools/Cocoa/CocoaUtil.h>
@@ -27,6 +28,7 @@ namespace Swift {
class GrowlNotifier::Private {
public:
+ std::set<Context*> pendingNotifications;
boost::intrusive_ptr<GrowlNotifierDelegate> delegate;
};
@@ -55,12 +57,23 @@ GrowlNotifier::GrowlNotifier(const std::string& name) {
[GrowlApplicationBridge setGrowlDelegate: p->delegate.get()];
}
+GrowlNotifier::~GrowlNotifier() {
+ [GrowlApplicationBridge setGrowlDelegate: nil];
+ foreach (Context* context, p->pendingNotifications) {
+ delete context;
+ }
+ p->pendingNotifications.clear();
+}
+
void GrowlNotifier::showMessage(Type type, const std::string& subject, const std::string& description, const boost::filesystem::path& picturePath, boost::function<void()> callback) {
ByteArray picture;
readByteArrayFromFile(picture, picturePath.string());
Context* context = new Context(callback);
-
+ // Growl sometimes sends timeout notifications twice for the same message. We therefore need
+ // to keep track of which ones have already been processed.
+ p->pendingNotifications.insert(context);
+
[GrowlApplicationBridge
notifyWithTitle: STD2NSSTRING(subject)
description: STD2NSSTRING(description)
@@ -73,14 +86,19 @@ void GrowlNotifier::showMessage(Type type, const std::string& subject, const std
void GrowlNotifier::handleNotificationClicked(void* rawData) {
Context* context = *(Context**) [((NSData*) rawData) bytes];
- if (!context->callback->empty()) {
- (*context->callback)();
+ if (p->pendingNotifications.erase(context) > 0) {
+ if (!context->callback->empty()) {
+ (*context->callback)();
+ }
+ delete context;
}
- delete context;
}
void GrowlNotifier::handleNotificationTimedOut(void* rawData) {
- delete *(Context**) [((NSData*) rawData) bytes];
+ Context* context = *(Context**) [((NSData*) rawData) bytes];
+ if (p->pendingNotifications.erase(context) > 0) {
+ delete context;
+ }
}
bool GrowlNotifier::isExternallyConfigured() const {