Allow affiliation editing in MUCs.

Resolves: #986 Resolves: #988
author: Kevin Smith <git@kismith.co.uk> 2011-10-07 14:09:27 (GMT)
committer: Kevin Smith <git@kismith.co.uk> 2011-10-07 14:11:23 (GMT)
commit: b2f58c4f3eb93e3a32062670df5eb6682aed273a (patch)
tree: 737884f5e3e826407466290cf7c324c4f0069dd0 /Swift/QtUI
parent: 7f7b05d8d242a9b73b7d9f971779c6af19980f76 (diff)
download: swift-b2f58c4f3eb93e3a32062670df5eb6682aed273a.zip
swift-b2f58c4f3eb93e3a32062670df5eb6682aed273a.tar.bz2
7 files changed, 306 insertions, 13 deletions
diff --git a/Swift/QtUI/QtAffiliationEditor.cpp b/Swift/QtUI/QtAffiliationEditor.cpp
new file mode 100644
index 0000000..ed03c23
--- /dev/null
+++ b/Swift/QtUI/QtAffiliationEditor.cpp
@@ -0,0 +1,79 @@
+/*
+ * Copyright (c) 2011 Kevin Smith
+ * Licensed under the GNU General Public License v3.
+ * See Documentation/Licenses/GPLv3.txt for more information.
+ */
+
+#include "QtAffiliationEditor.h"
+
+#include <QListWidgetItem>
+#include <QInputDialog>
+
+#include "QtSwiftUtil.h"
+
+
+namespace Swift {
+QtAffiliationEditor::QtAffiliationEditor(QWidget* parent) : QDialog(parent){
+	ui_.setupUi(this);
+	setAttribute(Qt::WA_DeleteOnClose);
+	connect(ui_.affiliation, SIGNAL(currentIndexChanged(int)), this, SLOT(handleCurrentIndexChanged(int)));
+	connect(ui_.addJID, SIGNAL(clicked()), this, SLOT(handleAddClicked()));
+	connect(ui_.removeJID, SIGNAL(clicked()), this, SLOT(handleRemoveClicked()));
+}
+
+QtAffiliationEditor::~QtAffiliationEditor() {
+	
+}
+
+void QtAffiliationEditor::setAffiliations(MUCOccupant::Affiliation affiliation, const std::vector<JID>& jids) {
+	affiliations_[affiliation] = jids;
+	if (affiliationFromIndex(ui_.affiliation->currentIndex()) == affiliation) {
+		handleCurrentIndexChanged(ui_.affiliation->currentIndex());
+	}
+}
+
+const std::vector<std::pair<MUCOccupant::Affiliation, JID> >& QtAffiliationEditor::getChanges() const {
+	return changes_;
+}
+
+void QtAffiliationEditor::handleCurrentIndexChanged(int index) {
+	ui_.list->clear();
+	foreach (const JID& jid, affiliations_[affiliationFromIndex(index)]) {
+		ui_.list->addItem(P2QSTRING(jid.toString()));
+	}
+}
+
+void QtAffiliationEditor::handleAddClicked() {
+	bool ok = false;
+	JID jid = JID(Q2PSTRING(QInputDialog::getText(this, tr("Add User"), tr("Added User's Address:"), QLineEdit::Normal, "", &ok)));
+	if (ok && jid.isValid()) {
+		//FIXME: validation
+		MUCOccupant::Affiliation affiliation = affiliationFromIndex(ui_.affiliation->currentIndex());
+		changes_.push_back(ChangePair(affiliation, jid));
+		ui_.list->addItem(P2QSTRING(jid.toString()));
+		affiliations_[affiliation].push_back(jid);
+	}
+}
+
+void QtAffiliationEditor::handleRemoveClicked() {
+	QListWidgetItem* item = ui_.list->currentItem();
+	if (item) {
+		JID jid(Q2PSTRING(item->text()));
+		changes_.push_back(ChangePair(MUCOccupant::NoAffiliation, jid));
+		std::vector<JID>& jids = affiliations_[affiliationFromIndex(ui_.affiliation->currentIndex())];
+		jids.erase(std::remove(jids.begin(), jids.end(), jid), jids.end());
+		handleCurrentIndexChanged(ui_.affiliation->currentIndex());
+	}
+}
+
+MUCOccupant::Affiliation QtAffiliationEditor::affiliationFromIndex(int affiliation) {
+	switch (affiliation) {
+		case 0: return MUCOccupant::Owner;
+		case 1: return MUCOccupant::Admin;
+		case 2: return MUCOccupant::Member;
+		case 3: return MUCOccupant::Outcast;
+		default: return MUCOccupant::Outcast;
+	}
+}
+
+}
+\ No newline at end of file
diff --git a/Swift/QtUI/QtAffiliationEditor.h b/Swift/QtUI/QtAffiliationEditor.h
new file mode 100644
index 0000000..913b2cc
--- /dev/null
+++ b/Swift/QtUI/QtAffiliationEditor.h
@@ -0,0 +1,37 @@
+/*
+ * Copyright (c) 2011 Kevin Smith
+ * Licensed under the GNU General Public License v3.
+ * See Documentation/Licenses/GPLv3.txt for more information.
+ */
+
+#pragma once
+
+#include <vector>
+#include <map>
+
+#include <QDialog>
+#include <Swift/QtUI/ui_QtAffiliationEditor.h>
+
+#include <Swiften/JID/JID.h>
+#include <Swiften/Elements/MUCOccupant.h>
+
+namespace Swift {
+	class QtAffiliationEditor : public QDialog {
+		Q_OBJECT
+		public:
+			QtAffiliationEditor(QWidget* parent = NULL);
+			~QtAffiliationEditor();
+			void setAffiliations(MUCOccupant::Affiliation, const std::vector<JID>& jids);
+			const std::vector<std::pair<MUCOccupant::Affiliation, JID> >& getChanges() const;
+		private slots:
+			void handleCurrentIndexChanged(int);
+			void handleAddClicked();
+			void handleRemoveClicked();
+		private:
+			typedef std::pair<MUCOccupant::Affiliation, JID> ChangePair;
+			MUCOccupant::Affiliation affiliationFromIndex(int affiliation);
+			Ui::QtAffiliationEditor ui_;
+			std::map<MUCOccupant::Affiliation, std::vector<JID> > affiliations_;
+			std::vector<ChangePair> changes_;
+	};
+}
+\ No newline at end of file
diff --git a/Swift/QtUI/QtAffiliationEditor.ui b/Swift/QtUI/QtAffiliationEditor.ui
new file mode 100644
index 0000000..1447884
--- /dev/null
+++ b/Swift/QtUI/QtAffiliationEditor.ui
@@ -0,0 +1,146 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<ui version="4.0">
+ <class>QtAffiliationEditor</class>
+ <widget class="QDialog" name="QtAffiliationEditor">
+  <property name="geometry">
+   <rect>
+    <x>0</x>
+    <y>0</y>
+    <width>575</width>
+    <height>466</height>
+   </rect>
+  </property>
+  <property name="windowTitle">
+   <string>Dialog</string>
+  </property>
+  <layout class="QVBoxLayout" name="verticalLayout_2">
+   <item>
+    <widget class="QGroupBox" name="groupBox">
+     <property name="title">
+      <string/>
+     </property>
+     <layout class="QVBoxLayout" name="verticalLayout_3">
+      <item>
+       <layout class="QHBoxLayout" name="horizontalLayout">
+        <item>
+         <widget class="QLabel" name="label">
+          <property name="text">
+           <string>Affiliation:</string>
+          </property>
+         </widget>
+        </item>
+        <item>
+         <widget class="QComboBox" name="affiliation">
+          <item>
+           <property name="text">
+            <string>Owner</string>
+           </property>
+          </item>
+          <item>
+           <property name="text">
+            <string>Administrator</string>
+           </property>
+          </item>
+          <item>
+           <property name="text">
+            <string>Member</string>
+           </property>
+          </item>
+          <item>
+           <property name="text">
+            <string>Outcast (Banned)</string>
+           </property>
+          </item>
+         </widget>
+        </item>
+       </layout>
+      </item>
+      <item>
+       <layout class="QHBoxLayout" name="horizontalLayout_2">
+        <item>
+         <widget class="QListWidget" name="list"/>
+        </item>
+        <item>
+         <layout class="QVBoxLayout" name="verticalLayout">
+          <item>
+           <widget class="QPushButton" name="addJID">
+            <property name="text">
+             <string>Add User</string>
+            </property>
+           </widget>
+          </item>
+          <item>
+           <widget class="QPushButton" name="removeJID">
+            <property name="text">
+             <string>Remove User</string>
+            </property>
+           </widget>
+          </item>
+          <item>
+           <spacer name="verticalSpacer">
+            <property name="orientation">
+             <enum>Qt::Vertical</enum>
+            </property>
+            <property name="sizeHint" stdset="0">
+             <size>
+              <width>20</width>
+              <height>40</height>
+             </size>
+            </property>
+           </spacer>
+          </item>
+         </layout>
+        </item>
+       </layout>
+      </item>
+     </layout>
+    </widget>
+   </item>
+   <item>
+    <widget class="QDialogButtonBox" name="buttonBox">
+     <property name="orientation">
+      <enum>Qt::Horizontal</enum>
+     </property>
+     <property name="standardButtons">
+      <set>QDialogButtonBox::Cancel|QDialogButtonBox::Ok</set>
+     </property>
+    </widget>
+   </item>
+  </layout>
+ </widget>
+ <resources/>
+ <connections>
+  <connection>
+   <sender>buttonBox</sender>
+   <signal>accepted()</signal>
+   <receiver>QtAffiliationEditor</receiver>
+   <slot>accept()</slot>
+   <hints>
+    <hint type="sourcelabel">
+     <x>224</x>
+     <y>444</y>
+    </hint>
+    <hint type="destinationlabel">
+     <x>157</x>
+     <y>274</y>
+    </hint>
+   </hints>
+  </connection>
+  <connection>
+   <sender>buttonBox</sender>
+   <signal>rejected()</signal>
+   <receiver>QtAffiliationEditor</receiver>
+   <slot>reject()</slot>
+   <hints>
+    <hint type="sourcelabel">
+     <x>292</x>
+     <y>450</y>
+    </hint>
+    <hint type="destinationlabel">
+     <x>286</x>
+     <y>274</y>
+    </hint>
+   </hints>
+  </connection>
+ </connections>
+</ui>
diff --git a/Swift/QtUI/QtChatWindow.cpp b/Swift/QtUI/QtChatWindow.cpp
index 7e47f4d..0635496 100644
--- a/Swift/QtUI/QtChatWindow.cpp
+++ b/Swift/QtUI/QtChatWindow.cpp
@@ -53,6 +53,7 @@ QtChatWindow::QtChatWindow(const QString &contact, QtChatTheme* theme, UIEventSt
 	unreadCount_ = 0;
 	inputEnabled_ = true;
 	completer_ = NULL;
+	affiliationEditor_ = NULL;
 	theme_ = theme;
 	isCorrection_ = false;
 	correctionEnabled_ = Maybe;
@@ -165,8 +166,8 @@ QtChatWindow::QtChatWindow(const QString &contact, QtChatTheme* theme, UIEventSt
 
 QtChatWindow::~QtChatWindow() {
 	delete fileTransferJS;
-	if (mucConfigurationWindow) {
-		delete mucConfigurationWindow.data();
+	if (mucConfigurationWindow_) {
+		delete mucConfigurationWindow_.data();
 	}
 }
 
@@ -341,7 +342,7 @@ void QtChatWindow::setCorrectionEnabled(Tristate enabled) {
 
 SecurityLabelsCatalog::Item QtChatWindow::getSelectedSecurityLabel() {
 	assert(labelsWidget_->isEnabled());
-	assert(labelsWidget_->currentIndex() >= 0 && labelsWidget_->currentIndex() < availableLabels_.size());
+	assert(labelsWidget_->currentIndex() >= 0 && static_cast<size_t>(labelsWidget_->currentIndex()) < availableLabels_.size());
 	return availableLabels_[labelsWidget_->currentIndex()];
 }
 
@@ -371,8 +372,13 @@ void QtChatWindow::qAppFocusChanged(QWidget* /*old*/, QWidget* /*now*/) {
 
 void QtChatWindow::setInputEnabled(bool enabled) {
 	inputEnabled_ = enabled;
-	if (!enabled && mucConfigurationWindow) {
-		delete mucConfigurationWindow.data();
+	if (!enabled) {
+		if (mucConfigurationWindow_) {
+			delete mucConfigurationWindow_.data();
+		}
+		if (affiliationEditor_) {
+			delete affiliationEditor_.data();
+		}
 	}
 }
 
@@ -704,6 +710,7 @@ void QtChatWindow::handleActionButtonClicked() {
 	QMenu contextMenu;
 	QAction* changeSubject = contextMenu.addAction(tr("Change subject"));
 	QAction* configure = contextMenu.addAction(tr("Configure room"));
+	QAction* affiliations = contextMenu.addAction(tr("Edit affiliations"));
 	QAction* destroy = contextMenu.addAction(tr("Destroy room"));
 	QAction* invite = contextMenu.addAction(tr("Invite person to this room"));
 	QAction* result = contextMenu.exec(QCursor::pos());
@@ -717,6 +724,14 @@ void QtChatWindow::handleActionButtonClicked() {
 	else if (result == configure) {
 		onConfigureRequest(Form::ref());
 	}
+	else if (result == affiliations) {
+		if (!affiliationEditor_) {
+			onGetAffiliationsRequest();
+			affiliationEditor_ = new QtAffiliationEditor(this);
+			connect(affiliationEditor_, SIGNAL(accepted()), this, SLOT(handleAffiliationEditorAccepted()));
+		}
+		affiliationEditor_->show();
+	}
 	else if (result == destroy) {
 		onDestroyRequest();
 	}
@@ -729,13 +744,22 @@ void QtChatWindow::handleActionButtonClicked() {
 	}
 }
 
+void QtChatWindow::handleAffiliationEditorAccepted() {
+	onChangeAffiliationsRequest(affiliationEditor_->getChanges());
+}
+
+void QtChatWindow::setAffiliations(MUCOccupant::Affiliation affiliation, const std::vector<JID>& jids) {
+	if (!affiliationEditor_) return;
+	affiliationEditor_->setAffiliations(affiliation, jids);
+}
+
 void QtChatWindow::showRoomConfigurationForm(Form::ref form) {
-	if (mucConfigurationWindow) {
-		delete mucConfigurationWindow.data();
+	if (mucConfigurationWindow_) {
+		delete mucConfigurationWindow_.data();
 	}
-	mucConfigurationWindow = new QtMUCConfigurationWindow(form);
-	mucConfigurationWindow->onFormComplete.connect(boost::bind(boost::ref(onConfigureRequest), _1));
-	mucConfigurationWindow->onFormCancelled.connect(boost::bind(boost::ref(onConfigurationFormCancelled)));
+	mucConfigurationWindow_ = new QtMUCConfigurationWindow(form);
+	mucConfigurationWindow_->onFormComplete.connect(boost::bind(boost::ref(onConfigureRequest), _1));
+	mucConfigurationWindow_->onFormCancelled.connect(boost::bind(boost::ref(onConfigurationFormCancelled)));
 }
 
 void QtChatWindow::addMUCInvitation(const JID& jid, const std::string& reason, const std::string& password) {
diff --git a/Swift/QtUI/QtChatWindow.h b/Swift/QtUI/QtChatWindow.h
index 8dfe767..e546f12 100644
--- a/Swift/QtUI/QtChatWindow.h
+++ b/Swift/QtUI/QtChatWindow.h
@@ -8,6 +8,7 @@
 
 #include <Swift/Controllers/UIInterfaces/ChatWindow.h>
 #include <Swift/QtUI/QtMUCConfigurationWindow.h>
+#include <Swift/QtUI/QtAffiliationEditor.h>
 
 #include <QtTabbable.h>
 
@@ -73,6 +74,7 @@ namespace Swift {
 			void setSubject(const std::string& subject);
 			void showRoomConfigurationForm(Form::ref);
 			void addMUCInvitation(const JID& jid, const std::string& reason, const std::string& password);
+			void setAffiliations(MUCOccupant::Affiliation, const std::vector<JID>&);
 
 		public slots:
 			void handleChangeSplitterState(QByteArray state);
@@ -111,6 +113,7 @@ namespace Swift {
 			void handleFileTransferSetDescription(QString id);
 			void handleFileTransferStart(QString id);
 			void handleFileTransferAccept(QString id, QString filename);
+			void handleAffiliationEditorAccepted();
 
 		private:
 			void updateTitleWithUnreadCount();
@@ -153,6 +156,7 @@ namespace Swift {
 			QString alertStyleSheet_;
 			std::map<QString, QString> descriptions;
 			QtFileTransferJSBridge* fileTransferJS;
-			QPointer<QtMUCConfigurationWindow> mucConfigurationWindow;
+			QPointer<QtMUCConfigurationWindow> mucConfigurationWindow_;
+			QPointer<QtAffiliationEditor> affiliationEditor_;
 	};
 }
diff --git a/Swift/QtUI/Roster/QtOccupantListWidget.cpp b/Swift/QtUI/Roster/QtOccupantListWidget.cpp
index 3ee0b7d..3f66585 100644
--- a/Swift/QtUI/Roster/QtOccupantListWidget.cpp
+++ b/Swift/QtUI/Roster/QtOccupantListWidget.cpp
@@ -45,6 +45,7 @@ void QtOccupantListWidget::contextMenuEvent(QContextMenuEvent* event) {
 			QString text = "Error: missing string";
 			switch (availableAction) {
 				case ChatWindow::Kick: text = tr("Kick user"); break;
+				case ChatWindow::Ban: text = tr("Kick and ban user"); break;
 				case ChatWindow::MakeModerator: text = tr("Make moderator"); break;
 				case ChatWindow::MakeParticipant: text = tr("Make participant"); break;
 				case ChatWindow::MakeVisitor: text = tr("Remove voice"); break;
diff --git a/Swift/QtUI/SConscript b/Swift/QtUI/SConscript
index 82e4490..71dc59f 100644
--- a/Swift/QtUI/SConscript
+++ b/Swift/QtUI/SConscript
@@ -84,8 +84,8 @@ sources = [
     "QtTabWidget.cpp",
     "QtTextEdit.cpp",
     "QtXMLConsoleWidget.cpp",
-	"QtFileTransferListWidget.cpp",
-	"QtFileTransferListItemModel.cpp",
+    "QtFileTransferListWidget.cpp",
+    "QtFileTransferListItemModel.cpp",
     "QtAdHocCommandWindow.cpp",
     "QtUtilities.cpp",
     "QtBookmarkDetailWindow.cpp",
@@ -137,6 +137,7 @@ sources = [
     "qrc_Swift.cc",
     "QtFileTransferJSBridge.cpp",
     "QtMUCConfigurationWindow.cpp",
+    "QtAffiliationEditor.cpp",
   ]
 
 myenv["SWIFT_VERSION"] = Version.getBuildVersion(env.Dir("#").abspath, "swift")
@@ -173,6 +174,7 @@ myenv.Uic4("UserSearch/QtUserSearchFirstPage.ui")
 myenv.Uic4("UserSearch/QtUserSearchFieldsPage.ui")
 myenv.Uic4("UserSearch/QtUserSearchResultsPage.ui")
 myenv.Uic4("QtBookmarkDetailWindow.ui")
+myenv.Uic4("QtAffiliationEditor.ui")
 myenv.Uic4("QtJoinMUCWindow.ui")
 myenv.Qrc("DefaultTheme.qrc")
 myenv.Qrc("Swift.qrc")
author	Kevin Smith <git@kismith.co.uk>	2011-10-07 14:09:27 (GMT)
committer	Kevin Smith <git@kismith.co.uk>	2011-10-07 14:11:23 (GMT)
commit	b2f58c4f3eb93e3a32062670df5eb6682aed273a (patch)
tree	737884f5e3e826407466290cf7c324c4f0069dd0 /Swift/QtUI
parent	7f7b05d8d242a9b73b7d9f971779c6af19980f76 (diff)
download	swift-b2f58c4f3eb93e3a32062670df5eb6682aed273a.zip swift-b2f58c4f3eb93e3a32062670df5eb6682aed273a.tar.bz2