Swiftdiff options
| author | Kevin Smith <git@kismith.co.uk> | 2016-01-21 18:15:50 (GMT) |
|---|---|---|
| committer | Kevin Smith <git@kismith.co.uk> | 2016-01-21 18:24:25 (GMT) |
| commit | 8480bdda831e4d18c1979f40badb1bc985e78865 (patch) | |
| tree | 10c68a327666fd7e352be3ce54865e50f77a161b /Swiften/FileTransfer/OutgoingFileTransferManager.cpp | |
| parent | f377207cb896679b4eab9f6773d9d071700852ad (diff) | |
| download | swift-8480bdda831e4d18c1979f40badb1bc985e78865.zip swift-8480bdda831e4d18c1979f40badb1bc985e78865.tar.bz2 | |
Ensure that BoostTimers can't fire after stop()
Code review makes me think that if the timer fires at the same time as
stop() is called, it would be possible for the clearing of events from
the loop to happen before the event is put into the loop, leading to
the sort of crashes we've seen with timers firing and access exceptions.
I can't reproduce those to know if this fixes them, and I'm not even sure
I'm not being dense thinking this patch fixes a real issue.
Test-Information:
Unit tests pass
Change-Id: I76337d5556a9c3902d5c2f4da754ae657810d436
Diffstat (limited to 'Swiften/FileTransfer/OutgoingFileTransferManager.cpp')
0 files changed, 0 insertions, 0 deletions