summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorRemko Tronçon <git@el-tramo.be>2013-01-02 19:48:35 (GMT)
committerRemko Tronçon <git@el-tramo.be>2013-01-02 19:50:19 (GMT)
commitbf6e16ca647c549fab4e6f6fc83ddc87d3ea9bc4 (patch)
tree29ad338bd5c9d589470d7aec40b7e7262e299b1c /Swiften/Network
parentf572ff58428c8ce6b5babb60f0ea6999d0be29d7 (diff)
downloadswift-bf6e16ca647c549fab4e6f6fc83ddc87d3ea9bc4.zip
swift-bf6e16ca647c549fab4e6f6fc83ddc87d3ea9bc4.tar.bz2
Remove incorrect CFRelease() calls in MacOSXProxyProvider.
This avoids a potential crash when using proxies on Mac OS X. Change-Id: I393ba03a6ffd89668e31c5dad8c0d7277601fc14
Diffstat (limited to 'Swiften/Network')
-rw-r--r--Swiften/Network/MacOSXProxyProvider.cpp3
1 files changed, 0 insertions, 3 deletions
diff --git a/Swiften/Network/MacOSXProxyProvider.cpp b/Swiften/Network/MacOSXProxyProvider.cpp
index eaadd28..00fb478 100644
--- a/Swiften/Network/MacOSXProxyProvider.cpp
+++ b/Swiften/Network/MacOSXProxyProvider.cpp
@@ -27,7 +27,6 @@ static HostAddressPort getFromDictionary(CFDictionaryRef dict, CFStringRef enabl
const int i = 0;
CFNumberRef zero = CFNumberCreate(kCFAllocatorDefault, kCFNumberIntType, &i);
CFComparisonResult result = CFNumberCompare(numberValue, zero, NULL);
- CFRelease(numberValue);
if(result != kCFCompareEqualTo) {
int port = 0;
@@ -37,7 +36,6 @@ static HostAddressPort getFromDictionary(CFDictionaryRef dict, CFStringRef enabl
CFNumberRef numberValue = reinterpret_cast<CFNumberRef> (CFDictionaryGetValue(dict, portKey));
if(numberValue != NULL) {
CFNumberGetValue(numberValue, kCFNumberIntType, &port);
- CFRelease(numberValue);
}
CFStringRef stringValue = reinterpret_cast<CFStringRef> (CFDictionaryGetValue(dict, hostKey));
@@ -52,7 +50,6 @@ static HostAddressPort getFromDictionary(CFDictionaryRef dict, CFStringRef enabl
host += *iter;
}
}
- CFRelease(stringValue);
}
}
catch(...) {