summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorRemko Tronçon <git@el-tramo.be>2009-12-02 23:09:55 (GMT)
committerRemko Tronçon <git@el-tramo.be>2009-12-03 08:09:01 (GMT)
commite7e514d95e190a3a7d466740a4c3a1dfa9833ccc (patch)
treefd1d70642400f5237f631a08b6f4c1b727db8160 /Swiften/Network
parent5608da36a3a319070494d5a70ff984e7c172186e (diff)
downloadswift-e7e514d95e190a3a7d466740a4c3a1dfa9833ccc.zip
swift-e7e514d95e190a3a7d466740a4c3a1dfa9833ccc.tar.bz2
Do domain resolving in a separate thread.
Diffstat (limited to 'Swiften/Network')
-rw-r--r--Swiften/Network/PlatformDomainNameResolver.cpp23
-rw-r--r--Swiften/Network/PlatformDomainNameServiceQuery.cpp19
-rw-r--r--Swiften/Network/PlatformDomainNameServiceQuery.h5
3 files changed, 44 insertions, 3 deletions
diff --git a/Swiften/Network/PlatformDomainNameResolver.cpp b/Swiften/Network/PlatformDomainNameResolver.cpp
index e30615b..3636cd6 100644
--- a/Swiften/Network/PlatformDomainNameResolver.cpp
+++ b/Swiften/Network/PlatformDomainNameResolver.cpp
@@ -7,6 +7,7 @@
#include <vector>
#include <boost/asio.hpp>
#include <boost/bind.hpp>
+#include <boost/thread.hpp>
#include <boost/enable_shared_from_this.hpp>
#include <idna.h>
#include <algorithm>
@@ -21,9 +22,24 @@ using namespace Swift;
namespace {
struct AddressQuery : public DomainNameAddressQuery, public boost::enable_shared_from_this<AddressQuery>, public EventOwner {
- AddressQuery(const String& host) : hostname(host) {}
+ AddressQuery(const String& host) : hostname(host), thread(NULL), safeToJoin(false) {}
- virtual void run() {
+ ~AddressQuery() {
+ if (safeToJoin) {
+ thread->join();
+ }
+ else {
+ // FIXME: UGLYYYYY
+ }
+ delete thread;
+ }
+
+ void run() {
+ safeToJoin = false;
+ thread = new boost::thread(boost::bind(&AddressQuery::doRun, shared_from_this()));
+ }
+
+ void doRun() {
boost::asio::ip::tcp::resolver resolver(ioService);
boost::asio::ip::tcp::resolver::query query(hostname.getUTF8String(), "5222");
try {
@@ -42,6 +58,7 @@ namespace {
catch (...) {
emitError();
}
+ safeToJoin = true;
}
void emitError() {
@@ -50,6 +67,8 @@ namespace {
boost::asio::io_service ioService;
String hostname;
+ boost::thread* thread;
+ bool safeToJoin;
};
String getNormalized(const String& domain) {
diff --git a/Swiften/Network/PlatformDomainNameServiceQuery.cpp b/Swiften/Network/PlatformDomainNameServiceQuery.cpp
index eeb9fd6..12afbb7 100644
--- a/Swiften/Network/PlatformDomainNameServiceQuery.cpp
+++ b/Swiften/Network/PlatformDomainNameServiceQuery.cpp
@@ -32,10 +32,25 @@ namespace {
namespace Swift {
-PlatformDomainNameServiceQuery::PlatformDomainNameServiceQuery(const String& service) : service(service) {
+PlatformDomainNameServiceQuery::PlatformDomainNameServiceQuery(const String& service) : thread(NULL), service(service), safeToJoin(true) {
+}
+
+PlatformDomainNameServiceQuery::~PlatformDomainNameServiceQuery() {
+ if (safeToJoin) {
+ thread->join();
+ }
+ else {
+ // FIXME: UGLYYYYY
+ }
+ delete thread;
}
void PlatformDomainNameServiceQuery::run() {
+ safeToJoin = false;
+ thread = new boost::thread(boost::bind(&PlatformDomainNameServiceQuery::doRun, shared_from_this()));
+}
+
+void PlatformDomainNameServiceQuery::doRun() {
std::vector<DomainNameServiceQuery::Result> records;
#if defined(SWIFTEN_PLATFORM_WINDOWS)
@@ -145,11 +160,13 @@ void PlatformDomainNameServiceQuery::run() {
}
#endif
+ safeToJoin = true;
std::sort(records.begin(), records.end(), SRVRecordPriorityComparator());
MainEventLoop::postEvent(boost::bind(boost::ref(onResult), records));
}
void PlatformDomainNameServiceQuery::emitError() {
+ safeToJoin = true;
MainEventLoop::postEvent(boost::bind(boost::ref(onResult), std::vector<DomainNameServiceQuery::Result>()), shared_from_this());
}
diff --git a/Swiften/Network/PlatformDomainNameServiceQuery.h b/Swiften/Network/PlatformDomainNameServiceQuery.h
index 58257af..1b1c1b5 100644
--- a/Swiften/Network/PlatformDomainNameServiceQuery.h
+++ b/Swiften/Network/PlatformDomainNameServiceQuery.h
@@ -1,5 +1,6 @@
#pragma once
+#include <boost/thread.hpp>
#include <boost/enable_shared_from_this.hpp>
#include "Swiften/Network/DomainNameServiceQuery.h"
@@ -10,13 +11,17 @@ namespace Swift {
class PlatformDomainNameServiceQuery : public DomainNameServiceQuery, public boost::enable_shared_from_this<PlatformDomainNameServiceQuery>, public EventOwner {
public:
PlatformDomainNameServiceQuery(const String& service);
+ ~PlatformDomainNameServiceQuery();
virtual void run();
private:
+ void doRun();
void emitError();
private:
+ boost::thread* thread;
+ bool safeToJoin;
String service;
};
}