summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorEdwin Mons <edwin.mons@isode.com>2014-05-19 13:08:55 (GMT)
committerSwift Review <review@swift.im>2014-05-26 17:40:21 (GMT)
commitb249168a5c7dfd4846729dcb79445afc2cf37391 (patch)
tree130bbb00157888a0847b007ea830e08146e6bb5b /Swiften/Serializer/PayloadSerializers/UnitTest/PubSubItemSerializerTest.cpp
parent168538129a69fa37a19e768149b32ca262bb85a3 (diff)
downloadswift-b249168a5c7dfd4846729dcb79445afc2cf37391.zip
swift-b249168a5c7dfd4846729dcb79445afc2cf37391.tar.bz2
Fix serialization of PubSubItem id attribute
Extended the serialization unit tests with PubSubItem and PubSubItems test, also added a warning when serializing PubSubItems without a node name. Change-Id: Ie4c4021b1cca593187c4aa333aa43dd34239b1ca
Diffstat (limited to 'Swiften/Serializer/PayloadSerializers/UnitTest/PubSubItemSerializerTest.cpp')
-rw-r--r--Swiften/Serializer/PayloadSerializers/UnitTest/PubSubItemSerializerTest.cpp59
1 files changed, 59 insertions, 0 deletions
diff --git a/Swiften/Serializer/PayloadSerializers/UnitTest/PubSubItemSerializerTest.cpp b/Swiften/Serializer/PayloadSerializers/UnitTest/PubSubItemSerializerTest.cpp
new file mode 100644
index 0000000..4ece9db
--- /dev/null
+++ b/Swiften/Serializer/PayloadSerializers/UnitTest/PubSubItemSerializerTest.cpp
@@ -0,0 +1,59 @@
+/*
+ * Copyright (c) 2014 Kevin Smith and Remko Tronçon
+ * Licensed under the GNU General Public License v3.
+ * See Documentation/Licenses/GPLv3.txt for more information.
+ */
+
+#include <boost/smart_ptr/make_shared.hpp>
+
+#include <cppunit/extensions/HelperMacros.h>
+#include <cppunit/extensions/TestFactoryRegistry.h>
+
+#include <Swiften/Elements/PubSubItem.h>
+#include <Swiften/Elements/RawXMLPayload.h>
+#include <Swiften/Serializer/PayloadSerializers/PubSubItemSerializer.h>
+#include <Swiften/Serializer/PayloadSerializers/FullPayloadSerializerCollection.h>
+
+using namespace Swift;
+
+class PubSubItemSerializerTest : public CppUnit::TestFixture {
+ CPPUNIT_TEST_SUITE(PubSubItemSerializerTest);
+ CPPUNIT_TEST(testSerialize);
+ CPPUNIT_TEST(testSerializeEmptyID);
+ CPPUNIT_TEST_SUITE_END();
+
+ public:
+ void testSerialize() {
+ PubSubItemSerializer serializer(&serializers);
+
+ boost::shared_ptr<RawXMLPayload> payload(boost::make_shared<RawXMLPayload>());
+ payload->setRawXML("<payload xmlns=\"tmp\"/>");
+
+ boost::shared_ptr<PubSubItem> item(boost::make_shared<PubSubItem>());
+ item->addData(payload);
+ item->setID("pubsub-item-1");
+
+ std::string expectedResult =
+ "<item id=\"pubsub-item-1\" xmlns=\"http://jabber.org/protocol/pubsub\">"
+ "<payload xmlns=\"tmp\"/>"
+ "</item>";
+
+ CPPUNIT_ASSERT_EQUAL(expectedResult, serializer.serialize(item));
+ }
+
+ void testSerializeEmptyID() {
+ PubSubItemSerializer serializer(&serializers);
+
+ boost::shared_ptr<PubSubItem> item(boost::make_shared<PubSubItem>());
+
+ std::string expectedResult =
+ "<item xmlns=\"http://jabber.org/protocol/pubsub\"/>";
+
+ CPPUNIT_ASSERT_EQUAL(expectedResult, serializer.serialize(item));
+ }
+
+ private:
+ FullPayloadSerializerCollection serializers;
+};
+
+CPPUNIT_TEST_SUITE_REGISTRATION(PubSubItemSerializerTest);