1 files changed, 59 insertions, 51 deletions
diff --git a/Sluift/ElementConvertors/PubSubPublishConvertor.cpp b/Sluift/ElementConvertors/PubSubPublishConvertor.cpp
index 880d9fc..d8a2742 100644
--- a/Sluift/ElementConvertors/PubSubPublishConvertor.cpp
+++ b/Sluift/ElementConvertors/PubSubPublishConvertor.cpp
@@ -1,72 +1,80 @@
 /*
- * Copyright (c) 2013 Remko Tronçon
- * Licensed under the GNU General Public License.
+ * Copyright (c) 2013-2016 Isode Limited.
+ * All rights reserved.
  * See the COPYING file for more information.
  */
 
 #include <Sluift/ElementConvertors/PubSubPublishConvertor.h>
 
-#include <lua.hpp>
-#include <boost/smart_ptr/make_shared.hpp>
+#include <memory>
+
 #include <boost/numeric/conversion/cast.hpp>
 
-#include <Sluift/LuaElementConvertors.h>
-#include <Swiften/Base/foreach.h>
+#include <lua.hpp>
 
-#pragma clang diagnostic ignored "-Wunused-private-field"
+#include <Sluift/LuaElementConvertors.h>
 
 using namespace Swift;
 
-PubSubPublishConvertor::PubSubPublishConvertor(LuaElementConvertors* convertors) : 
-		GenericLuaElementConvertor<PubSubPublish>("pubsub_publish"),
-		convertors(convertors) {
+PubSubPublishConvertor::PubSubPublishConvertor(LuaElementConvertors* convertors) :
+        GenericLuaElementConvertor<PubSubPublish>("pubsub_publish"),
+        convertors(convertors) {
 }
 
 PubSubPublishConvertor::~PubSubPublishConvertor() {
 }
 
-boost::shared_ptr<PubSubPublish> PubSubPublishConvertor::doConvertFromLua(lua_State* L) {
-	boost::shared_ptr<PubSubPublish> result = boost::make_shared<PubSubPublish>();
-	lua_getfield(L, -1, "node");
-	if (lua_isstring(L, -1)) {
-		result->setNode(std::string(lua_tostring(L, -1)));
-	}
-	lua_pop(L, 1);
-	lua_getfield(L, -1, "items");
-	if (lua_type(L, -1) == LUA_TTABLE) {
-		std::vector< boost::shared_ptr<PubSubItem> > items;
-		for(size_t i = 0; i < lua_objlen(L, -1); ++i) {
-			lua_pushnumber(L, i + 1);
-			lua_gettable(L, -2);
-			if (!lua_isnil(L, -1)) {
-				if (boost::shared_ptr<PubSubItem> payload = boost::dynamic_pointer_cast<PubSubItem>(convertors->convertFromLuaUntyped(L, -1, "pubsub_item"))) {
-					items.push_back(payload);
-				}
-			}
-			lua_pop(L, 1);
-		}
+std::shared_ptr<PubSubPublish> PubSubPublishConvertor::doConvertFromLua(lua_State* L) {
+    std::shared_ptr<PubSubPublish> result = std::make_shared<PubSubPublish>();
+    lua_getfield(L, -1, "node");
+    if (lua_isstring(L, -1)) {
+        result->setNode(std::string(lua_tostring(L, -1)));
+    }
+    lua_pop(L, 1);
+    lua_getfield(L, -1, "items");
+    if (lua_type(L, -1) == LUA_TTABLE) {
+        std::vector< std::shared_ptr<PubSubItem> > items;
+        for(size_t i = 0; i < lua_rawlen(L, -1); ++i) {
+            lua_pushnumber(L, i + 1);
+            lua_gettable(L, -2);
+            if (!lua_isnil(L, -1)) {
+                if (std::shared_ptr<PubSubItem> payload = std::dynamic_pointer_cast<PubSubItem>(convertors->convertFromLuaUntyped(L, -1, "pubsub_item"))) {
+                    items.push_back(payload);
+                }
+            }
+            lua_pop(L, 1);
+        }
+
+        result->setItems(items);
+    }
+    lua_pop(L, 1);
+    return result;
+}
 
-		result->setItems(items);
-	}
-	lua_pop(L, 1);
-	return result;
+void PubSubPublishConvertor::doConvertToLua(lua_State* L, std::shared_ptr<PubSubPublish> payload) {
+    lua_createtable(L, 0, 0);
+    lua_pushstring(L, payload->getNode().c_str());
+    lua_setfield(L, -2, "node");
+    if (!payload->getItems().empty()) {
+        lua_createtable(L, boost::numeric_cast<int>(payload->getItems().size()), 0);
+        {
+            int i = 0;
+            for (auto&& item : payload->getItems()) {
+                if (convertors->convertToLuaUntyped(L, item) > 0) {
+                    lua_rawseti(L, -2, boost::numeric_cast<int>(i+1));
+                    ++i;
+                }
+            }
+        }
+        lua_setfield(L, -2, "items");
+    }
 }
 
-void PubSubPublishConvertor::doConvertToLua(lua_State* L, boost::shared_ptr<PubSubPublish> payload) {
-	lua_createtable(L, 0, 0);
-	lua_pushstring(L, payload->getNode().c_str());
-	lua_setfield(L, -2, "node");
-	if (!payload->getItems().empty()) {
-		lua_createtable(L, boost::numeric_cast<int>(payload->getItems().size()), 0);
-		{
-			int i = 0;
-			foreach(boost::shared_ptr<PubSubItem> item, payload->getItems()) {
-				if (convertors->convertToLuaUntyped(L, item) > 0) {
-					lua_rawseti(L, -2, boost::numeric_cast<int>(i+1));
-					++i;
-				}
-			}
-		}
-		lua_setfield(L, -2, "items");
-	}
+boost::optional<LuaElementConvertor::Documentation> PubSubPublishConvertor::getDocumentation() const {
+    return Documentation(
+        "PubSubPublish",
+        "This table has the following fields:\n\n"
+        "- `node`: string\n"
+        "- `items`: array<@{PubSubItem}>\n"
+    );
 }