4 files changed, 223 insertions, 157 deletions
diff --git a/Swiften/QA/StorageTest/FileReadBytestreamTest.cpp b/Swiften/QA/StorageTest/FileReadBytestreamTest.cpp
index e090c6c..e601de9 100644
--- a/Swiften/QA/StorageTest/FileReadBytestreamTest.cpp
+++ b/Swiften/QA/StorageTest/FileReadBytestreamTest.cpp
@@ -1,7 +1,7 @@
 /*
- * Copyright (c) 2010 Remko Tronçon
- * Licensed under the GNU General Public License v3.
- * See Documentation/Licenses/GPLv3.txt for more information.
+ * Copyright (c) 2010-2016 Isode Limited.
+ * All rights reserved.
+ * See the COPYING file for more information.
  */
 
 #include <cppunit/extensions/HelperMacros.h>
@@ -9,66 +9,67 @@
 
 #include <Swiften/Base/ByteArray.h>
 #include <Swiften/FileTransfer/FileReadBytestream.h>
-#include "SwifTools/Application/PlatformApplicationPathProvider.h"
+
+#include <SwifTools/Application/PlatformApplicationPathProvider.h>
 
 using namespace Swift;
 
 class FileReadBytestreamTest : public CppUnit::TestFixture {
-		CPPUNIT_TEST_SUITE(FileReadBytestreamTest);
-		CPPUNIT_TEST(testRead);
-		CPPUNIT_TEST(testRead_Twice);
-		CPPUNIT_TEST(testIsFinished_NotFinished);
-		CPPUNIT_TEST(testIsFinished_IsFinished);
-		CPPUNIT_TEST_SUITE_END();
+        CPPUNIT_TEST_SUITE(FileReadBytestreamTest);
+        CPPUNIT_TEST(testRead);
+        CPPUNIT_TEST(testRead_Twice);
+        CPPUNIT_TEST(testIsFinished_NotFinished);
+        CPPUNIT_TEST(testIsFinished_IsFinished);
+        CPPUNIT_TEST_SUITE_END();
 
-	public:
-		void setUp() {
-			pathProvider = new PlatformApplicationPathProvider("FileReadBytestreamTest");
-		}
+    public:
+        void setUp() {
+            pathProvider = new PlatformApplicationPathProvider("FileReadBytestreamTest");
+        }
 
-		void tearDown() {
-			delete pathProvider;
-		}
+        void tearDown() {
+            delete pathProvider;
+        }
 
-		void testRead() {
-			boost::shared_ptr<FileReadBytestream> testling(createTestling());
+        void testRead() {
+            std::shared_ptr<FileReadBytestream> testling(createTestling());
 
-			std::vector<unsigned char> result = testling->read(10);
+            std::shared_ptr< std::vector<unsigned char> > result = testling->read(10);
 
-			CPPUNIT_ASSERT(ByteArray::create("/*\n * Copy") == result);
-		}
+            CPPUNIT_ASSERT(createByteArray("/*\n * Copy") == *result.get());
+        }
 
-		void testRead_Twice() {
-			boost::shared_ptr<FileReadBytestream> testling(createTestling());
+        void testRead_Twice() {
+            std::shared_ptr<FileReadBytestream> testling(createTestling());
 
-			testling->read(10);
-			ByteArray result(testling->read(10));
+            testling->read(10);
+            std::shared_ptr< std::vector<unsigned char> > result = testling->read(10);
 
-			CPPUNIT_ASSERT_EQUAL(std::string("right (c) "), result.toString());
-		}
+            CPPUNIT_ASSERT_EQUAL(std::string("right (c) "), byteArrayToString(*result));
+        }
 
-		void testIsFinished_NotFinished() {
-			boost::shared_ptr<FileReadBytestream> testling(createTestling());
+        void testIsFinished_NotFinished() {
+            std::shared_ptr<FileReadBytestream> testling(createTestling());
 
-			testling->read(10);
+            testling->read(10);
 
-			CPPUNIT_ASSERT(!testling->isFinished());
-		}
+            CPPUNIT_ASSERT(!testling->isFinished());
+        }
 
-		void testIsFinished_IsFinished() {
-			boost::shared_ptr<FileReadBytestream> testling(createTestling());
+        void testIsFinished_IsFinished() {
+            std::shared_ptr<FileReadBytestream> testling(createTestling());
 
-			testling->read(4096);
+            testling->read(4096);
 
-			CPPUNIT_ASSERT(testling->isFinished());
-		}
+            CPPUNIT_ASSERT(testling->isFinished());
+        }
 
-	private:
-		FileReadBytestream* createTestling() {
-			return new FileReadBytestream(pathProvider->getExecutableDir() / "FileReadBytestreamTest.cpp");
-		}
+    private:
+        FileReadBytestream* createTestling() {
+            return new FileReadBytestream(pathProvider->getExecutableDir() / "FileReadBytestreamTest.cpp");
+        }
 
-		PlatformApplicationPathProvider* pathProvider;
+        PlatformApplicationPathProvider* pathProvider;
 };
 
 CPPUNIT_TEST_SUITE_REGISTRATION(FileReadBytestreamTest);
diff --git a/Swiften/QA/StorageTest/FileWriteBytestreamTest.cpp b/Swiften/QA/StorageTest/FileWriteBytestreamTest.cpp
new file mode 100644
index 0000000..393d1d7
--- /dev/null
+++ b/Swiften/QA/StorageTest/FileWriteBytestreamTest.cpp
@@ -0,0 +1,58 @@
+/*
+ * Copyright (c) 2016 Isode Limited.
+ * All rights reserved.
+ * See the COPYING file for more information.
+ */
+
+#include <boost/bind.hpp>
+#include <boost/filesystem.hpp>
+#include <boost/signals2.hpp>
+
+#include <cppunit/extensions/HelperMacros.h>
+#include <cppunit/extensions/TestFactoryRegistry.h>
+
+#include <Swiften/Base/ByteArray.h>
+#include <Swiften/FileTransfer/FileWriteBytestream.h>
+
+using namespace Swift;
+
+class FileWriteBytestreamTest : public CppUnit::TestFixture {
+        CPPUNIT_TEST_SUITE(FileWriteBytestreamTest);
+        CPPUNIT_TEST(testSuccessfulWrite);
+        CPPUNIT_TEST(testFailingWrite);
+        CPPUNIT_TEST_SUITE_END();
+
+    public:
+        void setUp() {
+            onWriteWasCalled = false;
+        }
+
+        void testSuccessfulWrite() {
+            boost::filesystem::path filename = boost::filesystem::unique_path("write_file_bytestream_test_%%%%%%%%%%%%%%%%.bin");
+            std::shared_ptr<WriteBytestream> writeBytestream = std::make_shared<FileWriteBytestream>(filename.string());
+            writeBytestream->onWrite.connect(boost::bind(&FileWriteBytestreamTest::handleOnWrite, this, _1));
+
+            CPPUNIT_ASSERT_EQUAL(true, writeBytestream->write(createByteArray("Some data.")));
+            CPPUNIT_ASSERT_EQUAL(true, onWriteWasCalled);
+            writeBytestream->close();
+            boost::filesystem::remove(filename);
+        }
+
+        void testFailingWrite() {
+            std::shared_ptr<WriteBytestream> writeBytestream = std::make_shared<FileWriteBytestream>("");
+            writeBytestream->onWrite.connect(boost::bind(&FileWriteBytestreamTest::handleOnWrite, this, _1));
+
+            CPPUNIT_ASSERT_EQUAL(false, writeBytestream->write(createByteArray("Some data.")));
+            CPPUNIT_ASSERT_EQUAL(false, onWriteWasCalled);
+        }
+
+
+        void handleOnWrite(const std::vector<unsigned char>& /*data*/) {
+            onWriteWasCalled = true;
+        }
+
+    private:
+        bool onWriteWasCalled;
+};
+
+CPPUNIT_TEST_SUITE_REGISTRATION(FileWriteBytestreamTest);
diff --git a/Swiften/QA/StorageTest/SConscript b/Swiften/QA/StorageTest/SConscript
index 6d65b30..46107a0 100644
--- a/Swiften/QA/StorageTest/SConscript
+++ b/Swiften/QA/StorageTest/SConscript
@@ -3,19 +3,22 @@ import os
 Import("env")
 
 if env["TEST"] :
-	myenv = env.Clone()
-	myenv.MergeFlags(myenv["CHECKER_FLAGS"])
-	myenv.MergeFlags(myenv["SWIFTOOLS_FLAGS"])
-	myenv.MergeFlags(myenv["SWIFTEN_FLAGS"])
-	myenv.MergeFlags(myenv["CPPUNIT_FLAGS"])
-	myenv.MergeFlags(myenv["BOOST_FLAGS"])
-	myenv.MergeFlags(myenv["LIBIDN_FLAGS"])
-	myenv.MergeFlags(myenv.get("EXPAT_FLAGS", {}))
-	myenv.MergeFlags(myenv.get("LIBXML_FLAGS", {}))
-	myenv.MergeFlags(myenv["PLATFORM_FLAGS"])
+    myenv = env.Clone()
+    myenv.MergeFlags(myenv["CHECKER_FLAGS"])
+    myenv.MergeFlags(myenv["SWIFTOOLS_FLAGS"])
+    myenv.MergeFlags(myenv["SWIFTEN_FLAGS"])
+    myenv.MergeFlags(myenv["CPPUNIT_FLAGS"])
+    myenv.MergeFlags(myenv["GOOGLETEST_FLAGS"])
+    myenv.MergeFlags(myenv["BOOST_FLAGS"])
+    myenv.MergeFlags(myenv.get("LIBIDN_FLAGS", {}))
+    myenv.MergeFlags(myenv.get("ICU_FLAGS", {}))
+    myenv.MergeFlags(myenv.get("EXPAT_FLAGS", {}))
+    myenv.MergeFlags(myenv.get("LIBXML_FLAGS", {}))
+    myenv.MergeFlags(myenv["PLATFORM_FLAGS"])
 
-	tester = myenv.Program("StorageTest", [
-			"VCardFileStorageTest.cpp",
-			"FileReadBytestreamTest.cpp",
-		])
-	myenv.Test(tester, "system", is_checker = True)
+    tester = myenv.Program("StorageTest", [
+            #"VCardFileStorageTest.cpp",
+            "FileReadBytestreamTest.cpp",
+            "FileWriteBytestreamTest.cpp",
+        ])
+    myenv.Test(tester, "system", is_checker = True)
diff --git a/Swiften/QA/StorageTest/VCardFileStorageTest.cpp b/Swiften/QA/StorageTest/VCardFileStorageTest.cpp
index 4145696..1be2490 100644
--- a/Swiften/QA/StorageTest/VCardFileStorageTest.cpp
+++ b/Swiften/QA/StorageTest/VCardFileStorageTest.cpp
@@ -1,113 +1,117 @@
 /*
- * Copyright (c) 2010 Remko Tronçon
- * Licensed under the GNU General Public License v3.
- * See Documentation/Licenses/GPLv3.txt for more information.
+ * Copyright (c) 2010-2016 Isode Limited.
+ * All rights reserved.
+ * See the COPYING file for more information.
  */
 
+#include <memory>
+#include <sstream>
+
+#include <boost/algorithm/string.hpp>
+
 #include <cppunit/extensions/HelperMacros.h>
 #include <cppunit/extensions/TestFactoryRegistry.h>
-#include <boost/algorithm/string.hpp>
-#include <sstream>
 
-#include <Swiften/VCards/VCardFileStorage.h>
-#include <Swiften/JID/JID.h>
-#include "SwifTools/Application/PlatformApplicationPathProvider.h"
 #include <Swiften/Elements/VCard.h>
+#include <Swiften/JID/JID.h>
+#include <Swiften/VCards/VCardFileStorage.h>
+
+#include <SwifTools/Application/PlatformApplicationPathProvider.h>
 
 using namespace Swift;
 
 class VCardFileStorageTest : public CppUnit::TestFixture {
-		CPPUNIT_TEST_SUITE(VCardFileStorageTest);
-		CPPUNIT_TEST(testSetVCard);
-		// Temporarily disabling this, because it generates error messages on console. Need to figure
-		// out something for not showing error messages during tests.
-		//CPPUNIT_TEST(testSetVCard_LargeFilename);
-		CPPUNIT_TEST(testGetVCard);
-		CPPUNIT_TEST(testGetVCard_FileDoesNotExist);
-		//CPPUNIT_TEST(testGetVCard_LargeFilename);
-		CPPUNIT_TEST_SUITE_END();
-
-	public:
-		void setUp() {
-			pathProvider = new PlatformApplicationPathProvider("VCardStorageTest");
-			vcardsPath = pathProvider->getExecutableDir() / "vcards";
-			boost::filesystem::remove_all(vcardsPath);
-		}
-
-		void tearDown() {
-			delete pathProvider;
-			boost::filesystem::remove_all(vcardsPath);
-		}
-
-		void testSetVCard() {
-			boost::shared_ptr<VCardFileStorage> testling(createTestling());
-			VCard::ref vcard(new VCard());
-			vcard->setFullName("Alice In Wonderland");
-
-			testling->setVCard(JID("alice@wonderland.lit/TeaRoom"), vcard);
-
-			boost::filesystem::path vcardFile(vcardsPath / "alice@wonderland.lit%2fTeaRoom.xml");
-			CPPUNIT_ASSERT(boost::filesystem::exists(vcardFile));
-			ByteArray data;
-			data.readFromFile(vcardFile);
-			CPPUNIT_ASSERT(boost::starts_with(data.toString(), "<vCard xmlns=\"vcard-temp\">"));
-		}
-
-		void testSetVCard_LargeFilename() {
-			std::auto_ptr<VCardFileStorage> testling(createTestling());
-			VCard::ref vcard(new VCard());
-			vcard->setFullName("Alice In Wonderland");
-
-			std::ostringstream s;
-			for (int i = 0; i < 1000; ++i) {
-				s << "_";
-			}
-
-			JID jid("alice@wonderland.lit/" + s.str());
-			testling->setVCard(jid, vcard);
-
-			// Just check whether we don't crash
-		}
-
-		void testGetVCard() {
-			boost::shared_ptr<VCardFileStorage> testling(createTestling());
-			VCard::ref vcard(new VCard());
-			vcard->setFullName("Alice In Wonderland");
-			testling->setVCard(JID("alice@wonderland.lit"), vcard);
-
-			VCard::ref result = testling->getVCard(JID("alice@wonderland.lit"));
-			CPPUNIT_ASSERT_EQUAL(std::string("Alice In Wonderland"), result->getFullName());
-		}
-
-		void testGetVCard_LargeFilename() {
-			std::auto_ptr<VCardFileStorage> testling(createTestling());
-			VCard::ref vcard(new VCard());
-			vcard->setFullName("Alice In Wonderland");
-
-			std::ostringstream s;
-			for (int i = 0; i < 1000; ++i) {
-				s << "_";
-			}
-			JID jid("alice@wonderland.lit/" + s.str());
-
-			VCard::ref result = testling->getVCard(jid);
-
-			// Just check that we don't have an exception
-		}
-
-		void testGetVCard_FileDoesNotExist() {
-			boost::shared_ptr<VCardFileStorage> testling(createTestling());
-			VCard::ref result = testling->getVCard(JID("alice@wonderland.lit"));
-			CPPUNIT_ASSERT(!result);
-		}
-
-	private:
-		VCardFileStorage* createTestling() {
-			return new VCardFileStorage(vcardsPath);
-		}
-
-		PlatformApplicationPathProvider* pathProvider;
-		boost::filesystem::path vcardsPath;
+        CPPUNIT_TEST_SUITE(VCardFileStorageTest);
+        CPPUNIT_TEST(testSetVCard);
+        // Temporarily disabling this, because it generates error messages on console. Need to figure
+        // out something for not showing error messages during tests.
+        //CPPUNIT_TEST(testSetVCard_LargeFilename);
+        CPPUNIT_TEST(testGetVCard);
+        CPPUNIT_TEST(testGetVCard_FileDoesNotExist);
+        //CPPUNIT_TEST(testGetVCard_LargeFilename);
+        CPPUNIT_TEST_SUITE_END();
+
+    public:
+        void setUp() {
+            pathProvider = new PlatformApplicationPathProvider("VCardStorageTest");
+            vcardsPath = pathProvider->getExecutableDir() / "vcards";
+            boost::filesystem::remove_all(vcardsPath);
+        }
+
+        void tearDown() {
+            delete pathProvider;
+            boost::filesystem::remove_all(vcardsPath);
+        }
+
+        void testSetVCard() {
+            std::shared_ptr<VCardFileStorage> testling(createTestling());
+            VCard::ref vcard(new VCard());
+            vcard->setFullName("Alice In Wonderland");
+
+            testling->setVCard(JID("alice@wonderland.lit/TeaRoom"), vcard);
+
+            boost::filesystem::path vcardFile(vcardsPath / "alice@wonderland.lit%2fTeaRoom.xml");
+            CPPUNIT_ASSERT(boost::filesystem::exists(vcardFile));
+            ByteArray data;
+            data.readFromFile(vcardFile);
+            CPPUNIT_ASSERT(boost::starts_with(data.toString(), "<vCard xmlns=\"vcard-temp\">"));
+        }
+
+        void testSetVCard_LargeFilename() {
+            std::unique_ptr<VCardFileStorage> testling(createTestling());
+            VCard::ref vcard(new VCard());
+            vcard->setFullName("Alice In Wonderland");
+
+            std::ostringstream s;
+            for (int i = 0; i < 1000; ++i) {
+                s << "_";
+            }
+
+            JID jid("alice@wonderland.lit/" + s.str());
+            testling->setVCard(jid, vcard);
+
+            // Just check whether we don't crash
+        }
+
+        void testGetVCard() {
+            std::shared_ptr<VCardFileStorage> testling(createTestling());
+            VCard::ref vcard(new VCard());
+            vcard->setFullName("Alice In Wonderland");
+            testling->setVCard(JID("alice@wonderland.lit"), vcard);
+
+            VCard::ref result = testling->getVCard(JID("alice@wonderland.lit"));
+            CPPUNIT_ASSERT_EQUAL(std::string("Alice In Wonderland"), result->getFullName());
+        }
+
+        void testGetVCard_LargeFilename() {
+            std::unique_ptr<VCardFileStorage> testling(createTestling());
+            VCard::ref vcard(new VCard());
+            vcard->setFullName("Alice In Wonderland");
+
+            std::ostringstream s;
+            for (int i = 0; i < 1000; ++i) {
+                s << "_";
+            }
+            JID jid("alice@wonderland.lit/" + s.str());
+
+            VCard::ref result = testling->getVCard(jid);
+
+            // Just check that we don't have an exception
+        }
+
+        void testGetVCard_FileDoesNotExist() {
+            std::shared_ptr<VCardFileStorage> testling(createTestling());
+            VCard::ref result = testling->getVCard(JID("alice@wonderland.lit"));
+            CPPUNIT_ASSERT(!result);
+        }
+
+    private:
+        VCardFileStorage* createTestling() {
+            return new VCardFileStorage(vcardsPath);
+        }
+
+        PlatformApplicationPathProvider* pathProvider;
+        boost::filesystem::path vcardsPath;
 };
 
 CPPUNIT_TEST_SUITE_REGISTRATION(VCardFileStorageTest);