Age | Commit message (Collapse) | Author |
|
Clang was complaining about implicit conversions between
nullable and non-nullable NSString pointers. Adjusted our
std::string -> NSString* conversion utilities to check for
nil and return an empty std::string in that case.
Replaced uses of [NSString stringWithUTF8String] with our
STD2NSSTRING macro.
Turned std::string <-> NSString* conversion macros into
functions.
Test-Information:
Builds without the warning on OS X 10.11.3 and Swift runs
without issues.
Change-Id: I949f2f3332018391aead58ef362764f4b7955b01
|
|
Checked Growl and Snarl backends which both already do
the check for empty callbacks.
Test-Information:
Tested clicking on an disconnect notification of Swift on
OS X 10.11.3 which previously caused a crash. Now it does not
crash anymore in this case.
Change-Id: I7045ab22a0322cc7a50761640a9b89ba2302acef
|
|
These errors were reported by Clang Analyzer.
Test-Information:
Verified that behavior is still as expected and Clang
Analyzer does not report the warnings anymore.
Change-Id: I149d75241f7680a6d2f2b6b710dd38d1ed81a209
|
|
Test-Information:
Verified behavior on OS X 10.10.5 with two accounts,
presence changes and message exchanges.
Change-Id: I79b4b8a92076dfb4c2d65f91bfb2f808cf7821d5
|
|
This implements basic support for OS X Notification Center
notifications with simple banner notifications showing type,
contact and message/presence information. A click on the
notification opens the chat view to the contact.
The Notification Center backend will be used on OS X if the Growl
notification backend is not used.
This code requires OS X version 10.8 or later.
Test-Information:
Tested presence and message notifications between multiple Swift
accounts and instances on OS X 10.9.5.
Change-Id: I7b9e2132cab25e086e0912191562cad8f4cbae38
|
|
Change-Id: Ic5a0cd2d65caac21a748a9a6996a596ee80f5337
|
|
- Use boost::filesystem::path consistently for referring to files.
- Use boost::filesystem streams for I/O, such that paths are always handled
correctly.
- Use stringToPath and pathToString for conversion between strings and
boost::filesystem::path, to ensure we have consistent unicode handling
across platforms and environments. The default constructor and string
conversion uses platform-dependent encoding, depending on the global
locale set in the application, which causes problems. So, unless you are
in platform dependent code, the default constructor and string() function
should not be used. When constructing paths from other paths (e.g. using
operator/), also use stringToPath (instead of string arguments) if the path
can contain unicode characters.
Change-Id: If286bd9e71c8414afc0b24ba67e26ab7608ef6ea
|
|
Change-Id: I62c7d5ca44c915e36c797c798294b7c34b465514
|
|
|
|
|
|
Fixes segfaults caused by clicking notifications after
the handlers had been freed.
Does not fix GrowlNotifier, which needs fixing later.
|
|
|
|
|
|
|
|
|
|
Tweaked the sources to satisfy cppcheck.
|
|
|
|
|
|
Resolves: #818
|
|
|
|
|
|
|
|
Use balloons as a fallback.
|
|
|
|
The notifier doesn't handle callbacks yet.
Release-Notes: Replaced Snarl notifications with Growl for Windows notifications.
|
|
|
|
Release-Notes: When registering with Growl, we now request incoming
message popups to be enabled by default.
|
|
|
|
|
|
|
|
Resolves: #651
Release-Notes: The notification toggle on Linux will now be respected.
|
|
|
|
|
|
I've not actually tested this on Linux...
Resolves: #594
|
|
|
|
Resolves: #572
|
|
|
|
|
|
|
|
|
|
Doesn't work though. Need to find out why.
|
|
|
|
|
|
|
|
|