summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorNick Hudson <nick.hudson@isode.com>2015-01-13 16:25:34 (GMT)
committerNick Hudson <nick.hudson@isode.com>2015-01-14 11:50:29 (GMT)
commitd5a42a02f33df608576b90f263319cb2d9438f71 (patch)
treeafc2c041eae3cb7c16acb882fd1ed9507910f6bf /Documentation
parentad96cd3f5f8c07ad6569cbb4863c782ba0920d3d (diff)
downloadstroke-d5a42a02f33df608576b90f263319cb2d9438f71.zip
stroke-d5a42a02f33df608576b90f263319cb2d9438f71.tar.bz2
Don't use bytesConsumed from SSLEngineResult
Android Lollipop implementation reports this innaccurately during handshaking, which was causing SSL setup to fail. Now derives the information directly from ByteBuffer positions. This change is based on a similar change for Jetty at https://gist.github.com/tavianator/96e9daab0fd1a45f11f2/8cbbfe028c97cac63d3b39f575b2c317d7a174c2 Test-information: Tested Harrier with IMAPS and STARTTLS against MBox on Android 4.4 and 5.0 emulators, all connect and authenticate OK. Tested MLC on Linux, with extra debugging added - everything works, and the values returned for "lastConsumed" are the same as those returned by "bytesConsumed()" so the change appears to make no difference to behaviour for non-Android Ran unit tests - no failures. Change-Id: I54b3850136b35535918b0eb303409232d64a60b5 Reviewer: Nick Hudson <nick.hudson@isode.com>
Diffstat (limited to 'Documentation')
0 files changed, 0 insertions, 0 deletions