Swiftdiff options
| author | Alan Young <consult.awy@gmail.com> | 2015-08-06 11:08:22 (GMT) |
|---|---|---|
| committer | Kevin Smith <git@kismith.co.uk> | 2015-08-13 08:23:48 (GMT) |
| commit | dc2b35bee48261e8b06e12bd82a434af118e035e (patch) | |
| tree | c44fb0eb7bd7255aaa3defefce90079737c6b422 /README.md | |
| parent | c434ba14b5243d8eccb6d40bdc1b5e3771fd427d (diff) | |
| download | stroke-dc2b35bee48261e8b06e12bd82a434af118e035e.zip stroke-dc2b35bee48261e8b06e12bd82a434af118e035e.tar.bz2 | |
Revert pessimistic allocation of collection members in VCard.
The way a VCard is used, pessimistic allocation puts an undue load on
the Java GC.
Change-Id: Ifced03a759783db2de911fc22dd40f6e475e5596
Diffstat (limited to 'README.md')
| -rw-r--r-- | README.md | 6 |
1 files changed, 5 insertions, 1 deletions
@@ -27,4 +27,8 @@ If you want to commit changes to Stroke, first run `make .git/hooks/commit-msg` Stroke tries to be a clean and accurate port of Swiften, in order to facilitate mirroring changes. Sometimes differences are either necessary or desirable. -* `VCard.getPhoto()` returns null instead of an empty `ByteArray` when there is no photo. +* `VCard.getPhoto()` returns *null* instead of an empty `ByteArray` when there is no photo. + +* `VCard` does not allocate empty collections for unused members. +The way a VCard is used, pessimistic allocation puts an undue load on the Java GC. +Callers have to check for *null* not just `isEmpty()`.
\ No newline at end of file |